November 2021 - Wine-Devel - list.winehq.org

Re: [PATCH 3/4] wined3d: Always set GL_PIXEL_UNPACK_BINDING in wined3d_texture_gl_allocate_mutable_storage().

by Zebediah Figura

On 11/30/21 11:10, Henri Verbeet wrote: > On Tue, 30 Nov 2021 at 01:29, Zebediah Figura <zfigura(a)codeweavers.com> wrote: >> @@ -947,6 +947,9 @@ static void wined3d_texture_gl_allocate_mutable_storage(struct wined3d_texture_g >> TRACE("texture_gl %p, layer %u, level %u, target %#x, width %u, height %u.\n", >> texture_gl, layer, level, target, width, height); >> >> + GL_EXTCALL(glBindBuffer(GL_PIXEL_UNPACK_BUFFER, 0)); >> + checkGLcall("glBindBuffer"); >> + > Sure, but I don't think this needs to be inside the loop. > > Also, "GL_PIXEL_UNPACK_BINDING" isn't a thing. There's > GL_PIXEL_UNPACK_BUFFER_BINDING, but in that case it would probably > have been best to use that in patches 1/4 and 2/4 as well. > Nope, that was just a temporary bout of aphasia...

Nov. 30, 2021

Re: [PATCH] d3d9/tests: Add more tests for fullscreen window size reset.

by Henri Verbeet

Though for what it's worth, note that this test has equivalents in other D3D versions as well.

Nov. 30, 2021

Re: [PATCH 3/4] wined3d: Always set GL_PIXEL_UNPACK_BINDING in wined3d_texture_gl_allocate_mutable_storage().

by Henri Verbeet

On Tue, 30 Nov 2021 at 01:29, Zebediah Figura <zfigura(a)codeweavers.com> wrote: > @@ -947,6 +947,9 @@ static void wined3d_texture_gl_allocate_mutable_storage(struct wined3d_texture_g > TRACE("texture_gl %p, layer %u, level %u, target %#x, width %u, height %u.\n", > texture_gl, layer, level, target, width, height); > > + GL_EXTCALL(glBindBuffer(GL_PIXEL_UNPACK_BUFFER, 0)); > + checkGLcall("glBindBuffer"); > + Sure, but I don't think this needs to be inside the loop. Also, "GL_PIXEL_UNPACK_BINDING" isn't a thing. There's GL_PIXEL_UNPACK_BUFFER_BINDING, but in that case it would probably have been best to use that in patches 1/4 and 2/4 as well.

Nov. 30, 2021

Re: [PATCH 2/4] wined3d: Always set GL_PIXEL_PACK_BUFFER binding in texture2d_read_from_framebuffer().

by Henri Verbeet

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>

Nov. 30, 2021

Re: [PATCH 1/4] wined3d: Always set GL_PIXEL_PACK_BUFFER binding before downloading texture data.

by Henri Verbeet

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>

Nov. 30, 2021

Re: [PATCH v2] dxgi: Silence a noisy fixme.

by Henri Verbeet

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>

Nov. 30, 2021

Re: [PATCH] d3d9/tests: Add more tests for fullscreen window size reset.

by Henri Verbeet

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>

Nov. 30, 2021

Re: [PATCH vkd3d 2/4] vkd3d-shader/hlsl: Add texcoord_offset field to hlsl_ir_resource_load.

by Zebediah Figura

On 11/26/21 09:40, Francisco Casas wrote: > diff --git a/libs/vkd3d-shader/hlsl.h b/libs/vkd3d-shader/hlsl.h > index e7bdb45e..fc078708 100644 > --- a/libs/vkd3d-shader/hlsl.h > +++ b/libs/vkd3d-shader/hlsl.h > @@ -386,6 +386,7 @@ struct hlsl_ir_resource_load > enum hlsl_resource_load_type load_type; > struct hlsl_deref resource, sampler; > struct hlsl_src coords; > + struct hlsl_src texcoord_offset; > }; > > struct hlsl_ir_store This is a texel offset, though, not a texture coordinate offset.

Nov. 30, 2021

Re: [PATCH] ntdll: Set rcx and r11 on exit from syscall dispatcher on x64.

by Jinoh Kang

After some testing I found out that the patch's behaviour is inaccurate. The attached test program does the following: 1. Set R10 to 0xdeadbeef5a5a5a5a and R11 to 0x0123456789ABCDEF. 2. Generate a page fault. 3. Set R10 to 0xcafebabea5a5a5a5 and R11 to 0xfedcba9876543210. 4. Issue a system call that pauses the current thread. 5. Switch to another thread, and dump the previous thread's registers. 6. Set all bits in EFLAGS to 1. (0xffffffffffffffff) 7. Dump the previous thread's registers again. Its output on Windows 10 (20H2) is: > SharedUserData.SystemCall = 0000000000 > > Before set context: > EFlags = 0x0000000000000246 R11 = 0x0123456789abcdef > RIP = 0x00007ffa09e504d4 RCX = 0x0000000000000088 > RSP = 0x0000000000ccfef8 R10 = 0xdeadbeef5a5a5a5a > > After set context: > EFlags = 0x0000000000210fd5 R11 = 0x0123456789abcdef > RIP = 0x00007ffa09e504d4 RCX = 0x0000000000000088 > RSP = 0x0000000000ccfef8 R10 = 0xdeadbeef5a5a5a5a >From this we can observe the following: A. KiFastSystemCall doesn't clear bit 1 in R11 by itself. Rather, it's the job of NtSetContextThread. B. KiFastSystemCall ignores registers clobbered by the SYSCALL instruction. It does try to pretend that the 1st argument is being passed to RCX, which leaves the actual 1st argument register (R11) unmodified in CONTEXT. (Also note that this implies the presence of a flag in the real kernel that records whether R10/R11 are set to valid values or not. Otherwise, the kernel would be unable to use SYSRET since R11 != RFLAGS, etc.) C. Other entrances to kernel (e.g. a page fault) do record all registers. These values are preserved until the next time the thread switches to kernel mode. -- Sincerely, Jinoh Kang

Nov. 30, 2021

Re: [PATCH 1/3] ws2_32: Implement AI_DNS_ONLY using DNS APIs.

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=103005 Your paranoid android. === debiant2 (64 bit WoW report) === ws2_32: sock.c:1135: Test failed: wait failed, error 258

Nov. 30, 2021