December 2021 - Wine-Devel - list.winehq.org

Re: [PATCH vkd3d v8 2/4] vkd3d-shader/hlsl: Handle conditionals in copy propagation.

by Giovanni Mascellani

Hi, On 01/12/21 10:00, Matteo Bruni wrote: > Good catch. It's caused by the return in the HLSL_IR_IF case in > copy_propagation_transform_block(), we want to turn that to a break. > I'll make that change, among others, before resending. Yeah, agreed, thanks for debugging that. Same thing for the loop, of course. Giovanni.

Dec. 1, 2021

Re: [PATCH vkd3d v8 2/4] vkd3d-shader/hlsl: Handle conditionals in copy propagation.

by Matteo Bruni

On Tue, Nov 30, 2021 at 7:10 PM Zebediah Figura <zfigura(a)codeweavers.com> wrote: > > So this is failing to optimize the following program, and I can't see why: > > uniform int i; > > float main() : sv_target > { > float x = 0; > if (0){} > return x; > } > > It generates the following code: > > 2: float | 0.00000000e+00 > 3: | = (x.x @2) > 4: int | 0 > 5: | if (@4) { > } else { > } > 6: float | x > 7: | = (<retval-0x5620633a6280>.x @6) > 8: | return > 9: uint | 0 > 10: float | <retval-0x5620633a6280>[@9] > 11: | = (<output-sv_target0>.x @10) > > I'd expect @6 to be rewritten to @2.x, but that doesn't happen. Do you > know why? Good catch. It's caused by the return in the HLSL_IR_IF case in copy_propagation_transform_block(), we want to turn that to a break. I'll make that change, among others, before resending.

Dec. 1, 2021

Re: [PATCH] ntdll: Set rcx and r11 on exit from syscall dispatcher on x64.

by Jinoh Kang

On 12/1/21 14:34, Jinoh Kang wrote: > My speculation is that there's a flag that determines whether it's OK to clobber > RCX/R11 on syscall exit. If it's enabled, KiFastSystemCall will use SYSRET > instead of IRETQ. Issuing NtSetContextThread with CONTEXT_INTEGER on supposedly > turns this flag off, disabling the use of SYSRET. From the observations so far, > this flag more or less corresponds to CONTEXT_CONTROL in CONTEXT_INTEGER*. My apologies. > syscall_frame::restore_flags, but more testing is required... -- Sincerely, Jinoh Kang

Dec. 1, 2021

Re: [PATCH] ntdll: Set rcx and r11 on exit from syscall dispatcher on x64.

by Jinoh Kang

On 12/1/21 08:43, Paul Gofman wrote: > I am sorry, I actually somehow missed the actual test program thus all of my prior questions. No worries. > > While you are probably right in your assessment it still seems to me that these aspects are a bit orthogonal to what I am trying to do. I agree. In fact I find these results surprising too, which I had no prior knowledge. > Wine does not handle page faults, host OS does that directly thus we can't track the influence of that on the context, Yes, we can't achieve that without severe performance penalties. > nor I know any application which depends on that. Hopefully... > That suggests though that trying to simulate r11 the way my patch does probably doesn't make much sense. > > I think I will resend the patch without touching r11 at all. Thanks! > > Then, if I read your test correctly, WRT rcx handling, you show that the value in rcx stored in the context is not the one my test shows on syscall exit (the rcx in the context is supposed to be the first argument to syscall, right?). Yes, KiFastSystemCall seems to internally reverse the effect of "mov r10, rcx" in the ntdll stub prologue (presumably for compatibility with INT 2Eh). > But my patch doesn't touch the rcx value in the context (and your test confirms that it should not). You're right -- it shouldn't. My speculation is that there's a flag that determines whether it's OK to clobber RCX/R11 on syscall exit. If it's enabled, KiFastSystemCall will use SYSRET instead of IRETQ. Issuing NtSetContextThread with CONTEXT_INTEGER on supposedly turns this flag off, disabling the use of SYSRET. From the observations so far, this flag more or less corresponds to CONTEXT_CONTROL in syscall_frame::restore_flags, but more testing is required... > > > On 11/30/21 20:22, Paul Gofman wrote: >> Thanks for testing this. First of all, I did not try to simulate every bit of volatile registers clobbering performed by the kernel. Maybe my mistake here is rather touching r11 at all (while I mostly care about rcx now) or at least making those changes in a single patch. Yet your analysis might be quite helpful, although I can't say I could follow completely. My questions are inline. >> >> On 11/30/21 19:56, Jinoh Kang wrote: >>> After some testing I found out that the patch's behaviour is inaccurate. >>> >>> The attached test program does the following: >>> >>> 1. Set R10 to 0xdeadbeef5a5a5a5a and R11 to 0x0123456789ABCDEF. >>> 2. Generate a page fault. >> By page fault do you mean exactly page fault per se (transparently handled by kernel) or access violation? If that's the first not sure what exactly is it supposed to influence? >>> 3. Set R10 to 0xcafebabea5a5a5a5 and R11 to 0xfedcba9876543210. >> Set where? If p. 2., concerns access violoation, do you mean in vectored handle? Or maybe I am not following completely. >>> 4. Issue a system call that pauses the current thread. >> >> Which exactly do you mean, to be sure? >> >>> 5. Switch to another thread, and dump the previous thread's registers. >>> 6. Set all bits in EFLAGS to 1. (0xffffffffffffffff) >>> 7. Dump the previous thread's registers again. >> >> Basically I think it would be much easier to follow if that was expressed in some sort of pseudocode naming specific functions / seh handlers etc. >> >> >>> Its output on Windows 10 (20H2) is: >>> >>>> SharedUserData.SystemCall = 0000000000 >>>> >>>> Before set context: >>>> EFlags = 0x0000000000000246 R11 = 0x0123456789abcdef >>>> RIP = 0x00007ffa09e504d4 RCX = 0x0000000000000088 >>>> RSP = 0x0000000000ccfef8 R10 = 0xdeadbeef5a5a5a5a >>>> >>>> After set context: >>>> EFlags = 0x0000000000210fd5 R11 = 0x0123456789abcdef >>>> RIP = 0x00007ffa09e504d4 RCX = 0x0000000000000088 >>>> RSP = 0x0000000000ccfef8 R10 = 0xdeadbeef5a5a5a5a >>> From this we can observe the following: >>> >>> A. KiFastSystemCall doesn't clear bit 1 in R11 by itself. >>> Rather, it's the job of NtSetContextThread. >> >> Yeah, regardless of how this is concluded from a test it looks like cleaner way to do it to me. >> >> >>> >>> B. KiFastSystemCall ignores registers clobbered by the SYSCALL instruction. >>> It does try to pretend that the 1st argument is being passed to RCX, >>> which leaves the actual 1st argument register (R11) unmodified in CONTEXT. >>> (Also note that this implies the presence of a flag in the real kernel >>> that records whether R10/R11 are set to valid values or not. Otherwise, >>> the kernel would be unable to use SYSRET since R11 != RFLAGS, etc.) >> >>> C. Other entrances to kernel (e.g. a page fault) do record all registers. >>> These values are preserved until the next time the thread switches to >>> kernel mode. >>> >> Again, it would be better to clarify what is meant by page fault but from this context I suspect you mean access violation (or other exception)? In Wine this is handled separately, the syscall_dispatcher() is not involved neither for entering the Unix part (that is done from signal) nor from continuing to user mode (that is done by setting registers from the signal handler and returning right to user mode ntdll entry point). Do you mean your test suggest some modifications to this part? That might be interesting to know but I didn't have an intention to cover all of that at once. >> > -- Sincerely, Jinoh Kang

Dec. 1, 2021

[PATCH resend3 4/4] ntdll: Add stub RtlLookupElementGenericTable function

by Alex Henrie

From: Vijay Kiran Kamuju <infyquest(a)gmail.com> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49426 Signed-off-by: Vijay Kiran Kamuju <infyquest(a)gmail.com> Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> --- dlls/ntdll/ntdll.spec | 2 +- dlls/ntdll/rtl.c | 8 ++++++++ dlls/ntoskrnl.exe/ntoskrnl.exe.spec | 2 +- include/ddk/ntddk.h | 1 + 4 files changed, 11 insertions(+), 2 deletions(-) diff --git a/dlls/ntdll/ntdll.spec b/dlls/ntdll/ntdll.spec index 695a30cf25c..85bc32a1a15 100644 --- a/dlls/ntdll/ntdll.spec +++ b/dlls/ntdll/ntdll.spec @@ -853,7 +853,7 @@ # @ stub RtlLockMemoryStreamRegion # @ stub RtlLogStackBackTrace @ stdcall RtlLookupAtomInAtomTable(ptr wstr ptr) -@ stub RtlLookupElementGenericTable +@ stdcall RtlLookupElementGenericTable(ptr ptr) # @ stub RtlLookupElementGenericTableAvl @ stdcall -arch=arm,arm64,x86_64 RtlLookupFunctionEntry(long ptr ptr) @ stdcall RtlMakeSelfRelativeSD(ptr ptr ptr) diff --git a/dlls/ntdll/rtl.c b/dlls/ntdll/rtl.c index 9b4dda906e9..f40a40a6aae 100644 --- a/dlls/ntdll/rtl.c +++ b/dlls/ntdll/rtl.c @@ -473,6 +473,14 @@ void * WINAPI RtlGetElementGenericTable(RTL_GENERIC_TABLE *table, ULONG index) return NULL; } +/****************************************************************************** + * RtlLookupElementGenericTable [NTDLL.@] + */ +void * WINAPI RtlLookupElementGenericTable(RTL_GENERIC_TABLE *table, void *buffer) +{ + FIXME("(%p, %p) stub!\n", table, buffer); + return NULL; +} /****************************************************************************** * RtlMoveMemory [NTDLL.@] * diff --git a/dlls/ntoskrnl.exe/ntoskrnl.exe.spec b/dlls/ntoskrnl.exe/ntoskrnl.exe.spec index 7bfbebc92a8..d445c5a5557 100644 --- a/dlls/ntoskrnl.exe/ntoskrnl.exe.spec +++ b/dlls/ntoskrnl.exe/ntoskrnl.exe.spec @@ -1183,7 +1183,7 @@ @ stdcall RtlLocateLegacyContext(ptr ptr) @ stub RtlLockBootStatusData @ stdcall RtlLookupAtomInAtomTable(ptr wstr ptr) -@ stub RtlLookupElementGenericTable +@ stdcall RtlLookupElementGenericTable(ptr ptr) @ stub RtlLookupElementGenericTableAvl @ stub RtlLookupElementGenericTableFull @ stub RtlLookupElementGenericTableFullAvl diff --git a/include/ddk/ntddk.h b/include/ddk/ntddk.h index 2940436d0ca..a6b2974ee6a 100644 --- a/include/ddk/ntddk.h +++ b/include/ddk/ntddk.h @@ -269,6 +269,7 @@ void * WINAPI RtlGetElementGenericTable(PRTL_GENERIC_TABLE,ULONG); void WINAPI RtlInitializeGenericTable(PRTL_GENERIC_TABLE,PRTL_GENERIC_COMPARE_ROUTINE,PRTL_GENERIC_ALLOCATE_ROUTINE,PRTL_GENERIC_FREE_ROUTINE,void *); void WINAPI RtlInitializeGenericTableAvl(PRTL_AVL_TABLE,PRTL_AVL_COMPARE_ROUTINE,PRTL_AVL_ALLOCATE_ROUTINE, PRTL_AVL_FREE_ROUTINE,void *); void WINAPI RtlInsertElementGenericTableAvl(PRTL_AVL_TABLE,void *,ULONG,BOOL*); +void * WINAPI RtlLookupElementGenericTable(PRTL_GENERIC_TABLE,void *); ULONG WINAPI RtlNumberGenericTableElements(PRTL_GENERIC_TABLE); #endif -- 2.34.1

Dec. 1, 2021

[PATCH resend3 3/4] ntdll: Add stub RtlGetElementGenericTable function

by Alex Henrie

From: Vijay Kiran Kamuju <infyquest(a)gmail.com> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49426 Signed-off-by: Vijay Kiran Kamuju <infyquest(a)gmail.com> Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> --- dlls/ntdll/ntdll.spec | 2 +- dlls/ntdll/rtl.c | 9 +++++++++ dlls/ntoskrnl.exe/ntoskrnl.exe.spec | 2 +- include/ddk/ntddk.h | 1 + 4 files changed, 12 insertions(+), 2 deletions(-) diff --git a/dlls/ntdll/ntdll.spec b/dlls/ntdll/ntdll.spec index 343db34cb6d..695a30cf25c 100644 --- a/dlls/ntdll/ntdll.spec +++ b/dlls/ntdll/ntdll.spec @@ -708,7 +708,7 @@ @ stdcall RtlGetCurrentProcessorNumberEx(ptr) @ stdcall RtlGetCurrentTransaction() @ stdcall RtlGetDaclSecurityDescriptor(ptr ptr ptr ptr) -@ stub RtlGetElementGenericTable +@ stdcall RtlGetElementGenericTable(ptr long) # @ stub RtlGetElementGenericTableAvl @ stdcall RtlGetEnabledExtendedFeatures(int64) @ stdcall RtlGetExePath(wstr ptr) diff --git a/dlls/ntdll/rtl.c b/dlls/ntdll/rtl.c index c4b844f3756..9b4dda906e9 100644 --- a/dlls/ntdll/rtl.c +++ b/dlls/ntdll/rtl.c @@ -464,6 +464,15 @@ ULONG WINAPI RtlNumberGenericTableElements(RTL_GENERIC_TABLE *table) return table->NumberGenericTableElements; } +/****************************************************************************** + * RtlGetElementGenericTable [NTDLL.@] + */ +void * WINAPI RtlGetElementGenericTable(RTL_GENERIC_TABLE *table, ULONG index) +{ + FIXME("(%p, %u) stub!\n", table, index); + return NULL; +} + /****************************************************************************** * RtlMoveMemory [NTDLL.@] * diff --git a/dlls/ntoskrnl.exe/ntoskrnl.exe.spec b/dlls/ntoskrnl.exe/ntoskrnl.exe.spec index 0cd50785ad6..7bfbebc92a8 100644 --- a/dlls/ntoskrnl.exe/ntoskrnl.exe.spec +++ b/dlls/ntoskrnl.exe/ntoskrnl.exe.spec @@ -1098,7 +1098,7 @@ @ stdcall RtlGetControlSecurityDescriptor(ptr ptr ptr) @ stdcall RtlGetDaclSecurityDescriptor(ptr ptr ptr ptr) @ stub RtlGetDefaultCodePage -@ stub RtlGetElementGenericTable +@ stdcall RtlGetElementGenericTable(ptr long) @ stub RtlGetElementGenericTableAvl @ stdcall RtlGetExtendedContextLength(long ptr) @ stdcall RtlGetExtendedContextLength2(long ptr int64) diff --git a/include/ddk/ntddk.h b/include/ddk/ntddk.h index 569552bcad0..2940436d0ca 100644 --- a/include/ddk/ntddk.h +++ b/include/ddk/ntddk.h @@ -265,6 +265,7 @@ NTSTATUS WINAPI PsSetCreateProcessNotifyRoutine(PCREATE_PROCESS_NOTIFY_ROUTINE, NTSTATUS WINAPI PsSetCreateProcessNotifyRoutineEx(PCREATE_PROCESS_NOTIFY_ROUTINE_EX,BOOLEAN); NTSTATUS WINAPI PsSetCreateThreadNotifyRoutine(PCREATE_THREAD_NOTIFY_ROUTINE); NTSTATUS WINAPI PsSetLoadImageNotifyRoutine(PLOAD_IMAGE_NOTIFY_ROUTINE); +void * WINAPI RtlGetElementGenericTable(PRTL_GENERIC_TABLE,ULONG); void WINAPI RtlInitializeGenericTable(PRTL_GENERIC_TABLE,PRTL_GENERIC_COMPARE_ROUTINE,PRTL_GENERIC_ALLOCATE_ROUTINE,PRTL_GENERIC_FREE_ROUTINE,void *); void WINAPI RtlInitializeGenericTableAvl(PRTL_AVL_TABLE,PRTL_AVL_COMPARE_ROUTINE,PRTL_AVL_ALLOCATE_ROUTINE, PRTL_AVL_FREE_ROUTINE,void *); void WINAPI RtlInsertElementGenericTableAvl(PRTL_AVL_TABLE,void *,ULONG,BOOL*); -- 2.34.1

Dec. 1, 2021

[PATCH resend3 2/4] ntdll: Implement RtlNumberGenericTableElements

by Alex Henrie

From: Vijay Kiran Kamuju <infyquest(a)gmail.com> Signed-off-by: Vijay Kiran Kamuju <infyquest(a)gmail.com> Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> --- dlls/ntdll/rtl.c | 4 ++-- include/ddk/ntddk.h | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/dlls/ntdll/rtl.c b/dlls/ntdll/rtl.c index 657d0ffd091..c4b844f3756 100644 --- a/dlls/ntdll/rtl.c +++ b/dlls/ntdll/rtl.c @@ -460,8 +460,8 @@ void * WINAPI RtlEnumerateGenericTableWithoutSplaying(RTL_GENERIC_TABLE *table, */ ULONG WINAPI RtlNumberGenericTableElements(RTL_GENERIC_TABLE *table) { - FIXME("(%p) stub!\n", table); - return 0; + TRACE("(%p)\n", table); + return table->NumberGenericTableElements; } /****************************************************************************** diff --git a/include/ddk/ntddk.h b/include/ddk/ntddk.h index 3a1d68b1fa8..569552bcad0 100644 --- a/include/ddk/ntddk.h +++ b/include/ddk/ntddk.h @@ -268,5 +268,6 @@ NTSTATUS WINAPI PsSetLoadImageNotifyRoutine(PLOAD_IMAGE_NOTIFY_ROUTINE); void WINAPI RtlInitializeGenericTable(PRTL_GENERIC_TABLE,PRTL_GENERIC_COMPARE_ROUTINE,PRTL_GENERIC_ALLOCATE_ROUTINE,PRTL_GENERIC_FREE_ROUTINE,void *); void WINAPI RtlInitializeGenericTableAvl(PRTL_AVL_TABLE,PRTL_AVL_COMPARE_ROUTINE,PRTL_AVL_ALLOCATE_ROUTINE, PRTL_AVL_FREE_ROUTINE,void *); void WINAPI RtlInsertElementGenericTableAvl(PRTL_AVL_TABLE,void *,ULONG,BOOL*); +ULONG WINAPI RtlNumberGenericTableElements(PRTL_GENERIC_TABLE); #endif -- 2.34.1

Dec. 1, 2021

[PATCH resend3 1/4] ntdll: Implement RtlInitializeGenericTable

by Alex Henrie

From: Vijay Kiran Kamuju <infyquest(a)gmail.com> Signed-off-by: Vijay Kiran Kamuju <infyquest(a)gmail.com> Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> --- dlls/ntdll/rtl.c | 13 ++++++++++++- include/ddk/ntddk.h | 1 + 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/dlls/ntdll/rtl.c b/dlls/ntdll/rtl.c index 1e359e4a043..657d0ffd091 100644 --- a/dlls/ntdll/rtl.c +++ b/dlls/ntdll/rtl.c @@ -429,7 +429,18 @@ void WINAPI RtlInitializeGenericTable(RTL_GENERIC_TABLE *table, PRTL_GENERIC_COM PRTL_GENERIC_ALLOCATE_ROUTINE allocate, PRTL_GENERIC_FREE_ROUTINE free, void *context) { - FIXME("(%p, %p, %p, %p, %p) stub!\n", table, compare, allocate, free, context); + TRACE("(%p, %p, %p, %p, %p)\n", table, compare, allocate, free, context); + + table->TableRoot = NULL; + table->InsertOrderList.Flink = &(table->InsertOrderList); + table->InsertOrderList.Blink = &(table->InsertOrderList); + table->OrderedPointer = &(table->InsertOrderList); + table->NumberGenericTableElements = 0; + table->WhichOrderedElement = 0; + table->CompareRoutine = compare; + table->AllocateRoutine = allocate; + table->FreeRoutine = free; + table->TableContext = context; } /****************************************************************************** diff --git a/include/ddk/ntddk.h b/include/ddk/ntddk.h index 41ad3d721bd..3a1d68b1fa8 100644 --- a/include/ddk/ntddk.h +++ b/include/ddk/ntddk.h @@ -265,6 +265,7 @@ NTSTATUS WINAPI PsSetCreateProcessNotifyRoutine(PCREATE_PROCESS_NOTIFY_ROUTINE, NTSTATUS WINAPI PsSetCreateProcessNotifyRoutineEx(PCREATE_PROCESS_NOTIFY_ROUTINE_EX,BOOLEAN); NTSTATUS WINAPI PsSetCreateThreadNotifyRoutine(PCREATE_THREAD_NOTIFY_ROUTINE); NTSTATUS WINAPI PsSetLoadImageNotifyRoutine(PLOAD_IMAGE_NOTIFY_ROUTINE); +void WINAPI RtlInitializeGenericTable(PRTL_GENERIC_TABLE,PRTL_GENERIC_COMPARE_ROUTINE,PRTL_GENERIC_ALLOCATE_ROUTINE,PRTL_GENERIC_FREE_ROUTINE,void *); void WINAPI RtlInitializeGenericTableAvl(PRTL_AVL_TABLE,PRTL_AVL_COMPARE_ROUTINE,PRTL_AVL_ALLOCATE_ROUTINE, PRTL_AVL_FREE_ROUTINE,void *); void WINAPI RtlInsertElementGenericTableAvl(PRTL_AVL_TABLE,void *,ULONG,BOOL*); -- 2.34.1

Dec. 1, 2021

Re: [PATCH 2/4] kernel32: Forward SetCachedSigningLevel to kernelbase.

by Mohamad Al-Jaf

Hi Paul, Thank you for the brief but informative tutorial. Based on my understanding of what Chip said, the function should be imported because the address differs between kernel32 and kernelbase. I have submitted a revised patch. On Tue, Nov 30, 2021 at 3:20 AM Paul Gofman <pgofman(a)codeweavers.com> wrote: > You can examine GetProcAddress result. E. g. call GetProcAddress for the > function in question from kernel32 and kernelbase and see if the result is > the same or not. > > On 30 Nov 2021, at 07:31, Mohamad Al-Jaf <mohamadaljaf(a)gmail.com> wrote: > > > Hi Chip, > > Thanks for the detailed explanation, I think I understand the difference > between the two now. But how do you determine if a function should be > forwarded or imported? Is there a way to find out for certain? So > for SetCachedSigningLevel, how can I know if it's better to forward it or > import it? > > On Mon, Nov 29, 2021 at 9:57 PM Chip Davis <cdavis(a)codeweavers.com> wrote: > >> Normally, a forwarded function gets a special export entry which records >> the name of the DLL that has the real implementation and the name or >> ordinal of the target function. That way, when the loader resolves imports, >> it can resolve them directly to the real implementation instead of to a >> thunk in the imported DLL, like you'd have otherwise. But on Windows, a >> number of functions that would otherwise be forwarded to kernelbase from >> kernel32 instead use these thunks that call the target in >> kernelbase--presumably because existing programs abuse hotpatching to hook >> functions that were in kernel32. For these cases, winebuild supports a >> special option on a forwarded export which causes it to generate this thunk. >> >> November 29, 2021 7:08 PM, "Mohamad Al-Jaf" <mohamadaljaf(a)gmail.com >> <mohamadaljaf(a)gmail.com?to=%22Mohamad%20Al-Jaf%22%20%3Cmohamadaljaf(a)gmail.com%3E>> >> wrote: >> >> E-mail resend: Forgot to reply-all. >> Interesting, why do you think this? How does one know how to find out if >> forwarding or importing is more appropriate? Also, what exactly is the >> difference between the two? >> On Mon, Nov 29, 2021 at 3:11 AM Nikolay Sivov <nsivov(a)codeweavers.com> >> wrote: >> >> It's possible it should be using -import for this function. >> >> >> >> Chip >> >

Dec. 1, 2021

[PATCH v2 3/3] api-ms-win-security-base-l1-2-0: Forward SetCachedSigningLevel to kernelbase.

by Mohamad Al-Jaf

In Windows 10 this function is forwarded to kernelbase. Signed-off-by: Mohamad Al-Jaf <mohamadaljaf(a)gmail.com> --- v2: kernel32: Use import for SetCachedSigningLevel. Thanks Chip Davis, Nikolay Sivov, and Paul Gofman. --- .../api-ms-win-security-base-l1-2-0.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/api-ms-win-security-base-l1-2-0/api-ms-win-security-base-l1-2-0.spec b/dlls/api-ms-win-security-base-l1-2-0/api-ms-win-security-base-l1-2-0.spec index fc9af375db6..771407fc203 100644 --- a/dlls/api-ms-win-security-base-l1-2-0/api-ms-win-security-base-l1-2-0.spec +++ b/dlls/api-ms-win-security-base-l1-2-0/api-ms-win-security-base-l1-2-0.spec @@ -87,7 +87,7 @@ @ stub QuerySecurityAccessMask @ stdcall RevertToSelf() advapi32.RevertToSelf @ stdcall SetAclInformation(ptr ptr long long) advapi32.SetAclInformation -@ stub SetCachedSigningLevel +@ stdcall SetCachedSigningLevel(ptr long long long) kernelbase.SetCachedSigningLevel @ stdcall SetFileSecurityW(wstr long ptr) advapi32.SetFileSecurityW @ stdcall SetKernelObjectSecurity(long long ptr) advapi32.SetKernelObjectSecurity @ stdcall SetPrivateObjectSecurity(long ptr ptr ptr long) advapi32.SetPrivateObjectSecurity -- 2.34.1

Dec. 1, 2021