January 2022 - Wine-Devel - list.winehq.org

Re: [PATCH vkd3d 1/2] vkd3d: Always use _BitScanReverse on Windows.

by Henri Verbeet

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>

Jan. 28, 2022

Re: [PATCH vkd3d v4 2/6] tests: Test a number of simple HLSL operations.

by Giovanni Mascellani

Hi, Il 28/01/22 15:53, Francisco Casas ha scritto: > Probably because float doesn't have enough precision to represent 4294967300. Precisely. Technically the native compiler is a bit more correct than what I wrote, because it's true that the actually representable value is 4294967296, not 4294967300. But they both map to the same float value. A useful tool to experiment with this stuff is https://evanw.github.io/float-toy/. Giovanni.

Jan. 28, 2022

Re: [PATCH] iphlpapi: Avoid use of uninitialized variable

by Gerald Pfeifer

On Fri, 28 Jan 2022, Huw Davies wrote: > It's actually not used unconditionally, since it's only used if > sockaddr.si_family is non-zero, in which case it will have been > initialised. > > It makes more sense to zero-init where sockaddr in also initialised > since we're in a loop. > > I've sent in v2. Very cool. Thank you, Huw! Gerald

Jan. 28, 2022

Re: [PATCH vkd3d v4 1/6] tests: Test matrix multiplication.

by Giovanni Mascellani

Hi, Il 28/01/22 14:35, Francisco Casas ha scritto: > It seems that mul checks whether it is a scalar-scalar, scalar-vector, > scalar-matrix, vector-scalar, vector-vector, vector-matrix, matrix-scalar, > matrix-vector, or matrix-matrix multiplication, using the equivalent to our > hlsl_type_class. > > This difference makes me wonder whether we are wrong assuming float and float1 > are the same in other parts of the codebase, for instance: As you say float and float1 are two different things in HLSL, but once we are deep enough in the pipeline that all the relevant operations (like mul()) have been lowered, then we can ignore the difference. As (I think) I have said in another email, what I would like to happen is that at some point everything is converted to vectors (so we don't have scalars lingering around anymore), but it doesn't seem that the others agree with me. Giovanni.

Jan. 28, 2022

Re: [PATCH vkd3d 2/2] vkd3d: Replace atomic_add_fetch() by InterlockedAdd().

by Henri Verbeet

On Fri, 28 Jan 2022 at 16:10, Alexandre Julliard <julliard(a)winehq.org> wrote: > @@ -410,7 +410,7 @@ static void *vkd3d_fence_worker_main(void *arg) > { > vkd3d_wait_for_gpu_fences(worker); > > - if (!worker->fence_count || atomic_add_fetch(&worker->enqueued_fence_count, 0)) > + if (!worker->fence_count || InterlockedAdd(&worker->enqueued_fence_count, 0)) > { Unfortunately this introduces build warnings for the non-PE builds: <vkd3d>/libs/vkd3d/command.c: In function ‘vkd3d_fence_worker_main’: <vkd3d>/libs/vkd3d/command.c:413:52: warning: pointer targets in passing argument 1 of ‘InterlockedAdd’ differ in signedness [-Wpointer-sign] if (!worker->fence_count || InterlockedAdd(&worker->enqueued_fence_count, 0)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from <vkd3d>/libs/vkd3d/vkd3d_private.h:26, from <vkd3d>/libs/vkd3d/command.c:21: <vkd3d>/include/private/vkd3d_common.h:204:20: note: expected ‘volatile LONG *’ {aka ‘volatile int ’} but argument is of type ‘size_t *’ {aka ‘unsigned int *’} static inline LONG InterlockedAdd(LONG volatile *x, LONG val) ^~~~~~~~~~~~~~

Jan. 28, 2022

[PATCH v3 6/6] msvcp140_atomic_wait: Implement __std_bulk_submit_threadpool_work.

by Piotr Caban

From: Daniel Lehman <dlehman(a)esri.com> Signed-off-by: Daniel Lehman <dlehman(a)esri.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/msvcp140_atomic_wait/main.c | 7 +++++++ .../msvcp140_atomic_wait.spec | 2 +- .../tests/msvcp140_atomic_wait.c | 20 +++++++++++++++++++ 3 files changed, 28 insertions(+), 1 deletion(-)

Jan. 28, 2022

[PATCH v3 5/6] msvcp140_atomic_wait: Implement __std_close_threadpool_work.

by Piotr Caban

From: Daniel Lehman <dlehman(a)esri.com> Signed-off-by: Daniel Lehman <dlehman(a)esri.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/msvcp140_atomic_wait/main.c | 6 ++++++ dlls/msvcp140_atomic_wait/msvcp140_atomic_wait.spec | 2 +- dlls/msvcp140_atomic_wait/tests/msvcp140_atomic_wait.c | 9 ++++++--- 3 files changed, 13 insertions(+), 4 deletions(-)

Jan. 28, 2022

[PATCH v3 4/6] msvcp140_atomic_wait: Implement __std_wait_for_threadpool_work_callbacks.

by Piotr Caban

From: Daniel Lehman <dlehman(a)esri.com> Signed-off-by: Daniel Lehman <dlehman(a)esri.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/msvcp140_atomic_wait/main.c | 6 ++++++ dlls/msvcp140_atomic_wait/msvcp140_atomic_wait.spec | 2 +- dlls/msvcp140_atomic_wait/tests/msvcp140_atomic_wait.c | 7 +++++-- 3 files changed, 12 insertions(+), 3 deletions(-)

Jan. 28, 2022

[PATCH v3 3/6] msvcp140_atomic_wait: Implement __std_submit_threadpool_work.

by Piotr Caban

From: Daniel Lehman <dlehman(a)esri.com> Signed-off-by: Daniel Lehman <dlehman(a)esri.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/msvcp140_atomic_wait/main.c | 6 ++++++ dlls/msvcp140_atomic_wait/msvcp140_atomic_wait.spec | 2 +- dlls/msvcp140_atomic_wait/tests/msvcp140_atomic_wait.c | 7 +++++-- 3 files changed, 12 insertions(+), 3 deletions(-)

Jan. 28, 2022

[PATCH v3 2/6] msvcp140_atomic_wait: Implement __std_create_threadpool_work.

by Piotr Caban

From: Daniel Lehman <dlehman(a)esri.com> Signed-off-by: Daniel Lehman <dlehman(a)esri.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/msvcp140_atomic_wait/main.c | 7 +++++++ .../msvcp140_atomic_wait.spec | 2 +- .../tests/msvcp140_atomic_wait.c | 17 +++++++++++++---- 3 files changed, 21 insertions(+), 5 deletions(-)

Jan. 28, 2022