February 2022 - Wine-Devel - list.winehq.org

Re: [PATCH v2] quartz/tests: Avoid "misleading indentation" warnings.

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=106642 Your paranoid android. === debian11 (build log) === error: patch failed: dlls/quartz/tests/acmwrapper.c:380 error: patch failed: dlls/quartz/tests/filtergraph.c:2474 error: patch failed: dlls/quartz/tests/videorenderer.c:347 Task: Patch failed to apply === debian11 (build log) === error: patch failed: dlls/quartz/tests/acmwrapper.c:380 error: patch failed: dlls/quartz/tests/filtergraph.c:2474 error: patch failed: dlls/quartz/tests/videorenderer.c:347 Task: Patch failed to apply

Feb. 1, 2022

Re: [PATCH 3/3] d3d11: Always initialize out view pointer in CreateDepthStencilView().

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=106639 Your paranoid android. === debian11 (32 bit Japanese:Japan report) === d3d11: d3d11.c:9837: Test failed: d3d11.c:15313: Test marked todo: Got hr 0 for WRITE_DISCARD. === debian11 (64 bit WoW report) === d3d11: d3d11.c:9837: Test failed: d3d11.c:15313: Test marked todo: Got hr 0 for WRITE.

Feb. 1, 2022

Re: [PATCH 1/3] d3d11: Always initialize out view pointer in CreateShaderResourceView().

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=106637 Your paranoid android. === w1064_tsign (32 bit report) === d3d10core: d3d10core.c:4778: Test failed: Got unexpected IAVertices count: 0. d3d10core.c:4779: Test failed: Got unexpected IAPrimitives count: 0. d3d10core.c:4780: Test failed: Got unexpected VSInvocations count: 0. d3d10core.c:4783: Test failed: Got unexpected CInvocations count: 0. d3d10core.c:4784: Test failed: Got unexpected CPrimitives count: 0. === debian11 (32 bit Arabic:Morocco report) === d3d11: d3d11.c:9835: Test failed: d3d11.c:15220: Test marked todo: Got hr 0 for WRITE. === debian11 (32 bit Hebrew:Israel report) === d3d11: d3d11.c:9835: Test failed: d3d11.c:15311: Test marked todo: Got hr 0 for WRITE_DISCARD. === debian11 (32 bit Hindi:India report) === d3d11: d3d11.c:9835: Test failed: d3d11.c:15220: Test marked todo: Got hr 0 for WRITE_DISCARD. === debian11 (32 bit Chinese:China report) === d3d11: d3d11.c:28331: Test failed: Got 0xffffffff, expected 0xff00ff00 at (639, 479, 0), sub-resource 0.

Feb. 1, 2022

Re: [PATCH 14/14] dlls/ntdll: use correct integral type

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=106625 Your paranoid android. === debian11 (build log) === error: patch failed: dlls/compobj.dll16/compobj.c:657 error: patch failed: dlls/crypt32/sip.c:40 error: patch failed: dlls/iphlpapi/iphlpapi_main.c:59 error: patch failed: dlls/iphlpapi/tests/iphlpapi.c:1409 error: patch failed: dlls/msdmo/tests/msdmo.c:31 error: patch failed: dlls/mshtml/main.c:627 error: patch failed: dlls/oleaut32/oleaut.c:832 error: patch failed: dlls/oleaut32/typelib.c:3660 error: patch failed: dlls/rpcrt4/rpcrt4_main.c:543 error: patch failed: dlls/shell32/classes.c:200 error: patch failed: dlls/shell32/debughlp.c:247 error: patch failed: dlls/shell32/shfldr.h:61 error: patch failed: dlls/shlwapi/ordinal.c:461 error: patch failed: dlls/typelib.dll16/typelib.c:82 error: patch failed: dlls/webservices/writer.c:1041 error: patch failed: include/msvcrt/corecrt.h:334 error: patch failed: include/msvcrt/crtdbg.h:88 error: patch failed: include/msvcrt/stdio.h:161 error: patch failed: programs/winetest/main.c:865 error: patch failed: include/basetsd.h:153 error: patch failed: programs/winedbg/debugger.h:39 error: patch failed: dlls/dbgeng/dbgeng.c:81 error: patch failed: dlls/dsound/mixer.c:694 error: patch failed: dlls/evr/mixer.c:906 error: patch failed: dlls/evr/presenter.c:282 error: patch failed: dlls/gdiplus/image.c:4114 error: patch failed: dlls/itss/chm_lib.c:941 error: patch failed: dlls/joy.cpl/main.c:789 error: patch failed: dlls/ntdll/actctx.c:532 error: patch failed: dlls/ntdll/loader.c:250 error: patch failed: dlls/ntdll/sync.c:182 Task: Patch failed to apply === debian11 (build log) === error: patch failed: dlls/compobj.dll16/compobj.c:657 error: patch failed: dlls/crypt32/sip.c:40 error: patch failed: dlls/iphlpapi/iphlpapi_main.c:59 error: patch failed: dlls/iphlpapi/tests/iphlpapi.c:1409 error: patch failed: dlls/msdmo/tests/msdmo.c:31 error: patch failed: dlls/mshtml/main.c:627 error: patch failed: dlls/oleaut32/oleaut.c:832 error: patch failed: dlls/oleaut32/typelib.c:3660 error: patch failed: dlls/rpcrt4/rpcrt4_main.c:543 error: patch failed: dlls/shell32/classes.c:200 error: patch failed: dlls/shell32/debughlp.c:247 error: patch failed: dlls/shell32/shfldr.h:61 error: patch failed: dlls/shlwapi/ordinal.c:461 error: patch failed: dlls/typelib.dll16/typelib.c:82 error: patch failed: dlls/webservices/writer.c:1041 error: patch failed: include/msvcrt/corecrt.h:334 error: patch failed: include/msvcrt/crtdbg.h:88 error: patch failed: include/msvcrt/stdio.h:161 error: patch failed: programs/winetest/main.c:865 error: patch failed: include/basetsd.h:153 error: patch failed: programs/winedbg/debugger.h:39 error: patch failed: dlls/dbgeng/dbgeng.c:81 error: patch failed: dlls/dsound/mixer.c:694 error: patch failed: dlls/evr/mixer.c:906 error: patch failed: dlls/evr/presenter.c:282 error: patch failed: dlls/gdiplus/image.c:4114 error: patch failed: dlls/itss/chm_lib.c:941 error: patch failed: dlls/joy.cpl/main.c:789 error: patch failed: dlls/ntdll/actctx.c:532 error: patch failed: dlls/ntdll/loader.c:250 error: patch failed: dlls/ntdll/sync.c:182 Task: Patch failed to apply

Feb. 1, 2022

Re: [PATCH 13/14] dlls/msxml3: use correct integral type

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=106624 Your paranoid android. === debian11 (build log) === error: patch failed: dlls/compobj.dll16/compobj.c:657 error: patch failed: dlls/crypt32/sip.c:40 error: patch failed: dlls/iphlpapi/iphlpapi_main.c:59 error: patch failed: dlls/iphlpapi/tests/iphlpapi.c:1409 error: patch failed: dlls/msdmo/tests/msdmo.c:31 error: patch failed: dlls/mshtml/main.c:627 error: patch failed: dlls/oleaut32/oleaut.c:832 error: patch failed: dlls/oleaut32/typelib.c:3660 error: patch failed: dlls/rpcrt4/rpcrt4_main.c:543 error: patch failed: dlls/shell32/classes.c:200 error: patch failed: dlls/shell32/debughlp.c:247 error: patch failed: dlls/shell32/shfldr.h:61 error: patch failed: dlls/shlwapi/ordinal.c:461 error: patch failed: dlls/typelib.dll16/typelib.c:82 error: patch failed: dlls/webservices/writer.c:1041 error: patch failed: include/msvcrt/corecrt.h:334 error: patch failed: include/msvcrt/crtdbg.h:88 error: patch failed: include/msvcrt/stdio.h:161 error: patch failed: programs/winetest/main.c:865 error: patch failed: include/basetsd.h:153 error: patch failed: programs/winedbg/debugger.h:39 error: patch failed: dlls/dbgeng/dbgeng.c:81 error: patch failed: dlls/dsound/mixer.c:694 error: patch failed: dlls/evr/mixer.c:906 error: patch failed: dlls/evr/presenter.c:282 error: patch failed: dlls/gdiplus/image.c:4114 error: patch failed: dlls/itss/chm_lib.c:941 error: patch failed: dlls/joy.cpl/main.c:789 Task: Patch failed to apply === debian11 (build log) === error: patch failed: dlls/compobj.dll16/compobj.c:657 error: patch failed: dlls/crypt32/sip.c:40 error: patch failed: dlls/iphlpapi/iphlpapi_main.c:59 error: patch failed: dlls/iphlpapi/tests/iphlpapi.c:1409 error: patch failed: dlls/msdmo/tests/msdmo.c:31 error: patch failed: dlls/mshtml/main.c:627 error: patch failed: dlls/oleaut32/oleaut.c:832 error: patch failed: dlls/oleaut32/typelib.c:3660 error: patch failed: dlls/rpcrt4/rpcrt4_main.c:543 error: patch failed: dlls/shell32/classes.c:200 error: patch failed: dlls/shell32/debughlp.c:247 error: patch failed: dlls/shell32/shfldr.h:61 error: patch failed: dlls/shlwapi/ordinal.c:461 error: patch failed: dlls/typelib.dll16/typelib.c:82 error: patch failed: dlls/webservices/writer.c:1041 error: patch failed: include/msvcrt/corecrt.h:334 error: patch failed: include/msvcrt/crtdbg.h:88 error: patch failed: include/msvcrt/stdio.h:161 error: patch failed: programs/winetest/main.c:865 error: patch failed: include/basetsd.h:153 error: patch failed: programs/winedbg/debugger.h:39 error: patch failed: dlls/dbgeng/dbgeng.c:81 error: patch failed: dlls/dsound/mixer.c:694 error: patch failed: dlls/evr/mixer.c:906 error: patch failed: dlls/evr/presenter.c:282 error: patch failed: dlls/gdiplus/image.c:4114 error: patch failed: dlls/itss/chm_lib.c:941 error: patch failed: dlls/joy.cpl/main.c:789 Task: Patch failed to apply

Feb. 1, 2022

Re: [PATCH 12/14] dlls/joy.cpl: use correct integral type

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=106623 Your paranoid android. === debian11 (build log) === error: patch failed: dlls/compobj.dll16/compobj.c:657 error: patch failed: dlls/crypt32/sip.c:40 error: patch failed: dlls/iphlpapi/iphlpapi_main.c:59 error: patch failed: dlls/iphlpapi/tests/iphlpapi.c:1409 error: patch failed: dlls/msdmo/tests/msdmo.c:31 error: patch failed: dlls/mshtml/main.c:627 error: patch failed: dlls/oleaut32/oleaut.c:832 error: patch failed: dlls/oleaut32/typelib.c:3660 error: patch failed: dlls/rpcrt4/rpcrt4_main.c:543 error: patch failed: dlls/shell32/classes.c:200 error: patch failed: dlls/shell32/debughlp.c:247 error: patch failed: dlls/shell32/shfldr.h:61 error: patch failed: dlls/shlwapi/ordinal.c:461 error: patch failed: dlls/typelib.dll16/typelib.c:82 error: patch failed: dlls/webservices/writer.c:1041 error: patch failed: include/msvcrt/corecrt.h:334 error: patch failed: include/msvcrt/crtdbg.h:88 error: patch failed: include/msvcrt/stdio.h:161 error: patch failed: programs/winetest/main.c:865 error: patch failed: include/basetsd.h:153 error: patch failed: programs/winedbg/debugger.h:39 error: patch failed: dlls/dbgeng/dbgeng.c:81 error: patch failed: dlls/dsound/mixer.c:694 error: patch failed: dlls/evr/mixer.c:906 error: patch failed: dlls/evr/presenter.c:282 error: patch failed: dlls/gdiplus/image.c:4114 error: patch failed: dlls/itss/chm_lib.c:941 error: patch failed: dlls/joy.cpl/main.c:789 Task: Patch failed to apply === debian11 (build log) === error: patch failed: dlls/compobj.dll16/compobj.c:657 error: patch failed: dlls/crypt32/sip.c:40 error: patch failed: dlls/iphlpapi/iphlpapi_main.c:59 error: patch failed: dlls/iphlpapi/tests/iphlpapi.c:1409 error: patch failed: dlls/msdmo/tests/msdmo.c:31 error: patch failed: dlls/mshtml/main.c:627 error: patch failed: dlls/oleaut32/oleaut.c:832 error: patch failed: dlls/oleaut32/typelib.c:3660 error: patch failed: dlls/rpcrt4/rpcrt4_main.c:543 error: patch failed: dlls/shell32/classes.c:200 error: patch failed: dlls/shell32/debughlp.c:247 error: patch failed: dlls/shell32/shfldr.h:61 error: patch failed: dlls/shlwapi/ordinal.c:461 error: patch failed: dlls/typelib.dll16/typelib.c:82 error: patch failed: dlls/webservices/writer.c:1041 error: patch failed: include/msvcrt/corecrt.h:334 error: patch failed: include/msvcrt/crtdbg.h:88 error: patch failed: include/msvcrt/stdio.h:161 error: patch failed: programs/winetest/main.c:865 error: patch failed: include/basetsd.h:153 error: patch failed: programs/winedbg/debugger.h:39 error: patch failed: dlls/dbgeng/dbgeng.c:81 error: patch failed: dlls/dsound/mixer.c:694 error: patch failed: dlls/evr/mixer.c:906 error: patch failed: dlls/evr/presenter.c:282 error: patch failed: dlls/gdiplus/image.c:4114 error: patch failed: dlls/itss/chm_lib.c:941 error: patch failed: dlls/joy.cpl/main.c:789 Task: Patch failed to apply

Feb. 1, 2022

Re: [PATCH 11/14] dlls/itss: use correct integral type

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=106622 Your paranoid android. === debian11 (build log) === error: patch failed: dlls/compobj.dll16/compobj.c:657 error: patch failed: dlls/crypt32/sip.c:40 error: patch failed: dlls/iphlpapi/iphlpapi_main.c:59 error: patch failed: dlls/iphlpapi/tests/iphlpapi.c:1409 error: patch failed: dlls/msdmo/tests/msdmo.c:31 error: patch failed: dlls/mshtml/main.c:627 error: patch failed: dlls/oleaut32/oleaut.c:832 error: patch failed: dlls/oleaut32/typelib.c:3660 error: patch failed: dlls/rpcrt4/rpcrt4_main.c:543 error: patch failed: dlls/shell32/classes.c:200 error: patch failed: dlls/shell32/debughlp.c:247 error: patch failed: dlls/shell32/shfldr.h:61 error: patch failed: dlls/shlwapi/ordinal.c:461 error: patch failed: dlls/typelib.dll16/typelib.c:82 error: patch failed: dlls/webservices/writer.c:1041 error: patch failed: include/msvcrt/corecrt.h:334 error: patch failed: include/msvcrt/crtdbg.h:88 error: patch failed: include/msvcrt/stdio.h:161 error: patch failed: programs/winetest/main.c:865 error: patch failed: include/basetsd.h:153 error: patch failed: programs/winedbg/debugger.h:39 error: patch failed: dlls/dbgeng/dbgeng.c:81 error: patch failed: dlls/dsound/mixer.c:694 error: patch failed: dlls/evr/mixer.c:906 error: patch failed: dlls/evr/presenter.c:282 error: patch failed: dlls/gdiplus/image.c:4114 error: patch failed: dlls/itss/chm_lib.c:941 Task: Patch failed to apply === debian11 (build log) === error: patch failed: dlls/compobj.dll16/compobj.c:657 error: patch failed: dlls/crypt32/sip.c:40 error: patch failed: dlls/iphlpapi/iphlpapi_main.c:59 error: patch failed: dlls/iphlpapi/tests/iphlpapi.c:1409 error: patch failed: dlls/msdmo/tests/msdmo.c:31 error: patch failed: dlls/mshtml/main.c:627 error: patch failed: dlls/oleaut32/oleaut.c:832 error: patch failed: dlls/oleaut32/typelib.c:3660 error: patch failed: dlls/rpcrt4/rpcrt4_main.c:543 error: patch failed: dlls/shell32/classes.c:200 error: patch failed: dlls/shell32/debughlp.c:247 error: patch failed: dlls/shell32/shfldr.h:61 error: patch failed: dlls/shlwapi/ordinal.c:461 error: patch failed: dlls/typelib.dll16/typelib.c:82 error: patch failed: dlls/webservices/writer.c:1041 error: patch failed: include/msvcrt/corecrt.h:334 error: patch failed: include/msvcrt/crtdbg.h:88 error: patch failed: include/msvcrt/stdio.h:161 error: patch failed: programs/winetest/main.c:865 error: patch failed: include/basetsd.h:153 error: patch failed: programs/winedbg/debugger.h:39 error: patch failed: dlls/dbgeng/dbgeng.c:81 error: patch failed: dlls/dsound/mixer.c:694 error: patch failed: dlls/evr/mixer.c:906 error: patch failed: dlls/evr/presenter.c:282 error: patch failed: dlls/gdiplus/image.c:4114 error: patch failed: dlls/itss/chm_lib.c:941 Task: Patch failed to apply

Feb. 1, 2022

Re: [PATCH 10/14] dlls/gdiplus: use correct integral type

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=106621 Your paranoid android. === debian11 (build log) === error: patch failed: dlls/compobj.dll16/compobj.c:657 error: patch failed: dlls/crypt32/sip.c:40 error: patch failed: dlls/iphlpapi/iphlpapi_main.c:59 error: patch failed: dlls/iphlpapi/tests/iphlpapi.c:1409 error: patch failed: dlls/msdmo/tests/msdmo.c:31 error: patch failed: dlls/mshtml/main.c:627 error: patch failed: dlls/oleaut32/oleaut.c:832 error: patch failed: dlls/oleaut32/typelib.c:3660 error: patch failed: dlls/rpcrt4/rpcrt4_main.c:543 error: patch failed: dlls/shell32/classes.c:200 error: patch failed: dlls/shell32/debughlp.c:247 error: patch failed: dlls/shell32/shfldr.h:61 error: patch failed: dlls/shlwapi/ordinal.c:461 error: patch failed: dlls/typelib.dll16/typelib.c:82 error: patch failed: dlls/webservices/writer.c:1041 error: patch failed: include/msvcrt/corecrt.h:334 error: patch failed: include/msvcrt/crtdbg.h:88 error: patch failed: include/msvcrt/stdio.h:161 error: patch failed: programs/winetest/main.c:865 error: patch failed: include/basetsd.h:153 error: patch failed: programs/winedbg/debugger.h:39 error: patch failed: dlls/dbgeng/dbgeng.c:81 error: patch failed: dlls/dsound/mixer.c:694 error: patch failed: dlls/evr/mixer.c:906 error: patch failed: dlls/evr/presenter.c:282 error: patch failed: dlls/gdiplus/image.c:4114 Task: Patch failed to apply === debian11 (build log) === error: patch failed: dlls/compobj.dll16/compobj.c:657 error: patch failed: dlls/crypt32/sip.c:40 error: patch failed: dlls/iphlpapi/iphlpapi_main.c:59 error: patch failed: dlls/iphlpapi/tests/iphlpapi.c:1409 error: patch failed: dlls/msdmo/tests/msdmo.c:31 error: patch failed: dlls/mshtml/main.c:627 error: patch failed: dlls/oleaut32/oleaut.c:832 error: patch failed: dlls/oleaut32/typelib.c:3660 error: patch failed: dlls/rpcrt4/rpcrt4_main.c:543 error: patch failed: dlls/shell32/classes.c:200 error: patch failed: dlls/shell32/debughlp.c:247 error: patch failed: dlls/shell32/shfldr.h:61 error: patch failed: dlls/shlwapi/ordinal.c:461 error: patch failed: dlls/typelib.dll16/typelib.c:82 error: patch failed: dlls/webservices/writer.c:1041 error: patch failed: include/msvcrt/corecrt.h:334 error: patch failed: include/msvcrt/crtdbg.h:88 error: patch failed: include/msvcrt/stdio.h:161 error: patch failed: programs/winetest/main.c:865 error: patch failed: include/basetsd.h:153 error: patch failed: programs/winedbg/debugger.h:39 error: patch failed: dlls/dbgeng/dbgeng.c:81 error: patch failed: dlls/dsound/mixer.c:694 error: patch failed: dlls/evr/mixer.c:906 error: patch failed: dlls/evr/presenter.c:282 error: patch failed: dlls/gdiplus/image.c:4114 Task: Patch failed to apply

Feb. 1, 2022

Re: [PATCH v4 1/4] wdscore: Implement CurrentIP.

by Mohamad Al-Jaf

Hi, > I share your sentiment, but in this case it is impossible to know, > unless we can find it documented somewhere. From a binary signature > standpoint, a function with 0 args is identical in STDCALL and CDECL, > because it's not mangled in the DLL either (unlike lib), and the only > source we have is that header that uses it. > > So it doesn't really matter, just that the mismatch looked wrong (either > both STDCALL or both CDECL is fine in my eyes, but not an authoritative > opinion). Oh, I see, perhaps I shouldn't have changed it. I'm not sure if I did the right thing here, especially since it's undocumented. Giovanni had already signed off on the WINAPI version of this but I saw that it didn't get committed so I thought maybe Alexandre saw something wrong that neither one of us saw. Maybe I was being too impatient, but I wanted to also submit the stubs and those depend on this patch. I made a decision I thought was right based on my understanding of cdecl and stdcall, but I'm still inexperienced in Wine development. I apologize if I came off as disrespectful towards Giovanni.

Feb. 1, 2022