March 2022 - Wine-Devel - list.winehq.org

Re: [PATCH v3] combase: Add RoSetErrorReportingFlags stub

by Mohamad Al-Jaf

Hi Alistair, Shouldn't this include the flags? I added _RO_ERROR_REPORTING_FLAGS for copyright reasons. typedef enum _RO_ERROR_REPORTING_FLAGS { RO_ERROR_REPORTING_NONE = 0x00000000, RO_ERROR_REPORTING_SUPPRESSEXCEPTIONS = 0x00000001, RO_ERROR_REPORTING_FORCEEXCEPTIONS = 0x00000002, RO_ERROR_REPORTING_USESETERRORINFO = 0x00000004, RO_ERROR_REPORTING_SUPPRESSSETERRORINFO = 0x00000008, } RO_ERROR_REPORTING_FLAGS; cpp_quote("DEFINE_ENUM_FLAG_OPERATORS(RO_ERROR_REPORTING_FLAGS);") The semicolon at the end of the above line might not be needed. In the roerrorapi.h file there are 2 (+1 duplicate) enums for the error flags, one of which is enclosed in namespaces. I think Huw meant you should add the enum preceding the namespace. -- Kind regards, Mohamad

March 1, 2022

[v2 PATCH] ntdll: Check __WINE_PE_BUILD instead of compiler macros.

by Saulius Krasuckas

Fixes compilation on Cygwin, undeclared identifiers: _alldiv, _allmul, _allrem, _aulldiv, _aullrem. --- v2: Fix $Subject and line wrapping. dlls/ntdll/large_int.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

March 1, 2022

Re: ntdll: Check __WINE_PE_BUILD instead of compiler macros.

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=109473 Your paranoid android. === debian11 (build log) === error: corrupt patch at line 18 Task: Patch failed to apply === debian11 (build log) === error: corrupt patch at line 18 Task: Patch failed to apply

March 1, 2022