April 2022 - Wine-Devel - list.winehq.org

Re: [PATCH 2/6] win32u: Move NtUserWaitForInputIdle implementation from user32.

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=111727 Your paranoid android. === debian11 (32 bit report) === user32: input.c:2162: Test failed: Unexpected rawinput data: 1 input.c:2182: Test failed: Unexpected rawinput data: -1 input.c:2164: Test failed: Unexpected rawinput data: -8 input.c:1628: Test failed: wrong position 25, expected 41x82 got 52x104 input.c:1695: Test failed: expected to get 64 mouse move points but got 63 === debian11 (32 bit Chinese:China report) === user32: input.c:2182: Test failed: Unexpected rawinput data: 3 input.c:1628: Test failed: wrong position 2, expected 64x128 got 63x126 input.c:1628: Test failed: wrong position 4, expected 62x124 got 65x130 input.c:1628: Test failed: wrong position 6, expected 60x120 got 61x122 input.c:1628: Test failed: wrong position 8, expected 58x116 got 63x126 input.c:1628: Test failed: wrong position 22, expected 44x88 got 56x112 input.c:1628: Test failed: wrong position 30, expected 36x72 got 52x104 input.c:1628: Test failed: wrong position 31, expected 35x70 got 48x96 input.c:1628: Test failed: wrong position 32, expected 34x68 got 51x102 input.c:1628: Test failed: wrong position 42, expected 24x48 got 43x86 input.c:1628: Test failed: wrong position 44, expected 22x44 got 42x84 input.c:1628: Test failed: wrong position 46, expected 20x40 got 41x82 input.c:1628: Test failed: wrong position 52, expected 14x28 got 41x82 input.c:1628: Test failed: wrong position 58, expected 8x16 got 35x70 input.c:1628: Test failed: wrong position 60, expected 6x12 got 34x68 input.c:1628: Test failed: wrong position 61, expected 5x10 got 36x72 input.c:1628: Test failed: wrong position 62, expected 4x8 got 33x66 win.c:11606: Test failed: 1: hwnd 0029009C is still topmost win.c:11606: Test failed: 2: hwnd 006E00A0 is still topmost win.c:11606: Test failed: 1: hwnd 0029009C is still topmost win.c:11606: Test failed: 2: hwnd 006E00A0 is still topmost win.c:11606: Test failed: 1: hwnd 0029009C is still topmost win.c:11606: Test failed: 2: hwnd 006E00A0 is still topmost win.c:11763: Test failed: 010E00F2: expected NOT topmost win.c:11787: Test failed: 010E00F2: expected NOT topmost win.c:11606: Test failed: 1: hwnd 0029009C is still topmost win.c:11606: Test failed: 2: hwnd 006E00A0 is still topmost win.c:11606: Test failed: 3: hwnd 00070144 is still topmost win.c:11606: Test failed: 4: hwnd 010E00F2 is still topmost win.c:11810: Test failed: 0029009C: expected NOT topmost win.c:11811: Test failed: 010E00F2: expected next 00070144, got 00000000 win.c:11811: Test failed: 010E00F2: expected NOT topmost win.c:11606: Test failed: 1: hwnd 0029009C is still topmost win.c:11606: Test failed: 2: hwnd 006E00A0 is still topmost win.c:11606: Test failed: 3: hwnd 00070144 is still topmost win.c:11606: Test failed: 4: hwnd 010E00F2 is still topmost win.c:11834: Test failed: 0029009C: expected NOT topmost win.c:11835: Test failed: 010E00F2: expected next 00070144, got 00000000 win.c:11835: Test failed: 010E00F2: expected NOT topmost win.c:11606: Test failed: 1: hwnd 0029009C is still topmost win.c:11606: Test failed: 2: hwnd 006E00A0 is still topmost win.c:11606: Test failed: 3: hwnd 00070144 is still topmost win.c:11606: Test failed: 4: hwnd 010E00F2 is still topmost win.c:11869: Test failed: 010E00F2: expected next 00070144, got 00000000 win.c:11869: Test failed: 010E00F2: expected NOT topmost win.c:11606: Test failed: 1: hwnd 0029009C is still topmost win.c:11606: Test failed: 2: hwnd 006E00A0 is still topmost win.c:11606: Test failed: 3: hwnd 00070144 is still topmost win.c:11606: Test failed: 4: hwnd 010E00F2 is still topmost win.c:11892: Test failed: 010E00F2: expected NOT topmost win.c:11606: Test failed: 1: hwnd 0029009C is still topmost win.c:11606: Test failed: 2: hwnd 006E00A0 is still topmost win.c:11606: Test failed: 3: hwnd 00070144 is still topmost win.c:11606: Test failed: 4: hwnd 010E00F2 is still topmost win.c:11903: Test failed: 010E00F2: expected next 00070144, got 00000000 win.c:11903: Test failed: 010E00F2: expected NOT topmost win.c:11606: Test failed: 1: hwnd 0029009C is still topmost win.c:11606: Test failed: 2: hwnd 006E00A0 is still topmost win.c:11606: Test failed: 3: hwnd 00070144 is still topmost win.c:11606: Test failed: 4: hwnd 010E00F2 is still topmost win.c:11606: Test failed: 1: hwnd 0029009C is still topmost win.c:11606: Test failed: 2: hwnd 006E00A0 is still topmost win.c:11606: Test failed: 3: hwnd 00070144 is still topmost win.c:11606: Test failed: 4: hwnd 010E00F2 is still topmost win.c:11606: Test failed: 1: hwnd 0029009C is still topmost win.c:11606: Test failed: 2: hwnd 006E00A0 is still topmost win.c:11606: Test failed: 3: hwnd 00070144 is still topmost win.c:11606: Test failed: 4: hwnd 010E00F2 is still topmost === debian11 (32 bit WoW report) === user32: input.c:2163: Test failed: Unexpected rawinput data: 5 input.c:1628: Test failed: wrong position 13, expected 53x106 got 59x118 input.c:1628: Test failed: wrong position 16, expected 50x100 got 58x116 input.c:1628: Test failed: wrong position 17, expected 49x98 got 55x110 input.c:1628: Test failed: wrong position 20, expected 46x92 got 53x106 input.c:1628: Test failed: wrong position 26, expected 40x80 got 51x102 input.c:1628: Test failed: wrong position 27, expected 39x78 got 50x100 input.c:1628: Test failed: wrong position 29, expected 37x74 got 49x98 input.c:1628: Test failed: wrong position 30, expected 36x72 got 48x96 input.c:1628: Test failed: wrong position 34, expected 32x64 got 50x100 input.c:1628: Test failed: wrong position 35, expected 31x62 got 45x90 input.c:1628: Test failed: wrong position 38, expected 28x56 got 47x94 input.c:1628: Test failed: wrong position 39, expected 27x54 got 46x92 input.c:1628: Test failed: wrong position 40, expected 26x52 got 44x88 input.c:1628: Test failed: wrong position 41, expected 25x50 got 43x86 input.c:1628: Test failed: wrong position 42, expected 24x48 got 45x90 input.c:1628: Test failed: wrong position 43, expected 23x46 got 42x84 input.c:1628: Test failed: wrong position 44, expected 22x44 got 41x82 input.c:1628: Test failed: wrong position 49, expected 17x34 got 39x78 input.c:1628: Test failed: wrong position 51, expected 15x30 got 41x82 input.c:1628: Test failed: wrong position 57, expected 9x18 got 37x74 input.c:1628: Test failed: wrong position 58, expected 8x16 got 35x70 input.c:1628: Test failed: wrong position 62, expected 4x8 got 35x70 win.c:11361: Test failed: expected 01A00136, got 0103008A === debian11 (64 bit WoW report) === user32: win.c:11361: Test failed: expected 0000000001FD0160, got 0000000000500090 win.c:11606: Test failed: 1: hwnd 0000000000160166 is still topmost win.c:11606: Test failed: 2: hwnd 0000000000290074 is still topmost win.c:11606: Test failed: 1: hwnd 0000000000160166 is still topmost win.c:11606: Test failed: 2: hwnd 0000000000290074 is still topmost win.c:11606: Test failed: 1: hwnd 0000000000160166 is still topmost win.c:11606: Test failed: 2: hwnd 0000000000290074 is still topmost win.c:11763: Test failed: 00000000007900E2: expected NOT topmost win.c:11787: Test failed: 00000000007900E2: expected NOT topmost win.c:11606: Test failed: 1: hwnd 0000000000160166 is still topmost win.c:11606: Test failed: 2: hwnd 0000000000290074 is still topmost win.c:11606: Test failed: 3: hwnd 0000000000070148 is still topmost win.c:11606: Test failed: 4: hwnd 00000000007900E2 is still topmost win.c:11810: Test failed: 0000000000160166: expected NOT topmost win.c:11811: Test failed: 00000000007900E2: expected next 0000000000070148, got 0000000000000000 win.c:11811: Test failed: 00000000007900E2: expected NOT topmost win.c:11606: Test failed: 1: hwnd 0000000000160166 is still topmost win.c:11606: Test failed: 2: hwnd 0000000000290074 is still topmost win.c:11606: Test failed: 3: hwnd 0000000000070148 is still topmost win.c:11606: Test failed: 4: hwnd 00000000007900E2 is still topmost win.c:11834: Test failed: 0000000000160166: expected NOT topmost win.c:11835: Test failed: 00000000007900E2: expected next 0000000000070148, got 0000000000000000 win.c:11835: Test failed: 00000000007900E2: expected NOT topmost win.c:11606: Test failed: 1: hwnd 0000000000160166 is still topmost win.c:11606: Test failed: 2: hwnd 0000000000290074 is still topmost win.c:11606: Test failed: 3: hwnd 0000000000070148 is still topmost win.c:11606: Test failed: 4: hwnd 00000000007900E2 is still topmost win.c:11869: Test failed: 00000000007900E2: expected next 0000000000070148, got 0000000000000000 win.c:11869: Test failed: 00000000007900E2: expected NOT topmost win.c:11606: Test failed: 1: hwnd 0000000000160166 is still topmost win.c:11606: Test failed: 2: hwnd 0000000000290074 is still topmost win.c:11606: Test failed: 3: hwnd 0000000000070148 is still topmost win.c:11606: Test failed: 4: hwnd 00000000007900E2 is still topmost win.c:11892: Test failed: 00000000007900E2: expected NOT topmost win.c:11606: Test failed: 1: hwnd 0000000000160166 is still topmost win.c:11606: Test failed: 2: hwnd 0000000000290074 is still topmost win.c:11606: Test failed: 3: hwnd 0000000000070148 is still topmost win.c:11606: Test failed: 4: hwnd 00000000007900E2 is still topmost win.c:11903: Test failed: 00000000007900E2: expected next 0000000000070148, got 0000000000000000 win.c:11903: Test failed: 00000000007900E2: expected NOT topmost win.c:11606: Test failed: 1: hwnd 0000000000160166 is still topmost win.c:11606: Test failed: 2: hwnd 0000000000290074 is still topmost win.c:11606: Test failed: 3: hwnd 0000000000070148 is still topmost win.c:11606: Test failed: 4: hwnd 00000000007900E2 is still topmost win.c:11606: Test failed: 1: hwnd 0000000000160166 is still topmost win.c:11606: Test failed: 2: hwnd 0000000000290074 is still topmost win.c:11606: Test failed: 3: hwnd 0000000000070148 is still topmost win.c:11606: Test failed: 4: hwnd 00000000007900E2 is still topmost win.c:11606: Test failed: 1: hwnd 0000000000160166 is still topmost win.c:11606: Test failed: 2: hwnd 0000000000290074 is still topmost win.c:11606: Test failed: 3: hwnd 0000000000070148 is still topmost win.c:11606: Test failed: 4: hwnd 00000000007900E2 is still topmost

April 1, 2022

Re: [PATCH 1/6] win32u: Move NtUserMsgWaitForMultipleObjectsEx implementation from user32.

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=111726 Your paranoid android. === debian11 (32 bit report) === user32: input.c:1628: Test failed: wrong position 5, expected 61x122 got 63x126 input.c:1628: Test failed: wrong position 6, expected 60x120 got 61x122 input.c:1628: Test failed: wrong position 23, expected 43x86 got 55x110 input.c:1628: Test failed: wrong position 26, expected 40x80 got 54x108 input.c:1628: Test failed: wrong position 33, expected 33x66 got 50x100 input.c:1628: Test failed: wrong position 41, expected 25x50 got 43x86 input.c:1628: Test failed: wrong position 47, expected 19x38 got 40x80 input.c:1628: Test failed: wrong position 49, expected 17x34 got 39x78 input.c:1628: Test failed: wrong position 52, expected 14x28 got 37x74 input.c:1628: Test failed: wrong position 55, expected 11x22 got 36x72 input.c:1628: Test failed: wrong position 58, expected 8x16 got 34x68 input.c:1628: Test failed: wrong position 59, expected 7x14 got 33x66 input.c:1628: Test failed: wrong position 60, expected 6x12 got 32x64 input.c:1628: Test failed: wrong position 62, expected 4x8 got 30x60 input.c:1628: Test failed: wrong position 63, expected 3x6 got 37x74 win.c:11361: Test failed: expected 01BC00B0, got 005D00B2 === debian11 (32 bit Chinese:China report) === user32: input.c:2160: Test failed: GetRawInputBuffer returned 7 input.c:1628: Test failed: wrong position 42, expected 24x48 got 43x86 input.c:1628: Test failed: wrong position 44, expected 22x44 got 42x84 input.c:1628: Test failed: wrong position 46, expected 20x40 got 44x88 input.c:1628: Test failed: wrong position 49, expected 17x34 got 43x86 input.c:1628: Test failed: wrong position 50, expected 16x32 got 42x84 input.c:1628: Test failed: wrong position 58, expected 8x16 got 35x70 input.c:1628: Test failed: wrong position 60, expected 6x12 got 34x68 input.c:1628: Test failed: wrong position 62, expected 4x8 got 36x72 === debian11 (32 bit WoW report) === user32: input.c:2160: Test failed: GetRawInputBuffer returned 6 input.c:2162: Test failed: Unexpected rawinput data: 4 input.c:2182: Test failed: Unexpected rawinput data: 3 input.c:2162: Test failed: Unexpected rawinput data: -10 input.c:2160: Test failed: GetRawInputBuffer returned 1 input.c:1628: Test failed: wrong position 5, expected 61x122 got 62x124 input.c:1628: Test failed: wrong position 7, expected 59x118 got 61x122 input.c:1628: Test failed: wrong position 9, expected 57x114 got 60x120 input.c:1628: Test failed: wrong position 11, expected 55x110 got 59x118 input.c:1628: Test failed: wrong position 13, expected 53x106 got 58x116 input.c:1628: Test failed: wrong position 15, expected 51x102 got 57x114 input.c:1628: Test failed: wrong position 16, expected 50x100 got 58x116 input.c:1628: Test failed: wrong position 17, expected 49x98 got 56x112 input.c:1628: Test failed: wrong position 21, expected 45x90 got 54x108 input.c:1628: Test failed: wrong position 23, expected 43x86 got 53x106 input.c:1628: Test failed: wrong position 25, expected 41x82 got 52x104 input.c:1628: Test failed: wrong position 29, expected 37x74 got 50x100 input.c:1628: Test failed: wrong position 30, expected 36x72 got 51x102 input.c:1628: Test failed: wrong position 31, expected 35x70 got 49x98 input.c:1628: Test failed: wrong position 33, expected 33x66 got 48x96 input.c:1628: Test failed: wrong position 35, expected 31x62 got 47x94 input.c:1628: Test failed: wrong position 36, expected 30x60 got 48x96 input.c:1628: Test failed: wrong position 37, expected 29x58 got 46x92 input.c:1628: Test failed: wrong position 38, expected 28x56 got 47x94 input.c:1628: Test failed: wrong position 39, expected 27x54 got 45x90 input.c:1628: Test failed: wrong position 42, expected 24x48 got 45x90 input.c:1628: Test failed: wrong position 43, expected 23x46 got 43x86 input.c:1628: Test failed: wrong position 44, expected 22x44 got 44x88 input.c:1628: Test failed: wrong position 45, expected 21x42 got 42x84 input.c:1628: Test failed: wrong position 47, expected 19x38 got 41x82 input.c:1628: Test failed: wrong position 48, expected 18x36 got 42x84 input.c:1628: Test failed: wrong position 49, expected 17x34 got 40x80 input.c:1628: Test failed: wrong position 51, expected 15x30 got 39x78 input.c:1628: Test failed: wrong position 53, expected 13x26 got 38x76 input.c:1628: Test failed: wrong position 55, expected 11x22 got 37x74 input.c:1628: Test failed: wrong position 61, expected 5x10 got 34x68 input.c:1628: Test failed: wrong position 62, expected 4x8 got 35x70 win.c:11361: Test failed: expected 00DB00EA, got 0026009E === debian11 (64 bit WoW report) === user32: win.c:11361: Test failed: expected 0000000000BF010C, got 000000000047006C win.c:11606: Test failed: 1: hwnd 00000000002600A8 is still topmost win.c:11606: Test failed: 2: hwnd 00000000002700C4 is still topmost win.c:11606: Test failed: 1: hwnd 00000000002600A8 is still topmost win.c:11606: Test failed: 2: hwnd 00000000002700C4 is still topmost win.c:11606: Test failed: 1: hwnd 00000000002600A8 is still topmost win.c:11606: Test failed: 2: hwnd 00000000002700C4 is still topmost win.c:11763: Test failed: 00000000021000E6: expected NOT topmost win.c:11787: Test failed: 00000000021000E6: expected NOT topmost win.c:11606: Test failed: 1: hwnd 00000000002600A8 is still topmost win.c:11606: Test failed: 2: hwnd 00000000002700C4 is still topmost win.c:11606: Test failed: 3: hwnd 0000000000070148 is still topmost win.c:11606: Test failed: 4: hwnd 00000000021000E6 is still topmost win.c:11810: Test failed: 00000000002600A8: expected NOT topmost win.c:11811: Test failed: 00000000021000E6: expected next 0000000000070148, got 0000000000000000 win.c:11811: Test failed: 00000000021000E6: expected NOT topmost win.c:11606: Test failed: 1: hwnd 00000000002600A8 is still topmost win.c:11606: Test failed: 2: hwnd 00000000002700C4 is still topmost win.c:11606: Test failed: 3: hwnd 0000000000070148 is still topmost win.c:11606: Test failed: 4: hwnd 00000000021000E6 is still topmost win.c:11834: Test failed: 00000000002600A8: expected NOT topmost win.c:11835: Test failed: 00000000021000E6: expected next 0000000000070148, got 0000000000000000 win.c:11835: Test failed: 00000000021000E6: expected NOT topmost win.c:11606: Test failed: 1: hwnd 00000000002600A8 is still topmost win.c:11606: Test failed: 2: hwnd 00000000002700C4 is still topmost win.c:11606: Test failed: 3: hwnd 0000000000070148 is still topmost win.c:11606: Test failed: 4: hwnd 00000000021000E6 is still topmost win.c:11869: Test failed: 00000000021000E6: expected next 0000000000070148, got 0000000000000000 win.c:11869: Test failed: 00000000021000E6: expected NOT topmost win.c:11606: Test failed: 1: hwnd 00000000002600A8 is still topmost win.c:11606: Test failed: 2: hwnd 00000000002700C4 is still topmost win.c:11606: Test failed: 3: hwnd 0000000000070148 is still topmost win.c:11606: Test failed: 4: hwnd 00000000021000E6 is still topmost win.c:11892: Test failed: 00000000021000E6: expected NOT topmost win.c:11606: Test failed: 1: hwnd 00000000002600A8 is still topmost win.c:11606: Test failed: 2: hwnd 00000000002700C4 is still topmost win.c:11606: Test failed: 3: hwnd 0000000000070148 is still topmost win.c:11606: Test failed: 4: hwnd 00000000021000E6 is still topmost win.c:11903: Test failed: 00000000021000E6: expected next 0000000000070148, got 0000000000000000 win.c:11903: Test failed: 00000000021000E6: expected NOT topmost win.c:11606: Test failed: 1: hwnd 00000000002600A8 is still topmost win.c:11606: Test failed: 2: hwnd 00000000002700C4 is still topmost win.c:11606: Test failed: 3: hwnd 0000000000070148 is still topmost win.c:11606: Test failed: 4: hwnd 00000000021000E6 is still topmost win.c:11606: Test failed: 1: hwnd 00000000002600A8 is still topmost win.c:11606: Test failed: 2: hwnd 00000000002700C4 is still topmost win.c:11606: Test failed: 3: hwnd 0000000000070148 is still topmost win.c:11606: Test failed: 4: hwnd 00000000021000E6 is still topmost win.c:11606: Test failed: 1: hwnd 00000000002600A8 is still topmost win.c:11606: Test failed: 2: hwnd 00000000002700C4 is still topmost win.c:11606: Test failed: 3: hwnd 0000000000070148 is still topmost win.c:11606: Test failed: 4: hwnd 00000000021000E6 is still topmost

April 1, 2022

[PATCH] crypt32/tests: Add more OCSP response decoding tests.

by Hans Leidekker

Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> --- dlls/crypt32/tests/encode.c | 88 ++++++++++++++++++++++++++++++++++--- 1 file changed, 83 insertions(+), 5 deletions(-) diff --git a/dlls/crypt32/tests/encode.c b/dlls/crypt32/tests/encode.c index f25c779a9ce..8b1959fbef8 100644 --- a/dlls/crypt32/tests/encode.c +++ b/dlls/crypt32/tests/encode.c @@ -8860,7 +8860,7 @@ static const BYTE ocsp_basic_signed_response[] = { 0x05, 0x51, 0x49, 0xac, 0x2f, 0xe8, 0x67, 0xcf, 0xa7 }; -static const BYTE ocsp_to_be_signed[] = { +static const BYTE ocsp_basic_response[] = { 0x30, 0x81, 0x9e, 0xa2, 0x16, 0x04, 0x14, 0xb7, 0x6b, 0xa2, 0xea, 0xa8, 0xaa, 0x84, 0x8c, 0x79, 0xea, 0xb4, 0xda, 0x0f, 0x98, 0xb2, 0xc5, 0x95, 0x76, 0xb9, 0xf4, 0x18, 0x0f, 0x32, 0x30, 0x32, 0x32, 0x30, 0x33, 0x31, @@ -8877,6 +8877,24 @@ static const BYTE ocsp_to_be_signed[] = { 0x33, 0x36, 0x30, 0x31, 0x5a }; +static const BYTE ocsp_basic_response_revoked[] = { + 0x30, 0x81, 0xb1, 0xa2, 0x16, 0x04, 0x14, 0xa4, 0x8d, 0xe5, 0xbe, 0x7c, + 0x79, 0xe4, 0x70, 0x23, 0x6d, 0x2e, 0x29, 0x34, 0xad, 0x23, 0x58, 0xdc, + 0xf5, 0x31, 0x7f, 0x18, 0x0f, 0x32, 0x30, 0x32, 0x32, 0x30, 0x33, 0x33, + 0x31, 0x30, 0x31, 0x32, 0x35, 0x30, 0x35, 0x5a, 0x30, 0x81, 0x85, 0x30, + 0x81, 0x82, 0x30, 0x49, 0x30, 0x09, 0x06, 0x05, 0x2b, 0x0e, 0x03, 0x02, + 0x1a, 0x05, 0x00, 0x04, 0x14, 0x74, 0xb4, 0xe7, 0x23, 0x19, 0xc7, 0x65, + 0x92, 0x15, 0x40, 0x44, 0x7b, 0xc7, 0xce, 0x3e, 0x90, 0xc2, 0x18, 0x76, + 0xeb, 0x04, 0x14, 0xa4, 0x8d, 0xe5, 0xbe, 0x7c, 0x79, 0xe4, 0x70, 0x23, + 0x6d, 0x2e, 0x29, 0x34, 0xad, 0x23, 0x58, 0xdc, 0xf5, 0x31, 0x7f, 0x02, + 0x10, 0x0d, 0x2e, 0x67, 0xa2, 0x98, 0x85, 0x3b, 0x9a, 0x54, 0x52, 0xe3, + 0xa2, 0x85, 0xa4, 0x57, 0x2f, 0xa1, 0x11, 0x18, 0x0f, 0x32, 0x30, 0x32, + 0x31, 0x31, 0x30, 0x32, 0x37, 0x32, 0x31, 0x33, 0x38, 0x34, 0x38, 0x5a, + 0x18, 0x0f, 0x32, 0x30, 0x32, 0x32, 0x30, 0x33, 0x33, 0x31, 0x30, 0x31, + 0x30, 0x39, 0x30, 0x31, 0x5a, 0xa0, 0x11, 0x18, 0x0f, 0x32, 0x30, 0x32, + 0x32, 0x30, 0x34, 0x30, 0x37, 0x30, 0x30, 0x32, 0x34, 0x30, 0x31, 0x5a +}; + static const BYTE ocsp_signature[] = { 0x6a, 0x4c, 0xfa, 0xe6, 0xe3, 0x48, 0xbb, 0xd6, 0x18, 0x33, 0x04, 0x9d, 0x6a, 0x92, 0x4d, 0x01, 0x74, 0x4f, 0x1a, 0x70, 0xfa, 0xf2, 0x8b, 0xba, @@ -8914,8 +8932,8 @@ static void test_decodeOCSPBasicSignedResponseInfo(DWORD dwEncoding) ok(ret, "got %08lx\n", GetLastError()); if (sizeof(void *) == 4) todo_wine ok(size == 496, "got %lu\n", size); else ok(size == 536, "got %lu\n", size); - ok(info->ToBeSigned.cbData == sizeof(ocsp_to_be_signed), "got %lu\n", info->ToBeSigned.cbData); - ok(!memcmp(info->ToBeSigned.pbData, ocsp_to_be_signed, sizeof(ocsp_to_be_signed)), "wrong data\n"); + ok(info->ToBeSigned.cbData == sizeof(ocsp_basic_response), "got %lu\n", info->ToBeSigned.cbData); + ok(!memcmp(info->ToBeSigned.pbData, ocsp_basic_response, sizeof(ocsp_basic_response)), "wrong data\n"); ok(!strcmp(info->SignatureInfo.SignatureAlgorithm.pszObjId, szOID_RSA_SHA256RSA), "got %s\n", info->SignatureInfo.SignatureAlgorithm.pszObjId); @@ -8941,22 +8959,35 @@ static void test_decodeOCSPBasicResponseInfo(DWORD dwEncoding) static const BYTE resp_id[] = { 0xb7, 0x6b, 0xa2, 0xea, 0xa8, 0xaa, 0x84, 0x8c, 0x79, 0xea, 0xb4, 0xda, 0x0f, 0x98, 0xb2, 0xc5, 0x95, 0x76, 0xb9, 0xf4}; + static const BYTE resp_id2[] = { + 0xa4, 0x8d, 0xe5, 0xbe, 0x7c, 0x79, 0xe4, 0x70, 0x23, 0x6d, 0x2e, 0x29, 0x34, 0xad, 0x23, 0x58, + 0xdc, 0xf5, 0x31, 0x7f}; static const BYTE name_hash[] = { 0xe4, 0xe3, 0x95, 0xa2, 0x29, 0xd3, 0xd4, 0xc1, 0xc3, 0x1f, 0xf0, 0x98, 0x0c, 0x0b, 0x4e, 0xc0, 0x09, 0x8a, 0xab, 0xd8}; + static const BYTE name_hash2[] = { + 0x74, 0xb4, 0xe7, 0x23, 0x19, 0xc7, 0x65, 0x92, 0x15, 0x40, 0x44, 0x7b, 0xc7, 0xce, 0x3e, 0x90, + 0xc2, 0x18, 0x76, 0xeb}; static const BYTE key_hash[] = { 0xb7, 0x6b, 0xa2, 0xea, 0xa8, 0xaa, 0x84, 0x8c, 0x79, 0xea, 0xb4, 0xda, 0x0f, 0x98, 0xb2, 0xc5, 0x95, 0x76, 0xb9, 0xf4}; + static const BYTE key_hash2[] = { + 0xa4, 0x8d, 0xe5, 0xbe, 0x7c, 0x79, 0xe4, 0x70, 0x23, 0x6d, 0x2e, 0x29, 0x34, 0xad, 0x23, 0x58, + 0xdc, 0xf5, 0x31, 0x7f}; static const BYTE serial[] = { 0xb1, 0xc1, 0x87, 0x54, 0x54, 0xac, 0x1e, 0x55, 0x40, 0xfb, 0xef, 0xd9, 0x6d, 0x8f, 0x49, 0x08}; + static const BYTE serial2[] = { + 0x2f, 0x57, 0xa4, 0x85, 0xa2, 0xe3, 0x52, 0x54, 0x9a, 0x3b, 0x85, 0x98, 0xa2, 0x67, 0x2e, 0x0d}; OCSP_BASIC_RESPONSE_INFO *info; OCSP_BASIC_RESPONSE_ENTRY *entry; + OCSP_BASIC_REVOKED_INFO *revoked; DWORD size; BOOL ret; + /* good cert */ size = 0; - ret = pCryptDecodeObjectEx(dwEncoding, OCSP_BASIC_RESPONSE, ocsp_to_be_signed, - sizeof(ocsp_to_be_signed), CRYPT_DECODE_ALLOC_FLAG, NULL, &info, &size); + ret = pCryptDecodeObjectEx(dwEncoding, OCSP_BASIC_RESPONSE, ocsp_basic_response, + sizeof(ocsp_basic_response), CRYPT_DECODE_ALLOC_FLAG, NULL, &info, &size); ok(ret, "got %08lx\n", GetLastError()); ok(!info->dwVersion, "got %lu\n", info->dwVersion); @@ -8991,6 +9022,53 @@ static void test_decodeOCSPBasicResponseInfo(DWORD dwEncoding) ok(!info->cExtension, "got %lu\n", info->cExtension); ok(info->rgExtension == NULL, "got %p\n", info->rgExtension); LocalFree(info); + + /* revoked cert */ + size = 0; + ret = pCryptDecodeObjectEx(dwEncoding, OCSP_BASIC_RESPONSE, ocsp_basic_response_revoked, + sizeof(ocsp_basic_response_revoked), CRYPT_DECODE_ALLOC_FLAG, NULL, &info, &size); + todo_wine ok(ret, "got %08lx\n", GetLastError()); + + if (ret) { + ok(!info->dwVersion, "got %lu\n", info->dwVersion); + ok(info->dwResponderIdChoice == 2, "got %lu\n", info->dwResponderIdChoice); + ok(info->ByKeyResponderId.cbData == sizeof(resp_id), "got %lu\n", info->ByKeyResponderId.cbData); + ok(!memcmp(info->ByKeyResponderId.pbData, resp_id2, sizeof(resp_id2)), "wrong data\n"); + ok(info->ProducedAt.dwLowDateTime == 647048832, "got %lu\n", info->ProducedAt.dwLowDateTime); + ok(info->ProducedAt.dwHighDateTime == 30950558, "got %lu\n", info->ProducedAt.dwHighDateTime); + ok(info->cResponseEntry == 1, "got %lu\n", info->cResponseEntry); + ok(info->rgResponseEntry != NULL, "got %p\n", info->rgResponseEntry); + + entry = info->rgResponseEntry; + ok(!strcmp(entry->CertId.HashAlgorithm.pszObjId, szOID_OIWSEC_sha1), "got '%s'\n", entry->CertId.HashAlgorithm.pszObjId); + ok(entry->CertId.HashAlgorithm.Parameters.cbData == 2, "got %lu\n", entry->CertId.HashAlgorithm.Parameters.cbData); + ok(entry->CertId.HashAlgorithm.Parameters.pbData[0] == 5, "got 0x%02x\n", entry->CertId.HashAlgorithm.Parameters.pbData[0]); + ok(!entry->CertId.HashAlgorithm.Parameters.pbData[1], "got 0x%02x\n", entry->CertId.HashAlgorithm.Parameters.pbData[1]); + ok(entry->CertId.IssuerNameHash.cbData == 20, "got %lu\n", entry->CertId.IssuerNameHash.cbData); + ok(!memcmp(entry->CertId.IssuerNameHash.pbData, name_hash2, sizeof(name_hash2)), "wrong data\n"); + ok(entry->CertId.IssuerKeyHash.cbData == 20, "got %lu\n", entry->CertId.IssuerKeyHash.cbData); + ok(!memcmp(entry->CertId.IssuerKeyHash.pbData, key_hash2, sizeof(key_hash2)), "wrong data\n"); + ok(entry->CertId.SerialNumber.cbData == 16, "got %lu\n", entry->CertId.SerialNumber.cbData); + ok(!memcmp(entry->CertId.SerialNumber.pbData, serial2, sizeof(serial2)), "wrong data\n"); + ok(entry->dwCertStatus == 1, "got %lu\n", entry->dwCertStatus); + ok(entry->pRevokedInfo != NULL, "got NULL\n"); + + revoked = entry->pRevokedInfo; + ok(revoked->RevocationDate.dwLowDateTime == 107865088, "got %lu\n", revoked->RevocationDate.dwLowDateTime); + ok(revoked->RevocationDate.dwHighDateTime == 30919547, "got %lu\n", revoked->RevocationDate.dwHighDateTime); + ok(!revoked->dwCrlReasonCode, "got %lu\n", revoked->dwCrlReasonCode); + + ok(entry->ThisUpdate.dwLowDateTime == 3891950720, "got %lu\n", entry->ThisUpdate.dwLowDateTime); + ok(entry->ThisUpdate.dwHighDateTime == 30950555, "got %lu\n", entry->ThisUpdate.dwHighDateTime); + ok(entry->NextUpdate.dwLowDateTime == 3347801728, "got %lu\n", entry->NextUpdate.dwLowDateTime); + ok(entry->NextUpdate.dwHighDateTime == 30951957, "got %lu\n", entry->NextUpdate.dwHighDateTime); + ok(!entry->cExtension, "got %lu\n", entry->cExtension); + ok(entry->rgExtension == NULL, "got %p\n", entry->rgExtension); + + ok(!info->cExtension, "got %lu\n", info->cExtension); + ok(info->rgExtension == NULL, "got %p\n", info->rgExtension); + } + LocalFree(info); } START_TEST(encode) -- 2.30.2

April 1, 2022

Re: [PATCH 1/6] include/winerror.h: Add missing WinRT HRESULT codes.

by Rémi Bernon

On 4/1/22 11:36, Jacek Caban wrote: > Hi Rémi, > > On 4/1/22 10:47, Rémi Bernon wrote: >> I'm not completely sure what's the policy about this but it looks like >> you only need E_ILLEGAL_DELEGATE_ASSIGNMENT after all. > > > It's a public header, it's fine to add public declarations even if we > don't need them (yet?) for Wine itself. > > > Jacek > Alright, looks good then! -- Rémi Bernon <rbernon(a)codeweavers.com>

April 1, 2022

Re: [PATCH 1/6] include/winerror.h: Add missing WinRT HRESULT codes.

by Jacek Caban

Hi Rémi, On 4/1/22 10:47, Rémi Bernon wrote: > I'm not completely sure what's the policy about this but it looks like > you only need E_ILLEGAL_DELEGATE_ASSIGNMENT after all. It's a public header, it's fine to add public declarations even if we don't need them (yet?) for Wine itself. Jacek

April 1, 2022

Re: [PATCH 1/6] include/winerror.h: Add missing WinRT HRESULT codes.

by Bernhard Kölbl

Hi, I thought it's a bit odd to create an "island" with missing values in between. I think some of these might in fact become useful in the future like RO_E_CLOSED (likely IClosable) or the async operation not started value. Bernhard Rémi Bernon <rbernon(a)codeweavers.com> schrieb am Fr., 1. Apr. 2022, 10:47: > Hi Bernhard, > > On 3/31/22 18:17, Bernhard Kölbl wrote: > > Taken from MSDN and original winerror.h. > > > > Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> > > --- > > include/winerror.h | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > > > diff --git a/include/winerror.h b/include/winerror.h > > index b63b74a5b18..d51d5648cdb 100644 > > --- a/include/winerror.h > > +++ b/include/winerror.h > > @@ -2578,6 +2578,25 @@ static inline HRESULT HRESULT_FROM_WIN32(unsigned > int x) > > #define E_CHANGED_STATE > _HRESULT_TYPEDEF_(0x8000000C) > > #define E_ILLEGAL_STATE_CHANGE > _HRESULT_TYPEDEF_(0x8000000D) > > #define E_ILLEGAL_METHOD_CALL > _HRESULT_TYPEDEF_(0x8000000E) > > +#define RO_E_METADATA_NAME_NOT_FOUND > _HRESULT_TYPEDEF_(0x8000000F) > > +#define RO_E_METADATA_NAME_IS_NAMESPACE > _HRESULT_TYPEDEF_(0x80000010) > > +#define RO_E_METADATA_INVALID_TYPE_FORMAT > _HRESULT_TYPEDEF_(0x80000011) > > +#define RO_E_INVALID_METADATA_FILE > _HRESULT_TYPEDEF_(0x80000012) > > +#define RO_E_CLOSED > _HRESULT_TYPEDEF_(0x80000013) > > +#define RO_E_EXCLUSIVE_WRITE > _HRESULT_TYPEDEF_(0x80000014) > > +#define RO_E_CHANGE_NOTIFICATION_IN_PROGRESS > _HRESULT_TYPEDEF_(0x80000015) > > +#define RO_E_ERROR_STRING_NOT_FOUND > _HRESULT_TYPEDEF_(0x80000016) > > +#define E_STRING_NOT_NULL_TERMINATED > _HRESULT_TYPEDEF_(0x80000017) > > +#define E_ILLEGAL_DELEGATE_ASSIGNMENT > _HRESULT_TYPEDEF_(0x80000018) > > +#define E_ASYNC_OPERATION_NOT_STARTED > _HRESULT_TYPEDEF_(0x80000019) > > +#define E_APPLICATION_EXITING > _HRESULT_TYPEDEF_(0x8000001A) > > +#define E_APPLICATION_VIEW_EXITING > _HRESULT_TYPEDEF_(0x8000001B) > > +#define RO_E_MUST_BE_AGILE > _HRESULT_TYPEDEF_(0x8000001C) > > +#define RO_E_UNSUPPORTED_FROM_MTA > _HRESULT_TYPEDEF_(0x8000001D) > > +#define RO_E_COMMITTED > _HRESULT_TYPEDEF_(0x8000001E) > > +#define RO_E_BLOCKED_CROSS_ASTA_CALL > _HRESULT_TYPEDEF_(0x8000001F) > > +#define RO_E_CANNOT_ACTIVATE_FULL_TRUST_SERVER > _HRESULT_TYPEDEF_(0x80000020) > > +#define RO_E_CANNOT_ACTIVATE_UNIVERSAL_APPLICATION_SERVER > _HRESULT_TYPEDEF_(0x80000021) > > > > #define E_NOTIMPL > _HRESULT_TYPEDEF_(0x80004001) > > #define E_NOINTERFACE > _HRESULT_TYPEDEF_(0x80004002) > > > I'm not completely sure what's the policy about this but it looks like > you only need E_ILLEGAL_DELEGATE_ASSIGNMENT after all. > > Most of these error seem very specific to MS implementation, I don't > know if they will be very useful to add? > -- > Rémi Bernon <rbernon(a)codeweavers.com> > >

April 1, 2022

[PATCH 6/6] win32u: Move NtUserSendInput implementation from user32.

by Jacek Caban

April 1, 2022

[PATCH 5/6] win32u: Move __wine_send_input implementation from user32.

by Jacek Caban

April 1, 2022

[PATCH 4/6] win32u: Move send_internal_message_timeout implementation from user32.

by Jacek Caban

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/user32/message.c | 43 +- dlls/user32/user_main.c | 2 +- dlls/user32/user_private.h | 5 +- dlls/win32u/hook.c | 14 +- dlls/win32u/message.c | 768 +++++++++++++++++++++++++++++++++++ dlls/win32u/ntuser_private.h | 3 +- dlls/win32u/win32u_private.h | 3 + 7 files changed, 783 insertions(+), 55 deletions(-)

April 1, 2022

[PATCH 3/6] user32: Avoid internal structs in post_dde_message.

by Jacek Caban

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/user32/message.c | 53 ++++++++++++++++++++----------------------- 1 file changed, 25 insertions(+), 28 deletions(-)

April 1, 2022