June 2022 - Wine-Devel - list.winehq.org

Re: [PATCH 0/6] MR261: win32u: nonclient conversion

by Jacek Caban (＠jacek)

On Fri Jun 17 06:44:16 2022 +0000, Huw Davies wrote: > We probably want to remove the item (and the separator above it) from > the SYSMENU then ;-) > Also, there are a couple of work-arounds for it in the menu tests that > could also go away. Oh, right. Thinking more about it, once we have SC_TASKLIST converted, it should be easy enough to convert this one as well that we might as well keep it. I will push v2 without this patch and with other comments addressed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/261#note_2262

June 17, 2022

Re: [PATCH v4 4/4] server: Don't invalidate the newly exposed child region on the parent if it doesn't clip children.

by Marvin

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=117156 Your paranoid android. === debian11 (32 bit report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9638: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Arabic:Morocco report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9638: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit German report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9638: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit French report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9638: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Hebrew:Israel report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9638: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Hindi:India report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9638: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Japanese:Japan report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9638: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Chinese:China report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9638: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit WoW report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9638: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (64 bit WoW report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9638: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000

June 17, 2022

Re: [PATCH v4 3/4] server: Redraw composited window child when its z-order changes.

by Marvin

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=117155 Your paranoid android. === w10pro64 (32 bit report) === user32: msg.c:13256: Test failed: message time not advanced: bb60 bb60 msg.c:13257: Test failed: coords not changed: (105 105) (105 105) === w1064_tsign (64 bit report) === user32: msg.c:13256: Test failed: message time not advanced: e57e e57e msg.c:13257: Test failed: coords not changed: (105 105) (105 105) === debian11 (32 bit report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Arabic:Morocco report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit German report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit French report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Hebrew:Israel report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Hindi:India report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Japanese:Japan report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Chinese:China report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit WoW report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (64 bit WoW report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000

June 17, 2022

Re: [PATCH v4 2/4] server: Correctly expose composited parent window and its child on position change.

by Marvin

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=117154 Your paranoid android. === w1064_adm (64 bit report) === user32: msg.c:13238: Test failed: message time not advanced: d2ff d2ff msg.c:13239: Test failed: coords not changed: (101 101) (101 101) msg.c:13256: Test failed: message time not advanced: d2ff d2ff msg.c:13257: Test failed: coords not changed: (101 101) (101 101) === w10pro64_en_AE_u8 (64 bit report) === user32: msg.c:13256: Test failed: message time not advanced: 15a5f 15a5f msg.c:13257: Test failed: coords not changed: (105 105) (105 105) === w10pro64_ar (64 bit report) === user32: msg.c:13238: Test failed: message time not advanced: 15222 15222 msg.c:13239: Test failed: coords not changed: (101 101) (101 101) msg.c:13256: Test failed: message time not advanced: 15222 15222 msg.c:13257: Test failed: coords not changed: (101 101) (101 101) === w10pro64_zh_CN (64 bit report) === user32: msg.c:13238: Test failed: message time not advanced: 153e7 153e7 msg.c:13239: Test failed: coords not changed: (101 101) (101 101) msg.c:13256: Test failed: message time not advanced: 153e7 153e7 msg.c:13257: Test failed: coords not changed: (101 101) (101 101) === debian11 (32 bit report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Arabic:Morocco report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit German report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit French report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Hebrew:Israel report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Hindi:India report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Japanese:Japan report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Chinese:China report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit WoW report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (64 bit WoW report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000

June 17, 2022

Re: [PATCH v2 1/4] user32/tests: Add some more tests related to the RAWINPUT structure.

by Marvin

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=117159 Your paranoid android. === w7u_2qxl (32 bit report) === user32: input.c:745: Test failed: 0 (a4/0): 00 from 00 -> 80 unexpected input.c:745: Test failed: 0 (a4/0): 41 from 01 -> 00 unexpected === w7u_el (32 bit report) === user32: input.c:4525: Test failed: SendInput triggered unexpected message 0xc042 === w1064 (32 bit report) === user32: input.c:3513: Test failed: expected WM_RBUTTONDOWN message input.c:3514: Test failed: expected WM_RBUTTONUP message === w1064v1809 (64 bit report) === user32: input.c:1311: Test failed: GetCursorPos: (100,100) === w1064_tsign (64 bit report) === user32: input.c:1291: Test failed: Wrong set pos: (100,98)

June 17, 2022

Re: [PATCH v4 1/4] user32/tests: Test for window exposure behaviours.

by Marvin

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=117153 Your paranoid android. === w10pro64 (32 bit report) === user32: msg.c:13238: Test failed: message time not advanced: c4c7 c4c7 msg.c:13239: Test failed: coords not changed: (101 101) (101 101) msg.c:13256: Test failed: message time not advanced: c4c7 c4c7 msg.c:13257: Test failed: coords not changed: (101 101) (101 101) === w10pro64_en_AE_u8 (64 bit report) === user32: msg.c:13238: Test failed: message time not advanced: 155ac 155ac msg.c:13239: Test failed: coords not changed: (101 101) (101 101) msg.c:13256: Test failed: message time not advanced: 155ac 155ac msg.c:13257: Test failed: coords not changed: (101 101) (101 101) === debian11 (32 bit German report) === user32: msg.c:18882: Test succeeded inside todo block: wrong status 00000000 msg.c:18886: Test succeeded inside todo block: SendMessage from other thread 5: marked "todo_wine" but succeeds === debian11 (32 bit Hindi:India report) === user32: msg.c:18854: Test succeeded inside todo block: SendMessage from other thread 1: marked "todo_wine" but succeeds msg.c:18858: Test succeeded inside todo block: WaitForSingleObject failed, ret:0 msg.c:18874: Test succeeded inside todo block: SendMessage from other thread 3: marked "todo_wine" but succeeds msg.c:18882: Test succeeded inside todo block: wrong status 00000000 msg.c:18886: Test succeeded inside todo block: SendMessage from other thread 5: marked "todo_wine" but succeeds

June 17, 2022

Re: [PATCH v2 2/5] winegstreamer: Implement ResamplerMediaObject transform.

by Marvin

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=117131 Your paranoid android. === build (build log) === error: patch failed: dlls/mf/tests/mf.c:254 error: patch failed: dlls/winegstreamer/Makefile.in:14 error: patch failed: dlls/winegstreamer/gst_private.h:111 error: patch failed: dlls/winegstreamer/main.c:437 error: patch failed: dlls/winegstreamer/mfplat.c:440 error: patch failed: dlls/winegstreamer/winegstreamer_classes.idl:86 error: patch failed: dlls/mf/tests/mf.c:7570 error: patch failed: dlls/winegstreamer/resampler.c:28 error: patch failed: dlls/winegstreamer/wg_transform.c:406 Task: Patch failed to apply === debian11 (build log) === error: patch failed: dlls/mf/tests/mf.c:254 error: patch failed: dlls/winegstreamer/Makefile.in:14 error: patch failed: dlls/winegstreamer/gst_private.h:111 error: patch failed: dlls/winegstreamer/main.c:437 error: patch failed: dlls/winegstreamer/mfplat.c:440 error: patch failed: dlls/winegstreamer/winegstreamer_classes.idl:86 error: patch failed: dlls/mf/tests/mf.c:7570 error: patch failed: dlls/winegstreamer/resampler.c:28 error: patch failed: dlls/winegstreamer/wg_transform.c:406 Task: Patch failed to apply === debian11 (build log) === error: patch failed: dlls/mf/tests/mf.c:254 error: patch failed: dlls/winegstreamer/Makefile.in:14 error: patch failed: dlls/winegstreamer/gst_private.h:111 error: patch failed: dlls/winegstreamer/main.c:437 error: patch failed: dlls/winegstreamer/mfplat.c:440 error: patch failed: dlls/winegstreamer/winegstreamer_classes.idl:86 error: patch failed: dlls/mf/tests/mf.c:7570 error: patch failed: dlls/winegstreamer/resampler.c:28 error: patch failed: dlls/winegstreamer/wg_transform.c:406 Task: Patch failed to apply

June 17, 2022

Re: [PATCH v2 1/5] winegstreamer: Register stub ResamplerMediaObject transform.

by Marvin

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=117130 Your paranoid android. === build (build log) === error: patch failed: dlls/mf/tests/mf.c:254 error: patch failed: dlls/winegstreamer/Makefile.in:14 error: patch failed: dlls/winegstreamer/gst_private.h:111 error: patch failed: dlls/winegstreamer/main.c:437 error: patch failed: dlls/winegstreamer/mfplat.c:440 error: patch failed: dlls/winegstreamer/winegstreamer_classes.idl:86 Task: Patch failed to apply === debian11 (build log) === error: patch failed: dlls/mf/tests/mf.c:254 error: patch failed: dlls/winegstreamer/Makefile.in:14 error: patch failed: dlls/winegstreamer/gst_private.h:111 error: patch failed: dlls/winegstreamer/main.c:437 error: patch failed: dlls/winegstreamer/mfplat.c:440 error: patch failed: dlls/winegstreamer/winegstreamer_classes.idl:86 Task: Patch failed to apply === debian11 (build log) === error: patch failed: dlls/mf/tests/mf.c:254 error: patch failed: dlls/winegstreamer/Makefile.in:14 error: patch failed: dlls/winegstreamer/gst_private.h:111 error: patch failed: dlls/winegstreamer/main.c:437 error: patch failed: dlls/winegstreamer/mfplat.c:440 error: patch failed: dlls/winegstreamer/winegstreamer_classes.idl:86 Task: Patch failed to apply

June 17, 2022

[PATCH 1/1] winhttp: Release object on allocation failure.

by Hans Leidekker

From: Hans Leidekker <hans(a)codeweavers.com> --- dlls/winhttp/request.c | 52 +++++++++++++++++++++++++++++++++--------- 1 file changed, 41 insertions(+), 11 deletions(-) diff --git a/dlls/winhttp/request.c b/dlls/winhttp/request.c index 7fb582362aa..ece4e34f0b8 100644 --- a/dlls/winhttp/request.c +++ b/dlls/winhttp/request.c @@ -2308,7 +2308,12 @@ BOOL WINAPI WinHttpSendRequest( HINTERNET hrequest, const WCHAR *headers, DWORD { struct send_request *s; - if (!(s = malloc( sizeof(*s) ))) return FALSE; + if (!(s = malloc( sizeof(*s) ))) + { + release_object( &request->hdr ); + SetLastError( ERROR_OUTOFMEMORY ); + return FALSE; + } s->headers = strdupW( headers ); s->headers_len = headers_len; s->optional = optional; @@ -2886,8 +2891,12 @@ BOOL WINAPI WinHttpReceiveResponse( HINTERNET hrequest, LPVOID reserved ) { struct receive_response *r; - if (!(r = malloc( sizeof(*r) ))) return FALSE; - + if (!(r = malloc( sizeof(*r) ))) + { + release_object( &request->hdr ); + SetLastError( ERROR_OUTOFMEMORY ); + return FALSE; + } if ((ret = queue_task( &request->queue, task_receive_response, &r->task_hdr, &request->hdr ))) free( r ); } @@ -2981,7 +2990,13 @@ BOOL WINAPI WinHttpQueryDataAvailable( HINTERNET hrequest, LPDWORD available ) { struct query_data *q; - if (!(q = malloc( sizeof(*q) ))) return FALSE; + if (!(q = malloc( sizeof(*q) ))) + { + release_object( &request->hdr ); + SetLastError( ERROR_OUTOFMEMORY ); + return FALSE; + } + q->available = available; if ((ret = queue_task( &request->queue, task_query_data_available, &q->task_hdr, &request->hdr ))) @@ -3034,7 +3049,12 @@ BOOL WINAPI WinHttpReadData( HINTERNET hrequest, void *buffer, DWORD to_read, DW { struct read_data *r; - if (!(r = malloc( sizeof(*r) ))) return FALSE; + if (!(r = malloc( sizeof(*r) ))) + { + release_object( &request->hdr ); + SetLastError( ERROR_OUTOFMEMORY ); + return FALSE; + } r->buffer = buffer; r->to_read = to_read; r->read = read; @@ -3110,7 +3130,12 @@ BOOL WINAPI WinHttpWriteData( HINTERNET hrequest, const void *buffer, DWORD to_w { struct write_data *w; - if (!(w = malloc( sizeof(*w) ))) return FALSE; + if (!(w = malloc( sizeof(*w) ))) + { + release_object( &request->hdr ); + SetLastError( ERROR_OUTOFMEMORY ); + return FALSE; + } w->buffer = buffer; w->to_write = to_write; w->written = written; @@ -3973,10 +3998,11 @@ DWORD WINAPI WinHttpWebSocketReceive( HINTERNET hsocket, void *buf, DWORD len, D if (!(r = malloc( sizeof(*r) ))) { InterlockedDecrement( &socket->hdr.pending_receives ); + release_object( &socket->hdr ); return ERROR_OUTOFMEMORY; } - r->buf = buf; - r->len = len; + r->buf = buf; + r->len = len; if ((ret = queue_task( &socket->recv_q, task_socket_receive, &r->task_hdr, &socket->hdr ))) { @@ -4191,8 +4217,8 @@ DWORD WINAPI WinHttpWebSocketClose( HINTERNET hsocket, USHORT status, void *reas cancel_queue( &socket->recv_q ); } - if (prev_state < SOCKET_STATE_SHUTDOWN - && (ret = send_socket_shutdown( socket, status, reason, len, FALSE ))) goto done; + if (prev_state < SOCKET_STATE_SHUTDOWN && (ret = send_socket_shutdown( socket, status, reason, len, FALSE ))) + goto done; if (pending_receives == 1 && socket->close_frame_received) { @@ -4205,7 +4231,11 @@ DWORD WINAPI WinHttpWebSocketClose( HINTERNET hsocket, USHORT status, void *reas { struct socket_shutdown *s; - if (!(s = calloc( 1, sizeof(*s) ))) return FALSE; + if (!(s = calloc( 1, sizeof(*s) ))) + { + ret = ERROR_OUTOFMEMORY; + goto done; + } if ((ret = queue_task( &socket->recv_q, task_socket_close, &s->task_hdr, &socket->hdr ))) { InterlockedDecrement( &socket->hdr.pending_receives ); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/262

June 17, 2022

[PATCH 0/1] MR262: winhttp: Release object on allocation failure.

by Hans Leidekker (＠hans)

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/262

June 17, 2022