June 2022 - Wine-Devel - list.winehq.org

Re: [PATCH v4 2/4] server: Correctly expose composited parent window and its child on position change.

by Marvin

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. 1 TestBot errors prevented a full analysis of your patch. If the test caused the operating system (e.g. Windows) to crash or reboot you will probably have to modify it to avoid that. Other issues should be reported to the TestBot administrators. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=117154 Your paranoid android. === w7u_2qxl (testbot log) === WineRunTask.pl:error: The previous 1 run(s) terminated abnormally === w1064 (testbot log) === WineRunTask.pl:error: The previous 1 run(s) terminated abnormally === w1064 (testbot log) === WineRunTask.pl:error: The previous 1 run(s) terminated abnormally === w10pro64_ar (testbot log) === WineRunTask.pl:error: BotError: The test VM is powered off! Did the test shut it down? === debian11 (32 bit report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Arabic:Morocco report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit German report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit French report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Hebrew:Israel report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Hindi:India report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Japanese:Japan report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Chinese:China report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit WoW report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (64 bit WoW report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000

June 17, 2022

Re: [PATCH v3 4/4] server: Don't invalidate the newly exposed child region on the parent with WS_CLIPCHILDREN.

by Marvin

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. 1 TestBot errors prevented a full analysis of your patch. If the test caused the operating system (e.g. Windows) to crash or reboot you will probably have to modify it to avoid that. Other issues should be reported to the TestBot administrators. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=117152 Your paranoid android. === w7u_adm (32 bit report) === user32: msg.c:9297: Test failed: 9400: SetWindowPos redraw #0 (ex_style = 0, style = 0x2000000, shuffle_zorder = 0, insert_after = 0): delta = -20: Parent update region shall match expected region msg.c:9354: Test failed: 9400: SetWindowPos redraw #0 (ex_style = 0, style = 0x2000000, shuffle_zorder = 0, insert_after = 0): delta = -20: Child update region shall match expected region msg.c:9297: Test failed: 9400: SetWindowPos redraw #0 (ex_style = 0, style = 0x2000000, shuffle_zorder = 0, insert_after = 0): delta = +20: Parent update region shall match expected region msg.c:9297: Test failed: 9400: SetWindowPos redraw #1 (ex_style = 0, style = 0, shuffle_zorder = 0, insert_after = 0): delta = -20: Parent update region shall match expected region msg.c:9354: Test failed: 9400: SetWindowPos redraw #1 (ex_style = 0, style = 0, shuffle_zorder = 0, insert_after = 0): delta = -20: Child update region shall match expected region msg.c:9297: Test failed: 9400: SetWindowPos redraw #1 (ex_style = 0, style = 0, shuffle_zorder = 0, insert_after = 0): delta = +20: Parent update region shall match expected region msg.c:9297: Test failed: 9400: SetWindowPos redraw #2 (ex_style = 0x2000000, style = 0x2000000, shuffle_zorder = 0, insert_after = 0): delta = -20: Parent update region shall match expected region msg.c:9297: Test failed: 9400: SetWindowPos redraw #2 (ex_style = 0x2000000, style = 0x2000000, shuffle_zorder = 0, insert_after = 0): delta = +20: Parent update region shall match expected region msg.c:9297: Test failed: 9400: SetWindowPos redraw #3 (ex_style = 0x2000000, style = 0x2000000, shuffle_zorder = 1, insert_after = 0): delta = -20: Parent update region shall match expected region msg.c:9297: Test failed: 9400: SetWindowPos redraw #3 (ex_style = 0x2000000, style = 0x2000000, shuffle_zorder = 1, insert_after = 0): delta = +20: Parent update region shall match expected region msg.c:9297: Test failed: 9400: SetWindowPos redraw #4 (ex_style = 0x2000000, style = 0x2000000, shuffle_zorder = 1, insert_after = 1): delta = -20: Parent update region shall match expected region msg.c:9297: Test failed: 9400: SetWindowPos redraw #4 (ex_style = 0x2000000, style = 0x2000000, shuffle_zorder = 1, insert_after = 1): delta = +20: Parent update region shall match expected region msg.c:9297: Test failed: 9400: SetWindowPos redraw #5 (ex_style = 0x2000000, style = 0, shuffle_zorder = 0, insert_after = 0): delta = -20: Parent update region shall match expected region msg.c:9297: Test failed: 9400: SetWindowPos redraw #5 (ex_style = 0x2000000, style = 0, shuffle_zorder = 0, insert_after = 0): delta = +20: Parent update region shall match expected region msg.c:9297: Test failed: 9400: SetWindowPos redraw #6 (ex_style = 0x2000000, style = 0, shuffle_zorder = 1, insert_after = 0): delta = -20: Parent update region shall match expected region msg.c:9297: Test failed: 9400: SetWindowPos redraw #6 (ex_style = 0x2000000, style = 0, shuffle_zorder = 1, insert_after = 0): delta = +20: Parent update region shall match expected region msg.c:9297: Test failed: 9400: SetWindowPos redraw #7 (ex_style = 0x2000000, style = 0, shuffle_zorder = 1, insert_after = 1): delta = -20: Parent update region shall match expected region msg.c:9297: Test failed: 9400: SetWindowPos redraw #7 (ex_style = 0x2000000, style = 0, shuffle_zorder = 1, insert_after = 1): delta = +20: Parent update region shall match expected region Report validation errors: user32:msg prints too much data (35886 bytes) === w1064v1507 (testbot log) === WineRunTask.pl:error: The previous 1 run(s) terminated abnormally === w1064v1507 (testbot log) === WineRunTask.pl:error: The previous 1 run(s) terminated abnormally === w1064 (testbot log) === WineRunTask.pl:error: The previous 1 run(s) terminated abnormally === w10pro64_en_AE_u8 (testbot log) === WineRunTask.pl:error: BotError: The test VM is powered off! Did the test shut it down? === debian11 (32 bit report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9638: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Arabic:Morocco report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9638: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit German report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9638: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit French report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9638: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Hebrew:Israel report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9638: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Hindi:India report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9638: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Japanese:Japan report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9638: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Chinese:China report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9638: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit WoW report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9638: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (64 bit WoW report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9638: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000

June 17, 2022

Re: [PATCH v3 3/4] server: Redraw composited window child on its z-order change on SetWindowPos().

by Marvin

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=117151 Your paranoid android. === w7u_el (32 bit report) === user32: msg.c:13317: Test failed: msg.message = 30 instead of WM_TIMER msg.c:13320: Test failed: msg.message = 275 instead of WM_USER msg.c:13322: Test failed: expected PeekMessage to return FALSE, got 1 msg.c:13333: Test failed: msg.message = 1024 instead of WM_TIMER msg.c:13335: Test failed: expected PeekMessage to return FALSE, got 1 msg.c:13345: Test failed: msg.message = 275 instead of WM_USER msg.c:13348: Test failed: msg.message = 1024 instead of WM_TIMER === w7u_el (testbot log) === WineRunTask.pl:error: The previous 1 run(s) terminated abnormally === w1064v1507 (testbot log) === WineRunTask.pl:error: The previous 1 run(s) terminated abnormally === w1064v1507 (testbot log) === WineRunTask.pl:error: The previous 1 run(s) terminated abnormally === w10pro64 (64 bit report) === user32: msg.c:15693: Test failed: unexpected message 31f msg.c:15694: Test failed: bad wparam 1 msg.c:15700: Test failed: unicode WM_CHAR: 0: the msg sequence is not complete: expected 0102 - actual 0000 === debian11 (32 bit report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Arabic:Morocco report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit German report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit French report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Hebrew:Israel report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Hindi:India report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Japanese:Japan report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Chinese:China report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit WoW report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (64 bit WoW report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000

June 17, 2022

Re: [PATCH v3 2/4] server: Correctly expose composited parent window on SetWindowPos().

by Marvin

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. 3 TestBot errors prevented a full analysis of your patch. If the test caused the operating system (e.g. Windows) to crash or reboot you will probably have to modify it to avoid that. Other issues should be reported to the TestBot administrators. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=117150 Your paranoid android. === w7u_el (testbot log) === WineRunTask.pl:error: BotError: The test VM is powered off! Did the test shut it down? === w1064v1507 (testbot log) === WineRunTask.pl:error: BotError: The test VM is powered off! Did the test shut it down? === w1064 (testbot log) === WineRunTask.pl:error: BotError: The test VM is powered off! Did the test shut it down? === w1064_tsign (testbot log) === WineRunTask.pl:error: The previous 1 run(s) terminated abnormally === w10pro64_en_AE_u8 (64 bit report) === user32: msg.c:13238: Test failed: message time not advanced: 15464 15464 msg.c:13239: Test failed: coords not changed: (101 101) (101 101) msg.c:13256: Test failed: message time not advanced: 15464 15464 msg.c:13257: Test failed: coords not changed: (101 101) (101 101) === w10pro64_ar (testbot log) === WineRunTask.pl:error: The previous 1 run(s) terminated abnormally === debian11 (32 bit report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Arabic:Morocco report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit German report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit French report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Hebrew:Israel report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Hindi:India report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Japanese:Japan report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit Chinese:China report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (32 bit WoW report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000 === debian11 (64 bit WoW report) === user32: msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5782: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5791: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5797: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:9642: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected 000f - actual 0000

June 17, 2022

Re: [PATCH v4 1/4] user32/tests: Test for window exposure behaviours.

by Marvin

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. 2 TestBot errors prevented a full analysis of your patch. If the test caused the operating system (e.g. Windows) to crash or reboot you will probably have to modify it to avoid that. Other issues should be reported to the TestBot administrators. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=117153 Your paranoid android. === w7u_adm (testbot log) === WineRunTask.pl:error: The previous 1 run(s) terminated abnormally === w1064v1507 (testbot log) === WineRunTask.pl:error: The previous 1 run(s) terminated abnormally === w1064 (32 bit report) === user32: msg.c:13238: Test failed: message time not advanced: d7b2 d7b2 msg.c:13239: Test failed: coords not changed: (101 101) (101 101) msg.c:13256: Test failed: message time not advanced: d7b2 d7b2 msg.c:13257: Test failed: coords not changed: (101 101) (101 101) === w1064 (64 bit report) === user32: msg.c:13238: Test failed: message time not advanced: d4d4 d4d4 msg.c:13239: Test failed: coords not changed: (101 101) (101 101) msg.c:13256: Test failed: message time not advanced: d4d4 d4d4 msg.c:13257: Test failed: coords not changed: (101 101) (101 101) === w1064_adm (64 bit report) === user32: msg.c:13238: Test failed: message time not advanced: d561 d561 msg.c:13239: Test failed: coords not changed: (101 101) (101 101) msg.c:13256: Test failed: message time not advanced: d561 d561 msg.c:13257: Test failed: coords not changed: (101 101) (101 101) === w1064_tsign (testbot log) === WineRunTask.pl:error: Could not copy the test executable to the VM: network read timed out (sendfile/connect:AgentVersion.h:0/9) WineRunTask.pl:error: BotError: The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died) WineRunTask.pl:error: Giving up after 3 run(s) === w10pro64_ar (testbot log) === WineRunTask.pl:error: BotError: The test VM is powered off! Did the test shut it down?

June 17, 2022

Re: [PATCH v3 1/4] user32/tests: Test for parent window exposure by SetWindowPos().

by Marvin

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. 3 TestBot errors prevented a full analysis of your patch. If the test caused the operating system (e.g. Windows) to crash or reboot you will probably have to modify it to avoid that. Other issues should be reported to the TestBot administrators. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=117149 Your paranoid android. === w7u_adm (testbot log) === WineRunTask.pl:error: BotError: The test VM is powered off! Did the test shut it down? === w1064v1809 (testbot log) === WineRunTask.pl:error: The previous 1 run(s) terminated abnormally === w10pro64_en_AE_u8 (64 bit report) === user32: msg.c:13238: Test failed: message time not advanced: 1537a 1537a msg.c:13239: Test failed: coords not changed: (101 101) (101 101) msg.c:13256: Test failed: message time not advanced: 1537a 1537a msg.c:13257: Test failed: coords not changed: (101 101) (101 101) === w10pro64_ar (testbot log) === WineRunTask.pl:error: BotError: The test VM is powered off! Did the test shut it down? === w10pro64_ja (testbot log) === WineRunTask.pl:error: BotError: The test VM is powered off! Did the test shut it down?

June 17, 2022

Re: [PATCH v2 0/1] MR229: comctl32: Always paint SS_BITMAP static control background with WM_CTLCOLORSTATIC brush. - approved

by Zhiyi Zhang (＠zhiyi)

This merge request was approved by Zhiyi Zhang. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/229

June 17, 2022

[PATCH v4 4/4] server: Don't invalidate the newly exposed child region on the parent if it doesn't clip children.

by Jinoh Kang

From: Jinoh Kang <jinoh.kang.kr(a)gmail.com> This partly reverts e42eaaaf3a873d29b14f8f3a3617df2d0d4210ca. Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> --- dlls/user32/tests/msg.c | 4 ---- server/window.c | 6 ++---- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c index 991f1c22076..551d1bea44f 100644 --- a/dlls/user32/tests/msg.c +++ b/dlls/user32/tests/msg.c @@ -9294,8 +9294,6 @@ static void subtest_swp_paint_regions_( int line, int wrap_toplevel, LPCSTR pare CombineRgn( hrgn_expect, hrgn_old_vis, hrgn_new_vis, RGN_DIFF ); rgn_equal = EqualRgn( hrgn_expect, hrgn_actual ); } - todo_wine_if( !EqualRect( &rect_old, &rect_new ) && - (extest->style & WS_CLIPCHILDREN) == 0 && !is_composited ) ok( !!rgn_equal, "Parent update region shall match expected region\n" ); if (!rgn_equal && winetest_debug > 0) @@ -9353,8 +9351,6 @@ static void subtest_swp_paint_regions_( int line, int wrap_toplevel, LPCSTR pare CombineRgn( hrgn_expect_child, hrgn_new_vis_child, hrgn_old_vis_child, RGN_DIFF ); rgn_equal = EqualRgn( hrgn_expect, hrgn_actual ); } - todo_wine_if( !EqualRect( &rect_old, &rect_new ) && - (extest->style & WS_CLIPCHILDREN) == 0 && !is_composited ) ok( !!rgn_equal, "Child update region shall match expected region\n" ); if (!rgn_equal && winetest_debug > 0) diff --git a/server/window.c b/server/window.c index 7e418b7b3fa..464967084c2 100644 --- a/server/window.c +++ b/server/window.c @@ -1754,10 +1754,8 @@ static struct region *expose_window( struct window *win, const rectangle_t *old_ offset_region( new_vis_rgn, win->window_rect.left - old_window_rect->left, win->window_rect.top - old_window_rect->top ); - if (is_composited ? union_region( new_vis_rgn, old_vis_rgn, new_vis_rgn ) : - (win->parent->style & WS_CLIPCHILDREN) ? - subtract_region( new_vis_rgn, old_vis_rgn, new_vis_rgn ) : - xor_region( new_vis_rgn, old_vis_rgn, new_vis_rgn )) + if (is_composited ? union_region( new_vis_rgn, old_vis_rgn, new_vis_rgn ) + : subtract_region( new_vis_rgn, old_vis_rgn, new_vis_rgn )) { if (!is_region_empty( new_vis_rgn )) { -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/231

June 17, 2022

[PATCH v4 3/4] server: Redraw composited window child when its z-order changes.

by Jinoh Kang

From: Jinoh Kang <jinoh.kang.kr(a)gmail.com> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53153 Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> --- dlls/user32/tests/msg.c | 8 ++++---- server/window.c | 18 ++++++++++++------ 2 files changed, 16 insertions(+), 10 deletions(-) diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c index 317dd9e48dc..991f1c22076 100644 --- a/dlls/user32/tests/msg.c +++ b/dlls/user32/tests/msg.c @@ -9294,8 +9294,8 @@ static void subtest_swp_paint_regions_( int line, int wrap_toplevel, LPCSTR pare CombineRgn( hrgn_expect, hrgn_old_vis, hrgn_new_vis, RGN_DIFF ); rgn_equal = EqualRgn( hrgn_expect, hrgn_actual ); } - todo_wine_if( EqualRect( &rect_old, &rect_new ) ? is_zorder_redraw : - ((extest->style & WS_CLIPCHILDREN) == 0 && !is_composited) ) + todo_wine_if( !EqualRect( &rect_old, &rect_new ) && + (extest->style & WS_CLIPCHILDREN) == 0 && !is_composited ) ok( !!rgn_equal, "Parent update region shall match expected region\n" ); if (!rgn_equal && winetest_debug > 0) @@ -9353,8 +9353,8 @@ static void subtest_swp_paint_regions_( int line, int wrap_toplevel, LPCSTR pare CombineRgn( hrgn_expect_child, hrgn_new_vis_child, hrgn_old_vis_child, RGN_DIFF ); rgn_equal = EqualRgn( hrgn_expect, hrgn_actual ); } - todo_wine_if( EqualRect( &rect_old, &rect_new ) ? is_zorder_redraw : - ((extest->style & WS_CLIPCHILDREN) == 0 && !is_composited) ) + todo_wine_if( !EqualRect( &rect_old, &rect_new ) && + (extest->style & WS_CLIPCHILDREN) == 0 && !is_composited ) ok( !!rgn_equal, "Child update region shall match expected region\n" ); if (!rgn_equal && winetest_debug > 0) diff --git a/server/window.c b/server/window.c index 6fc9f9f9e40..7e418b7b3fa 100644 --- a/server/window.c +++ b/server/window.c @@ -1719,12 +1719,12 @@ static unsigned int get_window_update_flags( struct window *win, struct window * /* expose the areas revealed by a vis region change on the window parent */ /* returns the region exposed on the window itself (in client coordinates) */ static struct region *expose_window( struct window *win, const rectangle_t *old_window_rect, - struct region *old_vis_rgn ) + struct region *old_vis_rgn, int zorder_changed ) { struct region *new_vis_rgn, *exposed_rgn; int is_composited = win->parent && is_window_composited( win->parent ); - if (is_rect_equal( &win->window_rect, old_window_rect )) + if (is_rect_equal( &win->window_rect, old_window_rect ) && !(is_composited && zorder_changed)) { return NULL; } @@ -1785,6 +1785,7 @@ static void set_window_pos( struct window *win, struct window *previous, rectangle_t rect; int client_changed, frame_changed; int visible = (win->style & WS_VISIBLE) || (swp_flags & SWP_SHOWWINDOW); + int zorder_changed = 0; if (win->parent && !is_visible( win->parent )) visible = 0; @@ -1796,7 +1797,12 @@ static void set_window_pos( struct window *win, struct window *previous, win->visible_rect = *visible_rect; win->surface_rect = *surface_rect; win->client_rect = *client_rect; - if (!(swp_flags & SWP_NOZORDER) && win->parent) link_window( win, previous ); + if (!(swp_flags & SWP_NOZORDER) && win->parent) + { + struct list *old_prev = win->is_linked ? win->entry.prev : NULL; + link_window( win, previous ); + if (old_prev != win->entry.prev) zorder_changed = 1; + } if (swp_flags & SWP_SHOWWINDOW) win->style |= WS_VISIBLE; else if (swp_flags & SWP_HIDEWINDOW) win->style &= ~WS_VISIBLE; @@ -1825,7 +1831,7 @@ static void set_window_pos( struct window *win, struct window *previous, /* expose anything revealed by the change */ if (!(swp_flags & SWP_NOREDRAW)) - exposed_rgn = expose_window( win, &old_window_rect, old_vis_rgn ); + exposed_rgn = expose_window( win, &old_window_rect, old_vis_rgn, zorder_changed ); if (!(win->style & WS_VISIBLE)) { @@ -1956,7 +1962,7 @@ static void set_window_region( struct window *win, struct region *region, int re win->win_region = region; /* expose anything revealed by the change */ - if (old_vis_rgn && ((exposed_rgn = expose_window( win, &win->window_rect, old_vis_rgn )))) + if (old_vis_rgn && ((exposed_rgn = expose_window( win, &win->window_rect, old_vis_rgn, 0 )))) { redraw_window( win, exposed_rgn, 1, RDW_INVALIDATE | RDW_ERASE | RDW_FRAME | RDW_ALLCHILDREN ); free_region( exposed_rgn ); @@ -1981,7 +1987,7 @@ void free_window_handle( struct window *win ) win->style &= ~WS_VISIBLE; if (vis_rgn) { - struct region *exposed_rgn = expose_window( win, &win->window_rect, vis_rgn ); + struct region *exposed_rgn = expose_window( win, &win->window_rect, vis_rgn, 0 ); if (exposed_rgn) free_region( exposed_rgn ); free_region( vis_rgn ); } -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/231

June 17, 2022

[PATCH v4 2/4] server: Correctly expose composited parent window and its child on position change.

by Jinoh Kang

From: Jinoh Kang <jinoh.kang.kr(a)gmail.com> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53153 Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> --- dlls/user32/tests/msg.c | 4 ++-- server/class.c | 5 +++++ server/user.h | 8 ++++++++ server/window.c | 23 +++++++++++++++++++++-- 4 files changed, 36 insertions(+), 4 deletions(-) diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c index c62b25446a2..317dd9e48dc 100644 --- a/dlls/user32/tests/msg.c +++ b/dlls/user32/tests/msg.c @@ -9295,7 +9295,7 @@ static void subtest_swp_paint_regions_( int line, int wrap_toplevel, LPCSTR pare rgn_equal = EqualRgn( hrgn_expect, hrgn_actual ); } todo_wine_if( EqualRect( &rect_old, &rect_new ) ? is_zorder_redraw : - ((extest->style & WS_CLIPCHILDREN) == 0 || is_composited) ) + ((extest->style & WS_CLIPCHILDREN) == 0 && !is_composited) ) ok( !!rgn_equal, "Parent update region shall match expected region\n" ); if (!rgn_equal && winetest_debug > 0) @@ -9354,7 +9354,7 @@ static void subtest_swp_paint_regions_( int line, int wrap_toplevel, LPCSTR pare rgn_equal = EqualRgn( hrgn_expect, hrgn_actual ); } todo_wine_if( EqualRect( &rect_old, &rect_new ) ? is_zorder_redraw : - ((extest->style & WS_CLIPCHILDREN) == 0 || is_composited) ) + ((extest->style & WS_CLIPCHILDREN) == 0 && !is_composited) ) ok( !!rgn_equal, "Child update region shall match expected region\n" ); if (!rgn_equal && winetest_debug > 0) diff --git a/server/class.c b/server/class.c index e1e180bd97c..3231f366b26 100644 --- a/server/class.c +++ b/server/class.c @@ -141,6 +141,11 @@ int is_hwnd_message_class( struct window_class *class ) return (!class->local && class->atom == find_global_atom( NULL, &name )); } +int get_class_style( struct window_class *class ) +{ + return class->style; +} + atom_t get_class_atom( struct window_class *class ) { return class->base_atom; diff --git a/server/user.h b/server/user.h index 55a0d35feff..9e91d427a3a 100644 --- a/server/user.h +++ b/server/user.h @@ -175,6 +175,7 @@ extern struct window_class *grab_class( struct process *process, atom_t atom, extern void release_class( struct window_class *class ); extern int is_desktop_class( struct window_class *class ); extern int is_hwnd_message_class( struct window_class *class ); +extern int get_class_style( struct window_class *class ); extern atom_t get_class_atom( struct window_class *class ); extern client_ptr_t get_class_client_ptr( struct window_class *class ); @@ -191,6 +192,13 @@ extern void close_process_desktop( struct process *process ); extern void set_thread_default_desktop( struct thread *thread, struct desktop *desktop, obj_handle_t handle ); extern void release_thread_desktop( struct thread *thread, int close ); +/* checks if two rectangles are identical */ +static inline int is_rect_equal( const rectangle_t *rect1, const rectangle_t *rect2 ) +{ + return (rect1->left == rect2->left && rect1->right == rect2->right && + rect1->top == rect2->top && rect1->bottom == rect2->bottom); +} + static inline int is_rect_empty( const rectangle_t *rect ) { return (rect->left >= rect->right || rect->top >= rect->bottom); diff --git a/server/window.c b/server/window.c index 7675cd1103d..6fc9f9f9e40 100644 --- a/server/window.c +++ b/server/window.c @@ -789,6 +789,16 @@ int is_window_transparent( user_handle_t window ) return (win->ex_style & (WS_EX_LAYERED|WS_EX_TRANSPARENT)) == (WS_EX_LAYERED|WS_EX_TRANSPARENT); } +static int is_window_using_parent_dc( struct window *win ) +{ + return (win->style & (WS_POPUP|WS_CHILD)) == WS_CHILD && (get_class_style( win->class ) & CS_PARENTDC) != 0; +} + +static int is_window_composited( struct window *win ) +{ + return (win->ex_style & WS_EX_COMPOSITED) != 0 && !is_window_using_parent_dc(win); +} + /* check if point is inside the window, and map to window dpi */ static int is_point_in_window( struct window *win, int *x, int *y, unsigned int dpi ) { @@ -1712,12 +1722,20 @@ static struct region *expose_window( struct window *win, const rectangle_t *old_ struct region *old_vis_rgn ) { struct region *new_vis_rgn, *exposed_rgn; + int is_composited = win->parent && is_window_composited( win->parent ); + + if (is_rect_equal( &win->window_rect, old_window_rect )) + { + return NULL; + } if (!(new_vis_rgn = get_visible_region( win, DCX_WINDOW ))) return NULL; if ((exposed_rgn = create_empty_region())) { - if (subtract_region( exposed_rgn, new_vis_rgn, old_vis_rgn ) && !is_region_empty( exposed_rgn )) + if ((is_composited ? union_region( exposed_rgn, new_vis_rgn, old_vis_rgn ) + : subtract_region( exposed_rgn, new_vis_rgn, old_vis_rgn )) && + !is_region_empty( exposed_rgn )) { /* make it relative to the new client area */ offset_region( exposed_rgn, win->window_rect.left - win->client_rect.left, @@ -1736,7 +1754,8 @@ static struct region *expose_window( struct window *win, const rectangle_t *old_ offset_region( new_vis_rgn, win->window_rect.left - old_window_rect->left, win->window_rect.top - old_window_rect->top ); - if ((win->parent->style & WS_CLIPCHILDREN) ? + if (is_composited ? union_region( new_vis_rgn, old_vis_rgn, new_vis_rgn ) : + (win->parent->style & WS_CLIPCHILDREN) ? subtract_region( new_vis_rgn, old_vis_rgn, new_vis_rgn ) : xor_region( new_vis_rgn, old_vis_rgn, new_vis_rgn )) { -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/231

June 17, 2022