June 2022 - Wine-Devel - list.winehq.org

Re: [PATCH v4 0/6] MR73: Improvement in PDB's types record handling - closed

by eric pouech (＠epo)

This merge request was closed by eric pouech. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/73

June 16, 2022

Re: [PATCH 0/3] MR224: Fix GCC12 warnings - closed

by eric pouech (＠epo)

This merge request was closed by eric pouech. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/224

June 16, 2022

Re: Wiki guidance on taking function prototypes from ReactOS

by Bernhard Kölbl

I'd even go so far as to explicitly note, that ReactOS uses reverse engineered code and thus is *not* a valid source for Wine and also shouldn't be looked at for any implementation. -- Bernhard Alex Henrie <alexhenrie24(a)gmail.com> schrieb am Do., 16. Juni 2022, 05:35: > Yesterday I came across a bug report [1] with an attached patch to > stub out the function RtlGetFullPathName_UEx, which is not documented > by Microsoft, based on its prototype in ReactOS. Alexandre left the > comment: [2] > > "You should not look at ReactOS code at all, a lot of it is > reverse-engineered using methods that are not appropriate for Wine. > It's not a usable source of information for us." > > The patch author, Ben, replied: [3] > > "I just want the WIKI to be MUCH more definitive/precise on what IS > and IS NOT allowed." > > I took a look and as it currently stands, the wiki clearly encourages > collaboration with ReactOS in at least one place: [4] > > "If you're still resisting the switch to unix for some reason though, > you may have some luck investigating ReactOS (they cooperate with us > on API issues too)." > > And it clearly discourages collaboration with ReactOS in at least one > place: [5] > > "it appears that all such documentation is derived from ReactOS, which > is not considered a legally safe source for use in Wine." > > Mention of ReactOS is conspicuously absent from the page that outlines > Wine's "clean room" guidelines. [6] > > Since Alexandre says that Wine developers shouldn't look at ReactOS > code at all, I think we should remove from the wiki all references > that might be construed to encourage it and add some more that > discourage it. Does anyone have any further thoughts before I start > editing? > > -Alex > > [1] https://bugs.winehq.org/show_bug.cgi?id=50464 > [2] https://bugs.winehq.org/show_bug.cgi?id=50464#c6 > [3] https://bugs.winehq.org/show_bug.cgi?id=50464#c7 > [4] https://wiki.winehq.org/Cygwin_and_More > [5] https://wiki.winehq.org/AFD > [6] https://wiki.winehq.org/Clean_Room_Guidelines > >

June 16, 2022

[PATCH 5/5] d3dx10/tests: Add D3DX10CreateTextureFromMemory thread pump tests.

by Piotr Caban

From: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/d3dx10_43/tests/d3dx10.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/dlls/d3dx10_43/tests/d3dx10.c b/dlls/d3dx10_43/tests/d3dx10.c index d8839626c3b..1c28a62b700 100644 --- a/dlls/d3dx10_43/tests/d3dx10.c +++ b/dlls/d3dx10_43/tests/d3dx10.c @@ -848,7 +848,6 @@ static HRESULT WINAPI D3DX10ThreadPump_AddWorkItem(ID3DX10ThreadPump *iface, ID3 HRESULT hr; ok(!add_work_item_count++, "unexpected call\n"); - ok(!object, "object = %p\n", object); hr = ID3DX10DataLoader_Load(loader); ok(hr == S_OK, "Got unexpected hr %#x.\n", hr); @@ -2290,6 +2289,17 @@ static void test_create_texture(void) winetest_pop_context(); } + hr2 = 0xdeadbeef; + add_work_item_count = 0; + hr = D3DX10CreateTextureFromMemory(device, test_image[0].data, test_image[0].size, + NULL, &thread_pump, &resource, &hr2); + ok(add_work_item_count == 1, "Got unexpected add_work_item_count %u.\n", add_work_item_count); + ok(hr == S_OK, "Got unexpected hr %#x.\n", hr); + ok(hr == hr2, "Got unexpected hr2 %#x.\n", hr2); + check_resource_info(resource, test_image, __LINE__); + check_resource_data(resource, test_image, __LINE__); + ID3D10Resource_Release(resource); + /* D3DX10CreateTextureFromFile tests */ hr2 = 0xdeadbeef; -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/257

June 16, 2022

[PATCH 4/5] d3dx10: Add support for ID3DX10ThreadPump parameter in D3DX10CreateTextureFromMemory.

by Piotr Caban

From: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/d3dx10_43/texture.c | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/dlls/d3dx10_43/texture.c b/dlls/d3dx10_43/texture.c index a988df6f477..88efdf585b4 100644 --- a/dlls/d3dx10_43/texture.c +++ b/dlls/d3dx10_43/texture.c @@ -966,8 +966,26 @@ HRESULT WINAPI D3DX10CreateTextureFromMemory(ID3D10Device *device, const void *s return E_INVALIDARG; if (!src_data) return E_FAIL; + if (pump) - FIXME("Thread pump is not supported yet.\n"); + { + ID3DX10DataProcessor *processor; + ID3DX10DataLoader *loader; + + if (FAILED((hr = D3DX10CreateAsyncMemoryLoader(src_data, src_data_size, &loader)))) + return hr; + if (FAILED((hr = D3DX10CreateAsyncTextureProcessor(device, load_info, &processor)))) + { + ID3DX10DataLoader_Destroy(loader); + return hr; + } + if (FAILED((hr = ID3DX10ThreadPump_AddWorkItem(pump, loader, processor, hresult, (void **)texture)))) + { + ID3DX10DataLoader_Destroy(loader); + ID3DX10DataProcessor_Destroy(processor); + } + return hr; + } hr = create_texture(device, src_data, src_data_size, load_info, texture); if (hresult) -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/257

June 16, 2022

[PATCH 3/5] d3dx10: Add support for ID3DX10ThreadPump parameter in D3DX10CreateTextureFromResourceW.

by Piotr Caban

From: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/d3dx10_43/texture.c | 27 ++++++++++++++++++++++++--- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/dlls/d3dx10_43/texture.c b/dlls/d3dx10_43/texture.c index 7a4031727fa..a988df6f477 100644 --- a/dlls/d3dx10_43/texture.c +++ b/dlls/d3dx10_43/texture.c @@ -715,11 +715,32 @@ HRESULT WINAPI D3DX10CreateTextureFromResourceW(ID3D10Device *device, HMODULE mo if (!device) return E_INVALIDARG; - hr = load_resourceW(module, resource, &buffer, &size); - if (FAILED(hr)) + if (pump) + { + ID3DX10DataProcessor *processor; + ID3DX10DataLoader *loader; + + if (FAILED((hr = D3DX10CreateAsyncResourceLoaderW(module, resource, &loader)))) + return hr; + if (FAILED((hr = D3DX10CreateAsyncTextureProcessor(device, load_info, &processor)))) + { + ID3DX10DataLoader_Destroy(loader); + return hr; + } + if (FAILED((hr = ID3DX10ThreadPump_AddWorkItem(pump, loader, processor, hresult, (void **)texture)))) + { + ID3DX10DataLoader_Destroy(loader); + ID3DX10DataProcessor_Destroy(processor); + } return hr; + } - return D3DX10CreateTextureFromMemory(device, buffer, size, load_info, pump, texture, hresult); + if (FAILED((hr = load_resourceW(module, resource, &buffer, &size)))) + return hr; + hr = create_texture(device, buffer, size, load_info, texture); + if (hresult) + *hresult = hr; + return hr; } void init_load_info(const D3DX10_IMAGE_LOAD_INFO *load_info, D3DX10_IMAGE_LOAD_INFO *out) -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/257

June 16, 2022

[PATCH 2/5] d3dx10: Add support for ID3DX10ThreadPump parameter in D3DX10CreateTextureFromResourceA.

by Piotr Caban

From: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/d3dx10_43/texture.c | 27 ++++++++++++++++++++++++--- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/dlls/d3dx10_43/texture.c b/dlls/d3dx10_43/texture.c index 31775fd6863..7a4031727fa 100644 --- a/dlls/d3dx10_43/texture.c +++ b/dlls/d3dx10_43/texture.c @@ -674,11 +674,32 @@ HRESULT WINAPI D3DX10CreateTextureFromResourceA(ID3D10Device *device, HMODULE mo if (!device) return E_INVALIDARG; - hr = load_resourceA(module, resource, &buffer, &size); - if (FAILED(hr)) + if (pump) + { + ID3DX10DataProcessor *processor; + ID3DX10DataLoader *loader; + + if (FAILED((hr = D3DX10CreateAsyncResourceLoaderA(module, resource, &loader)))) + return hr; + if (FAILED((hr = D3DX10CreateAsyncTextureProcessor(device, load_info, &processor)))) + { + ID3DX10DataLoader_Destroy(loader); + return hr; + } + if (FAILED((hr = ID3DX10ThreadPump_AddWorkItem(pump, loader, processor, hresult, (void **)texture)))) + { + ID3DX10DataLoader_Destroy(loader); + ID3DX10DataProcessor_Destroy(processor); + } return hr; + } - return D3DX10CreateTextureFromMemory(device, buffer, size, load_info, pump, texture, hresult); + if (FAILED((hr = load_resourceA(module, resource, &buffer, &size)))) + return hr; + hr = create_texture(device, buffer, size, load_info, texture); + if (hresult) + *hresult = hr; + return hr; } HRESULT WINAPI D3DX10CreateTextureFromResourceW(ID3D10Device *device, HMODULE module, const WCHAR *resource, -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/257

June 16, 2022

[PATCH 1/5] d3dx10: Add support for ID3DX10ThreadPump parameter in D3DX10CreateTextureFromFileW.

by Piotr Caban

From: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/d3dx10_43/texture.c | 30 +++++++++++++++++++++++------- 1 file changed, 23 insertions(+), 7 deletions(-) diff --git a/dlls/d3dx10_43/texture.c b/dlls/d3dx10_43/texture.c index 7a43d8409da..31775fd6863 100644 --- a/dlls/d3dx10_43/texture.c +++ b/dlls/d3dx10_43/texture.c @@ -631,17 +631,33 @@ HRESULT WINAPI D3DX10CreateTextureFromFileW(ID3D10Device *device, const WCHAR *s if (!src_file) return E_FAIL; - if (FAILED((hr = load_file(src_file, &buffer, &size)))) + if (pump) { - if (hresult) - *hresult = hr; + ID3DX10DataProcessor *processor; + ID3DX10DataLoader *loader; + + if (FAILED((hr = D3DX10CreateAsyncFileLoaderW(src_file, &loader)))) + return hr; + if (FAILED((hr = D3DX10CreateAsyncTextureProcessor(device, load_info, &processor)))) + { + ID3DX10DataLoader_Destroy(loader); + return hr; + } + if (FAILED((hr = ID3DX10ThreadPump_AddWorkItem(pump, loader, processor, hresult, (void **)texture)))) + { + ID3DX10DataLoader_Destroy(loader); + ID3DX10DataProcessor_Destroy(processor); + } return hr; } - hr = D3DX10CreateTextureFromMemory(device, buffer, size, load_info, pump, texture, hresult); - - free(buffer); - + if (SUCCEEDED((hr = load_file(src_file, &buffer, &size)))) + { + hr = create_texture(device, buffer, size, load_info, texture); + free(buffer); + } + if (hresult) + *hresult = hr; return hr; } -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/257

June 16, 2022

[PATCH 0/5] MR257: d3dx: Add support for ID3DX10ThreadPump parameter in D3DX10CreateTexture* functions

by Piotr Caban (＠piotr)

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/257

June 16, 2022

Re: [PATCH 1/1] ntdll: Do not open directory file when setting the same directory path.

by Dmitry Timoshkov

Paul Gofman <wine(a)gitlab.winehq.org> wrote: > + if (curdir->DosPath.Length == (compare_size + 1) * sizeof(WCHAR) > + && !memcmp( curdir->DosPath.Buffer, ptr, compare_size * sizeof(WCHAR) )) > + { > + TRACE( "dir %s is the same as current.\n", debugstr_us(dir) ); > + nts = STATUS_SUCCESS; > + goto out; > + } Comparison probably should be case insensitive. -- Dmitry.

June 16, 2022