June 2022 - Wine-Devel - list.winehq.org

[PATCH v2 0/3] MR187: ntdll/tests: Test if RtlFormatMessage modifies va_list on error.

by Daniel Lehman (＠dlehman25)

Signed-off-by: Daniel Lehman <dlehman25(a)gmail.com> -- v2: kernelbase: Pass va_list copy to internal RtlFormatMessage. kernel32/tests: Test if FormatMessage modifies va_list on error. ntdll/tests: Test if RtlFormatMessage modifies va_list on error. https://gitlab.winehq.org/wine/wine/-/merge_requests/187

June 13, 2022

Re: [PATCH v2 0/1] MR234: d2d1: Update to ID2D1DeviceContext1. - approved

by Alexandre Julliard (＠julliard)

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/234

June 13, 2022

Re: [PATCH v3 0/5] MR232: win32u: user32 conversion - approved

by Alexandre Julliard (＠julliard)

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/232

June 13, 2022

Re: [PATCH v2 0/3] MR230: UiaProviderFromIAccessible: Initial navigation patches. - approved

by Alexandre Julliard (＠julliard)

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/230

June 13, 2022

Re: [PATCH 0/1] MR238: ntdll: Move SEH exception info logs back to the seh channel. - approved

by Zebediah Figura (＠zfigura)

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/238

June 13, 2022

[PATCH 1/1] ntdll: Move SEH exception info logs back to the seh channel.

by Tim Clem

From: Tim Clem <tclem(a)codeweavers.com> These were accidentally moved as part of the introduction of +unwind. Signed-off-by: Tim Clem <tclem(a)codeweavers.com> --- dlls/ntdll/signal_x86_64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/ntdll/signal_x86_64.c b/dlls/ntdll/signal_x86_64.c index 7e77329363c..fef163ac629 100644 --- a/dlls/ntdll/signal_x86_64.c +++ b/dlls/ntdll/signal_x86_64.c @@ -510,7 +510,7 @@ NTSTATUS WINAPI dispatch_exception( EXCEPTION_RECORD *rec, CONTEXT *context ) rec->ExceptionCode, rec->ExceptionFlags, rec->ExceptionAddress, (void *)context->Rip, GetCurrentThreadId() ); for (c = 0; c < min( EXCEPTION_MAXIMUM_PARAMETERS, rec->NumberParameters ); c++) - TRACE( " info[%d]=%016I64x\n", c, rec->ExceptionInformation[c] ); + TRACE_(seh)( " info[%d]=%016I64x\n", c, rec->ExceptionInformation[c] ); if (rec->ExceptionCode == EXCEPTION_WINE_STUB) { -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/238

June 13, 2022

[PATCH 0/1] MR238: ntdll: Move SEH exception info logs back to the seh channel.

by Tim Clem (＠tclem)

These were accidentally moved as part of the introduction of +unwind. Signed-off-by: Tim Clem <tclem(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/238

June 13, 2022

Re: [PATCH v2 0/6] MR220: winegstreamer: Add zero-copy support to quartz_transform. - approved

by Zebediah Figura (＠zfigura)

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/220

June 13, 2022

Re: [PATCH v4 0/9] MR217: windows.media.speech: ISpeechSynthesisStream stub implementation.

by Rémi Bernon

Rémi Bernon (@rbernon) commented about dlls/windows.media.speech/tests/speech.c: > + > + IAsyncOperation_SpeechSynthesisStream_Release(operation_ss_stream); > + > + operation_ss_stream = (void *)0xdeadbeef; > + hr = ISpeechSynthesizer_SynthesizeSsmlToStreamAsync(synthesizer, NULL, &operation_ss_stream); > + /* Broken on Win 8 + 8.1 */ > + todo_wine ok(hr == S_OK || broken(hr == E_INVALIDARG), "ISpeechSynthesizer_SynthesizeSsmlToStreamAsync failed, hr %#lx\n", hr); > + todo_wine ok(!!operation_ss_stream || broken(operation_ss_stream == NULL), "operation_ss_stream had value %p.\n", operation_ss_stream); > + if (hr == S_OK) IAsyncOperation_SpeechSynthesisStream_Release(operation_ss_stream); > + > + operation_ss_stream = (void *)0xdeadbeef; > + hr = ISpeechSynthesizer_SynthesizeSsmlToStreamAsync(synthesizer, str, &operation_ss_stream); > + /* Broken on Win 8 + 8.1 */ > + todo_wine ok(hr == S_OK || broken(hr == SPERR_WINRT_INCORRECT_FORMAT), "ISpeechSynthesizer_SynthesizeSsmlToStreamAsync failed, hr %#lx\n", hr); > + todo_wine ok(!!operation_ss_stream || broken(operation_ss_stream == NULL), "operation_ss_stream had value %p.\n", operation_ss_stream); > + if (hr == S_OK) IAsyncOperation_SpeechSynthesisStream_Release(operation_ss_stream); Same here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/217#note_1975

June 13, 2022

Re: [PATCH v4 0/9] MR217: windows.media.speech: ISpeechSynthesisStream stub implementation.

by Rémi Bernon

Rémi Bernon (@rbernon) commented about dlls/windows.media.speech/tests/speech.c: > + { > + check_interface(ss_stream, &IID_ISpeechSynthesisStream, TRUE); > + check_interface(ss_stream, &IID_IAgileObject, TRUE); > + > + ref = ISpeechSynthesisStream_Release(ss_stream); > + ok(ref == 0, "Got unexpected ref %lu.\n", ref); > + } > + > + IAsyncOperation_SpeechSynthesisStream_Release(operation_ss_stream); > + > + operation_ss_stream = (void *)0xdeadbeef; > + hr = ISpeechSynthesizer_SynthesizeSsmlToStreamAsync(synthesizer, NULL, &operation_ss_stream); > + /* Broken on Win 8 + 8.1 */ > + todo_wine ok(hr == S_OK || broken(hr == E_INVALIDARG), "ISpeechSynthesizer_SynthesizeSsmlToStreamAsync failed, hr %#lx\n", hr); > + todo_wine ok(!!operation_ss_stream || broken(operation_ss_stream == NULL), "operation_ss_stream had value %p.\n", operation_ss_stream); > + if (hr == S_OK) IAsyncOperation_SpeechSynthesisStream_Release(operation_ss_stream); I think it'd be better with only the `hr` check marked as broken, and putting the second check inside a `if (hr == S_OK) ... else ...`. Otherwise with the two `broken` you can very well have `hr == S_OK` and `operation_ss_stream == NULL` passing the checks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/217#note_1974

June 13, 2022