June 2022 - Wine-Devel - list.winehq.org

Re: [PATCH 1/3]ntoskrnl.exe: Redeclare function _allshl and _allshr.

by Charles Davis

This change needs to be squashed into patch 2. -- Chip

June 10, 2022

Re: [PATCH 7/7] winegstreamer: Remove copying support from wg_transform_push_data.

by Zebediah Figura

On 6/10/22 02:53, Rémi Bernon wrote: > @@ -323,7 +324,11 @@ HRESULT wg_transform_push_data(struct wg_transform *transform, struct wg_sample > > TRACE("transform %p, sample %p.\n", transform, sample); > > - if ((status = __wine_unix_call(unix_handle, unix_wg_transform_push_data, &params))) > + wg_sample_queue_begin_append(queue, sample); > + status = __wine_unix_call(unix_handle, unix_wg_transform_push_data, &params); > + wg_sample_queue_end_append(queue, sample); > + > + if (status) > return HRESULT_FROM_NT(status); > > return params.result; I don't hate this, but it makes me nervous, since the intent of the helpers was to provide a 1:1 interface to the unix code (modulo types), and this breaks that assumption.

June 10, 2022

Re: [PATCH 4/7] winegstreamer: Introduce new wg_sample_create_qz helper for quartz_transform.c.

by Zebediah Figura

On 6/10/22 02:53, Rémi Bernon wrote: > enum wg_sample_type > { > WG_SAMPLE_TYPE_MF = 1, > + WG_SAMPLE_TYPE_QZ = 2, > } type; Obvious bikeshedding, but hopefully not controversial—would you please replace this with "quartz", here and elsewhere?

June 10, 2022

Re: [PATCH 3/7] winegstreamer: Use a union in struct sample to keep API pointers.

by Zebediah Figura

On 6/10/22 02:53, Rémi Bernon wrote: > + switch (sample->type) > + { > + case WG_SAMPLE_TYPE_MF: > + TRACE("wg_sample %p\n", wg_sample); > + > + IMFMediaBuffer_Unlock(sample->u.mf.buffer); > + IMFMediaBuffer_Release(sample->u.mf.buffer); > + IMFSample_Release(sample->u.mf.sample); > + break; > + > + default: > + FIXME("Unknown wg_sample %p, type %u\n", wg_sample, sample->type); > + break; > + } Have you considered using a destruction callback instead (especially since it'd just be the one callback?) I haven't tried it, so maybe it ends up being less pretty, but it'd at least make it easier to avoid mixing multiple frontends in the same file.

June 10, 2022