June 2022 - Wine-Devel - list.winehq.org

Re: [PATCH vkd3d v5 04/14] tests/shader_runner: Create the render pass and framebuffer in vulkan_runner_draw().

by Giovanni Mascellani

Signed-off-by: Giovanni Mascellani <gmascellani(a)codeweavers.com> Il 07/06/22 23:29, Zebediah Figura ha scritto: > Prepare to allow for dynamically changing the bound attachments in consecutive > draw calls. > > Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> > --- > v5: New patch. > > tests/shader_runner_vulkan.c | 99 +++++++++++++++++++----------------- > 1 file changed, 53 insertions(+), 46 deletions(-) > > diff --git a/tests/shader_runner_vulkan.c b/tests/shader_runner_vulkan.c > index f5a0e7ec3..d62792d65 100644 > --- a/tests/shader_runner_vulkan.c > +++ b/tests/shader_runner_vulkan.c > @@ -58,13 +58,11 @@ struct vulkan_shader_runner > VkQueue queue; > VkCommandPool command_pool; > VkCommandBuffer cmd_buffer; > - VkRenderPass render_pass; > VkDescriptorPool descriptor_pool; > > VkImage render_target; > VkDeviceMemory rt_memory; > VkImageView rtv; > - VkFramebuffer fb; > > struct vulkan_sampler > { > @@ -504,7 +502,7 @@ static VkPipelineLayout create_pipeline_layout(const struct vulkan_shader_runner > return pipeline_layout; > } > > -static VkPipeline create_pipeline(const struct vulkan_shader_runner *runner, > +static VkPipeline create_pipeline(const struct vulkan_shader_runner *runner, VkRenderPass render_pass, > VkPipelineLayout pipeline_layout, D3D_PRIMITIVE_TOPOLOGY primitive_topology) > { > VkPipelineInputAssemblyStateCreateInfo ia_desc = {.sType = VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO}; > @@ -620,7 +618,7 @@ static VkPipeline create_pipeline(const struct vulkan_shader_runner *runner, > pipeline_desc.pMultisampleState = &ms_desc; > pipeline_desc.pColorBlendState = &blend_desc; > pipeline_desc.layout = pipeline_layout; > - pipeline_desc.renderPass = runner->render_pass; > + pipeline_desc.renderPass = render_pass; > pipeline_desc.subpass = 0; > > VK_CALL(vkCreateGraphicsPipelines(runner->device, VK_NULL_HANDLE, 1, &pipeline_desc, NULL, &pipeline)); > @@ -782,6 +780,48 @@ static void bind_resources(struct vulkan_shader_runner *runner, VkPipelineBindPo > /* The descriptor set will be freed by resetting the descriptor pool. */ > } > > +static void create_render_pass_and_framebuffer(struct vulkan_shader_runner *runner, > + VkRenderPass *render_pass, VkFramebuffer *fb) > +{ > + VkRenderPassCreateInfo render_pass_desc = {.sType = VK_STRUCTURE_TYPE_RENDER_PASS_CREATE_INFO}; > + VkFramebufferCreateInfo fb_desc = {.sType = VK_STRUCTURE_TYPE_FRAMEBUFFER_CREATE_INFO}; > + VkAttachmentDescription attachment_desc = {0}; > + VkSubpassDescription subpass_desc = {0}; > + VkAttachmentReference color_ref = {0}; > + > + attachment_desc.format = VK_FORMAT_R32G32B32A32_SFLOAT; > + attachment_desc.samples = VK_SAMPLE_COUNT_1_BIT; > + attachment_desc.loadOp = VK_ATTACHMENT_LOAD_OP_LOAD; > + attachment_desc.storeOp = VK_ATTACHMENT_STORE_OP_STORE; > + attachment_desc.stencilLoadOp = VK_ATTACHMENT_LOAD_OP_DONT_CARE; > + attachment_desc.stencilStoreOp = VK_ATTACHMENT_STORE_OP_DONT_CARE; > + attachment_desc.initialLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; > + attachment_desc.finalLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; > + > + color_ref.attachment = 0; > + color_ref.layout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; > + > + subpass_desc.pipelineBindPoint = VK_PIPELINE_BIND_POINT_GRAPHICS; > + subpass_desc.colorAttachmentCount = 1; > + subpass_desc.pColorAttachments = &color_ref; > + > + render_pass_desc.attachmentCount = 1; > + render_pass_desc.pAttachments = &attachment_desc; > + render_pass_desc.subpassCount = 1; > + render_pass_desc.pSubpasses = &subpass_desc; > + > + VK_CALL(vkCreateRenderPass(runner->device, &render_pass_desc, NULL, render_pass)); > + > + fb_desc.renderPass = *render_pass; > + fb_desc.attachmentCount = 1; > + fb_desc.pAttachments = &runner->rtv; > + fb_desc.width = RENDER_TARGET_WIDTH; > + fb_desc.height = RENDER_TARGET_HEIGHT; > + fb_desc.layers = 1; > + > + VK_CALL(vkCreateFramebuffer(runner->device, &fb_desc, NULL, fb)); > +} > + > static bool vulkan_runner_draw(struct shader_runner *r, > D3D_PRIMITIVE_TOPOLOGY primitive_topology, unsigned int vertex_count) > { > @@ -794,16 +834,20 @@ static bool vulkan_runner_draw(struct shader_runner *r, > VkDescriptorSetLayout set_layout; > VkPipelineLayout pipeline_layout; > VkDevice device = runner->device; > + VkRenderPass render_pass; > VkClearRect clear_rect; > VkPipeline pipeline; > + VkFramebuffer fb; > bool ret = true; > unsigned int i; > > + create_render_pass_and_framebuffer(runner, &render_pass, &fb); > + > /* Create this before compiling shaders, it will assign resource bindings. */ > set_layout = create_descriptor_set_layout(runner); > > pipeline_layout = create_pipeline_layout(runner, set_layout); > - if (!(pipeline = create_pipeline(runner, pipeline_layout, primitive_topology))) > + if (!(pipeline = create_pipeline(runner, render_pass, pipeline_layout, primitive_topology))) > { > ret = false; > goto out; > @@ -811,8 +855,8 @@ static bool vulkan_runner_draw(struct shader_runner *r, > > begin_command_buffer(runner); > > - pass_begin_desc.renderPass = runner->render_pass; > - pass_begin_desc.framebuffer = runner->fb; > + pass_begin_desc.renderPass = render_pass; > + pass_begin_desc.framebuffer = fb; > pass_begin_desc.renderArea = rt_rect; > > VK_CALL(vkCmdBeginRenderPass(cmd_buffer, &pass_begin_desc, VK_SUBPASS_CONTENTS_INLINE)); > @@ -845,6 +889,8 @@ out: > > VK_CALL(vkDestroyPipelineLayout(device, pipeline_layout, NULL)); > VK_CALL(vkDestroyDescriptorSetLayout(device, set_layout, NULL)); > + VK_CALL(vkDestroyRenderPass(device, render_pass, NULL)); > + VK_CALL(vkDestroyFramebuffer(device, fb, NULL)); > > return ret; > } > @@ -985,17 +1031,12 @@ static bool init_vulkan_runner(struct vulkan_shader_runner *runner) > VkDescriptorPoolCreateInfo descriptor_pool_desc = {.sType = VK_STRUCTURE_TYPE_DESCRIPTOR_POOL_CREATE_INFO}; > VkCommandBufferAllocateInfo cmd_buffer_desc = {.sType = VK_STRUCTURE_TYPE_COMMAND_BUFFER_ALLOCATE_INFO}; > VkCommandPoolCreateInfo command_pool_desc = {.sType = VK_STRUCTURE_TYPE_COMMAND_POOL_CREATE_INFO}; > - VkRenderPassCreateInfo render_pass_desc = {.sType = VK_STRUCTURE_TYPE_RENDER_PASS_CREATE_INFO}; > VkDeviceQueueCreateInfo queue_desc = {.sType = VK_STRUCTURE_TYPE_DEVICE_QUEUE_CREATE_INFO}; > - VkFramebufferCreateInfo fb_desc = {.sType = VK_STRUCTURE_TYPE_FRAMEBUFFER_CREATE_INFO}; > VkInstanceCreateInfo instance_desc = {.sType = VK_STRUCTURE_TYPE_INSTANCE_CREATE_INFO}; > VkDeviceCreateInfo device_desc = {.sType = VK_STRUCTURE_TYPE_DEVICE_CREATE_INFO}; > VkPhysicalDeviceFeatures ret_features, features; > VkDescriptorPoolSize descriptor_pool_sizes[3]; > - VkAttachmentDescription attachment_desc = {0}; > static const float queue_priority = 1.0f; > - VkSubpassDescription subpass_desc = {0}; > - VkAttachmentReference color_ref = {0}; > VkFormatProperties format_props; > uint32_t count, graphics_index; > VkDevice device; > @@ -1100,43 +1141,11 @@ static bool init_vulkan_runner(struct vulkan_shader_runner *runner) > > VK_CALL(vkAllocateCommandBuffers(device, &cmd_buffer_desc, &runner->cmd_buffer)); > > - attachment_desc.format = VK_FORMAT_R32G32B32A32_SFLOAT; > - attachment_desc.samples = VK_SAMPLE_COUNT_1_BIT; > - attachment_desc.loadOp = VK_ATTACHMENT_LOAD_OP_LOAD; > - attachment_desc.storeOp = VK_ATTACHMENT_STORE_OP_STORE; > - attachment_desc.stencilLoadOp = VK_ATTACHMENT_LOAD_OP_DONT_CARE; > - attachment_desc.stencilStoreOp = VK_ATTACHMENT_STORE_OP_DONT_CARE; > - attachment_desc.initialLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; > - attachment_desc.finalLayout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; > - > - color_ref.attachment = 0; > - color_ref.layout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL; > - > - subpass_desc.pipelineBindPoint = VK_PIPELINE_BIND_POINT_GRAPHICS; > - subpass_desc.colorAttachmentCount = 1; > - subpass_desc.pColorAttachments = &color_ref; > - > - render_pass_desc.attachmentCount = 1; > - render_pass_desc.pAttachments = &attachment_desc; > - render_pass_desc.subpassCount = 1; > - render_pass_desc.pSubpasses = &subpass_desc; > - > - VK_CALL(vkCreateRenderPass(device, &render_pass_desc, NULL, &runner->render_pass)); > - > runner->render_target = create_2d_image(runner, RENDER_TARGET_WIDTH, RENDER_TARGET_HEIGHT, > VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_TRANSFER_SRC_BIT, > VK_FORMAT_R32G32B32A32_SFLOAT, &runner->rt_memory); > runner->rtv = create_2d_image_view(runner, runner->render_target, VK_FORMAT_R32G32B32A32_SFLOAT); > > - fb_desc.renderPass = runner->render_pass; > - fb_desc.attachmentCount = 1; > - fb_desc.pAttachments = &runner->rtv; > - fb_desc.width = RENDER_TARGET_WIDTH; > - fb_desc.height = RENDER_TARGET_HEIGHT; > - fb_desc.layers = 1; > - > - VK_CALL(vkCreateFramebuffer(device, &fb_desc, NULL, &runner->fb)); > - > descriptor_pool_sizes[0].type = VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE; > descriptor_pool_sizes[0].descriptorCount = MAX_RESOURCES; > descriptor_pool_sizes[1].type = VK_DESCRIPTOR_TYPE_SAMPLER; > @@ -1169,12 +1178,10 @@ static void cleanup_vulkan_runner(struct vulkan_shader_runner *runner) > VkDevice device = runner->device; > > VK_CALL(vkFreeMemory(device, runner->rt_memory, NULL)); > - VK_CALL(vkDestroyFramebuffer(device, runner->fb, NULL)); > VK_CALL(vkDestroyImageView(device, runner->rtv, NULL)); > VK_CALL(vkDestroyImage(device, runner->render_target, NULL)); > > VK_CALL(vkDestroyDescriptorPool(device, runner->descriptor_pool, NULL)); > - VK_CALL(vkDestroyRenderPass(device, runner->render_pass, NULL)); > VK_CALL(vkFreeCommandBuffers(device, runner->command_pool, 1, &runner->cmd_buffer)); > VK_CALL(vkDestroyCommandPool(device, runner->command_pool, NULL)); > VK_CALL(vkDestroyDevice(device, NULL));

June 8, 2022

Re: [PATCH vkd3d v5 03/14] tests/shader_runner: Allow creating UAV resources.

by Giovanni Mascellani

Hi, Il 07/06/22 23:29, Zebediah Figura ha scritto: > + resource->resource = create_default_texture(device, params->width, params->height, > + params->format, D3D12_RESOURCE_FLAG_ALLOW_UNORDERED_ACCESS, D3D12_RESOURCE_STATE_COPY_DEST); > + resource_data.pData = params->data; > + resource_data.SlicePitch = resource_data.RowPitch = params->width * params->texel_size; > + upload_texture_data(resource->resource, &resource_data, 1, test_context->queue, test_context->list); > + reset_command_list(test_context->list, test_context->allocator); > + transition_resource_state(test_context->list, resource->resource, > + D3D12_RESOURCE_STATE_COPY_DEST, D3D12_RESOURCE_STATE_UNORDERED_ACCESS); > + // fixme zf: un-magic this > + ID3D12Device_CreateUnorderedAccessView(device, resource->resource, > + NULL, NULL, get_cpu_descriptor_handle(test_context, runner->heap, resource->r.slot + 32)); > + break; Is that intended, or should this have been un-magiced before submission? It feels magic indeed (though so far much of D3D12 and Vulkan feels somewhat magic to me)! Same thing for the Vulkan runner. Giovanni.

June 8, 2022

Re: [PATCH 0/3] MR206: windows.gaming.input: Implement stub IGamepad2 interface.

by Bernhard Kölbl

On Wed Jun 8 11:57:28 2022 +0000, Rémi Bernon wrote: > Well this missing interface caused Death Stranding to crash, and it > wasn't obvious that it was because of a missing iface since WARN > messages aren't printed by default in the logs. Using FIXME instead > would have made it obvious. Alright, I somehow had the impression, that WARNs are logged by default. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/206#note_1699

June 8, 2022

[PATCH] msvcrt: Avoid passing an invalid LCID to LCMapStringW.

by Akihiro Sagawa

Because it complains as follows on startup in Japanese locale: 002c:err:msvcrt:create_mbcinfo WideCharToMultiByte failed for cp 932, ret=0 (exp 196), error=122 This happens after commit c2a455a20d7b5124bab0086df75178d8c53f27ef. Signed-off-by: Akihiro Sagawa <sagawa.aki(a)gmail.com> --- dlls/msvcrt/mbcs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

June 8, 2022

Re: [PATCH 0/3] MR206: windows.gaming.input: Implement stub IGamepad2 interface.

by Rémi Bernon

On Wed Jun 8 11:52:19 2022 +0000, Bernhard Kölbl wrote: > I think warning on an unimplemented iface is actually a good thing, so > I'd be against this change. Well this missing interface caused Death Stranding to crash, and it wasn't obvious that it was because of a missing iface since WARN messages aren't printed by default in the logs. Using FIXME instead would have made it obvious. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/206#note_1698

June 8, 2022

Re: [PATCH 0/3] MR206: windows.gaming.input: Implement stub IGamepad2 interface.

by Bernhard Kölbl

Bernhard Kölbl (@besentv) commented about dlls/windows.gaming.input/async.c: > return S_OK; > } > > - WARN( "%s not implemented, returning E_NOINTERFACE.\n", debugstr_guid( iid ) ); I think warning on an unimplemented iface is actually a good thing, so I'd be against this change. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/206#note_1697

June 8, 2022

[PATCH 3/3] windows.gaming.input: Implement stub IGamepad2 interface.

by Rémi Bernon

From: Rémi Bernon <rbernon(a)codeweavers.com> Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> --- dlls/windows.gaming.input/gamepad.c | 30 +++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/dlls/windows.gaming.input/gamepad.c b/dlls/windows.gaming.input/gamepad.c index 5efc9f13ea8..112ec49a1d3 100644 --- a/dlls/windows.gaming.input/gamepad.c +++ b/dlls/windows.gaming.input/gamepad.c @@ -61,6 +61,7 @@ struct gamepad IGameControllerImpl IGameControllerImpl_iface; IGameControllerInputSink IGameControllerInputSink_iface; IGamepad IGamepad_iface; + IGamepad2 IGamepad2_iface; IGameController *IGameController_outer; LONG ref; @@ -99,6 +100,12 @@ static HRESULT WINAPI controller_QueryInterface( IGameControllerImpl *iface, REF return S_OK; } + if (IsEqualGUID( iid, &IID_IGamepad2 )) + { + IInspectable_AddRef( (*out = &impl->IGamepad2_iface) ); + return S_OK; + } + FIXME( "%s not implemented, returning E_NOINTERFACE.\n", debugstr_guid( iid ) ); *out = NULL; return E_NOINTERFACE; @@ -330,6 +337,28 @@ static const struct IGamepadVtbl gamepad_vtbl = gamepad_GetCurrentReading, }; +DEFINE_IINSPECTABLE_OUTER( gamepad2, IGamepad2, struct gamepad, IGameController_outer ) + +static HRESULT WINAPI gamepad2_GetButtonLabel( IGamepad2 *iface, GamepadButtons button, GameControllerButtonLabel *value ) +{ + FIXME( "iface %p, button %#x, value %p stub!\n", iface, button, value ); + *value = GameControllerButtonLabel_None; + return S_OK; +} + +static const struct IGamepad2Vtbl gamepad2_vtbl = +{ + gamepad2_QueryInterface, + gamepad2_AddRef, + gamepad2_Release, + /* IInspectable methods */ + gamepad2_GetIids, + gamepad2_GetRuntimeClassName, + gamepad2_GetTrustLevel, + /* IGamepad2 methods */ + gamepad2_GetButtonLabel, +}; + struct gamepad_statics { IActivationFactory IActivationFactory_iface; @@ -542,6 +571,7 @@ static HRESULT WINAPI controller_factory_CreateGameController( ICustomGameContro impl->IGameControllerImpl_iface.lpVtbl = &controller_vtbl; impl->IGameControllerInputSink_iface.lpVtbl = &input_sink_vtbl; impl->IGamepad_iface.lpVtbl = &gamepad_vtbl; + impl->IGamepad2_iface.lpVtbl = &gamepad2_vtbl; impl->ref = 1; TRACE( "created Gamepad %p\n", impl ); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/206

June 8, 2022

[PATCH 2/3] include: Add Windows.Gaming.Input.IGamepad2 interface declaration.

by Rémi Bernon

From: Rémi Bernon <rbernon(a)codeweavers.com> Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> --- include/windows.gaming.input.idl | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/include/windows.gaming.input.idl b/include/windows.gaming.input.idl index fdae3aa70b1..5fc5265247d 100644 --- a/include/windows.gaming.input.idl +++ b/include/windows.gaming.input.idl @@ -446,6 +446,19 @@ namespace Windows.Gaming.Input { HRESULT GetCurrentReading([out, retval] Windows.Gaming.Input.GamepadReading *value); } + [ + contract(Windows.Foundation.UniversalApiContract, 3.0), + exclusiveto(Windows.Gaming.Input.Gamepad), + uuid(3c1689bd-5915-4245-b0c0-c89fae0308ff) + ] + interface IGamepad2 : IInspectable + requires Windows.Gaming.Input.IGamepad, + Windows.Gaming.Input.IGameController + { + HRESULT GetButtonLabel([in] Windows.Gaming.Input.GamepadButtons button, + [out, retval] Windows.Gaming.Input.GameControllerButtonLabel *value); + } + [ contract(Windows.Foundation.UniversalApiContract, 3.0), exclusiveto(Windows.Gaming.Input.RacingWheel), -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/206

June 8, 2022

[PATCH 1/3] windows.gaming.input: Consistently use FIXME for E_NOINTERFACE messages.

by Rémi Bernon

From: Rémi Bernon <rbernon(a)codeweavers.com> Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> --- dlls/windows.gaming.input/async.c | 2 +- dlls/windows.gaming.input/controller.c | 2 +- dlls/windows.gaming.input/gamepad.c | 2 +- dlls/windows.gaming.input/racing_wheel.c | 2 +- dlls/windows.gaming.input/vector.c | 6 +++--- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/dlls/windows.gaming.input/async.c b/dlls/windows.gaming.input/async.c index 8483f301b83..c41abe96cd1 100644 --- a/dlls/windows.gaming.input/async.c +++ b/dlls/windows.gaming.input/async.c @@ -73,7 +73,7 @@ static HRESULT WINAPI async_impl_QueryInterface( IWineAsyncInfoImpl *iface, REFI return S_OK; } - WARN( "%s not implemented, returning E_NOINTERFACE.\n", debugstr_guid( iid ) ); + FIXME( "%s not implemented, returning E_NOINTERFACE.\n", debugstr_guid( iid ) ); *out = NULL; return E_NOINTERFACE; } diff --git a/dlls/windows.gaming.input/controller.c b/dlls/windows.gaming.input/controller.c index e372ea6c9bf..bd3d441c445 100644 --- a/dlls/windows.gaming.input/controller.c +++ b/dlls/windows.gaming.input/controller.c @@ -99,7 +99,7 @@ static HRESULT WINAPI controller_QueryInterface( IGameControllerImpl *iface, REF return S_OK; } - WARN( "%s not implemented, returning E_NOINTERFACE.\n", debugstr_guid( iid ) ); + FIXME( "%s not implemented, returning E_NOINTERFACE.\n", debugstr_guid( iid ) ); *out = NULL; return E_NOINTERFACE; } diff --git a/dlls/windows.gaming.input/gamepad.c b/dlls/windows.gaming.input/gamepad.c index 0c38fb5cd1a..5efc9f13ea8 100644 --- a/dlls/windows.gaming.input/gamepad.c +++ b/dlls/windows.gaming.input/gamepad.c @@ -99,7 +99,7 @@ static HRESULT WINAPI controller_QueryInterface( IGameControllerImpl *iface, REF return S_OK; } - WARN( "%s not implemented, returning E_NOINTERFACE.\n", debugstr_guid( iid ) ); + FIXME( "%s not implemented, returning E_NOINTERFACE.\n", debugstr_guid( iid ) ); *out = NULL; return E_NOINTERFACE; } diff --git a/dlls/windows.gaming.input/racing_wheel.c b/dlls/windows.gaming.input/racing_wheel.c index 4a494775dc2..d646ca26c03 100644 --- a/dlls/windows.gaming.input/racing_wheel.c +++ b/dlls/windows.gaming.input/racing_wheel.c @@ -99,7 +99,7 @@ static HRESULT WINAPI controller_QueryInterface( IGameControllerImpl *iface, REF return S_OK; } - WARN( "%s not implemented, returning E_NOINTERFACE.\n", debugstr_guid( iid ) ); + FIXME( "%s not implemented, returning E_NOINTERFACE.\n", debugstr_guid( iid ) ); *out = NULL; return E_NOINTERFACE; } diff --git a/dlls/windows.gaming.input/vector.c b/dlls/windows.gaming.input/vector.c index db1a9057682..8958b07c0f2 100644 --- a/dlls/windows.gaming.input/vector.c +++ b/dlls/windows.gaming.input/vector.c @@ -54,7 +54,7 @@ static HRESULT WINAPI iterator_QueryInterface( IIterator_IInspectable *iface, RE return S_OK; } - WARN( "%s not implemented, returning E_NOINTERFACE.\n", debugstr_guid( iid ) ); + FIXME( "%s not implemented, returning E_NOINTERFACE.\n", debugstr_guid( iid ) ); *out = NULL; return E_NOINTERFACE; } @@ -189,7 +189,7 @@ static HRESULT WINAPI vector_view_QueryInterface( IVectorView_IInspectable *ifac return S_OK; } - WARN( "%s not implemented, returning E_NOINTERFACE.\n", debugstr_guid( iid ) ); + FIXME( "%s not implemented, returning E_NOINTERFACE.\n", debugstr_guid( iid ) ); *out = NULL; return E_NOINTERFACE; } @@ -384,7 +384,7 @@ static HRESULT WINAPI vector_QueryInterface( IVector_IInspectable *iface, REFIID return S_OK; } - WARN( "%s not implemented, returning E_NOINTERFACE.\n", debugstr_guid( iid ) ); + FIXME( "%s not implemented, returning E_NOINTERFACE.\n", debugstr_guid( iid ) ); *out = NULL; return E_NOINTERFACE; } -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/206

June 8, 2022

[PATCH 0/3] MR206: windows.gaming.input: Implement stub IGamepad2 interface.

by Rémi Bernon

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/206

June 8, 2022