June 2022 - Wine-Devel - list.winehq.org

Re: [PATCH resend] comctl32: Add partial support for LVM_SETBKIMAGE.

by Dmitry Timoshkov

Hello, this patch is a resend, and it seems it gets missed. Can I get a review of this patch, please? -- Dmitry.

June 3, 2022

Re: [PATCH 0/11] MR177: winemac: PE conversion - approved

by Huw Davies (＠huw)

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/177

June 3, 2022

Re: [PATCH vkd3d v3 4/7] vkd3d-shader/hlsl: Lower matrix casts.

by Giovanni Mascellani

Hi, Il 03/06/22 07:03, Zebediah Figura ha scritto: > With this patch we're able to successfully generate IR for the tests > added in patch 1. Unfortunately, the IR is not quite valid. It generates > SM4_RT_OUTPUT registers that are not actually declared (neither in the > output signature nor with dcl_output instructions). This seems to > confuse the DXBC->SPIRV translator, generating the following message and > producing SPIR-V that does not consistently pass or fail tests: > > fixme:vkd3d_dxbc_compiler_get_register_info: Unrecognized register > (register 0x8, 4294967295). Yes, I am aware of this problem, but it's a different bug that is merely exposed by the fact that now code generation for the affected tests is not blocked by a matrix cast. I have a couple of patches that should fix the problem, but I am not completely sure they are correct and given that freeze is imminent I would like to have the matrix patches in before that. If what bothers you is that the test is flaky, then would it be ok for you if I just commented it until the register declaration logic is fixed? Giovanni.

June 3, 2022

Re: [PATCH v2 2/2] d2d1/tests: Test unregistering effect which has existing instance.

by Nikolay Sivov

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com>

June 3, 2022

Re: [PATCH v2 1/2] d2d1/tests: Test custom effect properties.

by Nikolay Sivov

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com>

June 3, 2022

Re: [PATCH vkd3d v3 4/7] vkd3d-shader/hlsl: Lower matrix casts.

by Zebediah Figura

On 6/2/22 09:06, Giovanni Mascellani wrote: > Signed-off-by: Giovanni Mascellani <gmascellani(a)codeweavers.com> > --- > I had to add a forward declaration for add_load(). I don't know if in > cases like that it is preferred to add a forward declaration (which adds > cruft) or move the definition backwards (which break the vague logical > order functions have). > --- > libs/vkd3d-shader/hlsl.y | 93 ++++++++++++++++++- > tests/hlsl-duplicate-modifiers.shader_test | 2 +- > tests/hlsl-initializer-matrix.shader_test | 2 +- > ...lsl-return-implicit-conversion.shader_test | 10 +- > tests/hlsl-shape.shader_test | 10 +- > tests/matrix-semantics.shader_test | 20 ++-- > 6 files changed, 111 insertions(+), 26 deletions(-) > With this patch we're able to successfully generate IR for the tests added in patch 1. Unfortunately, the IR is not quite valid. It generates SM4_RT_OUTPUT registers that are not actually declared (neither in the output signature nor with dcl_output instructions). This seems to confuse the DXBC->SPIRV translator, generating the following message and producing SPIR-V that does not consistently pass or fail tests: fixme:vkd3d_dxbc_compiler_get_register_info: Unrecognized register (register 0x8, 4294967295).

June 3, 2022

[PATCH] user32: Perform HID ioctls on the right file handle.

by Zebediah Figura

This fixes a regression from 8962ec5a83286488da6f839ceba3c39ad1cf00b3. Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> --- dlls/user32/rawinput.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/user32/rawinput.c b/dlls/user32/rawinput.c index 90ca074f2a4..4dc240b58b3 100644 --- a/dlls/user32/rawinput.c +++ b/dlls/user32/rawinput.c @@ -153,7 +153,7 @@ static struct device *add_device( HDEVINFO set, SP_DEVICE_INTERFACE_DATA *iface, switch (type) { case RIM_TYPEHID: - status = NtDeviceIoControlFile( device->file, NULL, NULL, NULL, &io, + status = NtDeviceIoControlFile( file, NULL, NULL, NULL, &io, IOCTL_HID_GET_COLLECTION_INFORMATION, NULL, 0, &hid_info, sizeof(hid_info) ); if (status) @@ -172,7 +172,7 @@ static struct device *add_device( HDEVINFO set, SP_DEVICE_INTERFACE_DATA *iface, goto fail; } - status = NtDeviceIoControlFile( device->file, NULL, NULL, NULL, &io, + status = NtDeviceIoControlFile( file, NULL, NULL, NULL, &io, IOCTL_HID_GET_COLLECTION_DESCRIPTOR, NULL, 0, preparsed, hid_info.DescriptorSize ); if (status) -- 2.35.1

June 3, 2022

Re: [PATCH 1/4] d3d10core/tests: Add a regression test for writing to the stencil buffer after clearing it.

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=116125 Your paranoid android. === w10pro64 (64 bit report) === d3d10core: d3d10core.c:4676: Test failed: Got unexpected query result 0x0000000000000000.

June 3, 2022

[PATCH 4/4] wined3d: Consider the depth write mask in depth_stencil_state_desc_writes_ds() only if depth testing is enabled.

by Zebediah Figura

Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> --- dlls/wined3d/state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/wined3d/state.c b/dlls/wined3d/state.c index a732182d6c5..ee3e083e812 100644 --- a/dlls/wined3d/state.c +++ b/dlls/wined3d/state.c @@ -155,7 +155,7 @@ static bool stencil_op_writes_ds(const struct wined3d_stencil_op_desc *desc) static bool depth_stencil_state_desc_writes_ds(const struct wined3d_depth_stencil_state_desc *desc) { - if (desc->depth_write) + if (desc->depth && desc->depth_write) return true; if (desc->stencil && desc->stencil_write_mask) -- 2.36.1

June 3, 2022

[PATCH 3/4] wined3d: Invalidate the depth/stencil view if the depth/stencil state may be written.

by Zebediah Figura

This allows menu items to be rendered in Snowrunner. Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> --- The mentioned graphical error is probably a regression caused by the recent clear patches, but I haven't verified that. dlls/wined3d/state.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/dlls/wined3d/state.c b/dlls/wined3d/state.c index 228b4901c00..a732182d6c5 100644 --- a/dlls/wined3d/state.c +++ b/dlls/wined3d/state.c @@ -146,9 +146,25 @@ void * CDECL wined3d_depth_stencil_state_get_parent(const struct wined3d_depth_s return state->parent; } +static bool stencil_op_writes_ds(const struct wined3d_stencil_op_desc *desc) +{ + return desc->fail_op != WINED3D_STENCIL_OP_KEEP + || desc->depth_fail_op != WINED3D_STENCIL_OP_KEEP + || desc->pass_op != WINED3D_STENCIL_OP_KEEP; +} + static bool depth_stencil_state_desc_writes_ds(const struct wined3d_depth_stencil_state_desc *desc) { - return desc->depth_write; + if (desc->depth_write) + return true; + + if (desc->stencil && desc->stencil_write_mask) + { + if (stencil_op_writes_ds(&desc->front) || stencil_op_writes_ds(&desc->back)) + return true; + } + + return false; } HRESULT CDECL wined3d_depth_stencil_state_create(struct wined3d_device *device, -- 2.36.1

June 3, 2022