June 2022 - Wine-Devel - list.winehq.org

Re: [PATCH 0/2] MR89: Use +threadname channel for thread names.

by Alexandre Julliard (＠julliard)

Alexandre Julliard (@julliard) commented about dlls/kernelbase/thread.c: > THREAD_NAME_INFORMATION info; > int length; > > - TRACE( "(%p, %s)\n", thread, debugstr_w( description )); > + if (thread == GetCurrentThread()) > + WARN_(threadname)( "Thread renamed to %s\n", debugstr_w( description )); > + else > + WARN_(threadname)( "Thread handle %p renamed to %s\n", thread, debugstr_w( description )); Printing the handle value is not very useful, it would be nicer to get the thread id from the handle if we can. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/89#note_1478

June 1, 2022

Re: [PATCH v2 4/5] user32/tests: Check for window class registration failure normally.

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=115949 Your paranoid android. === w10pro64_en_AE_u8 (64 bit report) === user32: win.c:4551: Test failed: hwnd 000000000002024C/000000000002024C message 0200 win.c:4556: Test failed: hwnd 000000000002024C/000000000002024C message 0203 win.c:4560: Test failed: message 0202 available === w10pro64_ja (64 bit report) === user32: win.c:4378: Test failed: message 0100 available win.c:4379: Test failed: hwnd 0000000000000000 message 0100 win.c:4408: Test failed: no message available win.c:4409: Test failed: hwnd 0000000000000000 message 0100 win.c:10793: Test failed: pos = 00fa00fa win.c:10797: Test failed: pos = 00fa00fa win.c:10801: Test failed: pos = 00fa00fa === w10pro64_zh_CN (64 bit report) === user32: win.c:4378: Test failed: message 0100 available win.c:4379: Test failed: hwnd 0000000000000000 message 0100 win.c:4408: Test failed: no message available win.c:4409: Test failed: hwnd 0000000000000000 message 0100 win.c:10793: Test failed: pos = 00fa00fa win.c:10797: Test failed: pos = 00fa00fa win.c:10801: Test failed: pos = 00fa00fa

June 1, 2022

Re: [PATCH v2 3/5] user32/tests: Remove SetForegroundWindow success checks.

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=115948 Your paranoid android. === w864 (32 bit report) === user32: win.c:2684: Test failed: style 0x200000: expected !100 win.c:2684: Test failed: style 0x300000: expected !100 === w864 (64 bit report) === user32: win.c:2684: Test failed: style 0x200000: expected !100 win.c:2684: Test failed: style 0x300000: expected !100 === w10pro64_ja (64 bit report) === user32: win.c:4374: Test failed: message 0100 available win.c:4375: Test failed: hwnd 0000000000000000 message 0100 win.c:4404: Test failed: no message available win.c:4405: Test failed: hwnd 0000000000000000 message 0100 win.c:10795: Test failed: pos = 00fa00fa win.c:10799: Test failed: pos = 00fa00fa win.c:10803: Test failed: pos = 00fa00fa === w10pro64_zh_CN (64 bit report) === user32: win.c:4374: Test failed: message 0100 available win.c:4375: Test failed: hwnd 0000000000000000 message 0100 win.c:4404: Test failed: no message available win.c:4405: Test failed: hwnd 0000000000000000 message 0100 win.c:10795: Test failed: pos = 00fa00fa win.c:10799: Test failed: pos = 00fa00fa win.c:10803: Test failed: pos = 00fa00fa

June 1, 2022

Re: [PATCH 0/6] MR165: ntdll: Improve block size rounding compatibility.

by Rémi Bernon

On Wed Jun 1 19:18:14 2022 +0000, Alexandre Julliard wrote: > This is breaking tests: > ``` > tools/runtest -q -P wine -T . -M kernel32.dll -p > dlls/kernel32/tests/kernel32_test.exe heap && touch dlls/kernel32/tests/heap.ok > heap.c:535: Test failed: got count 4 > heap.c:544: Test failed: got count 4 > heap.c:592: Test failed: got Region.lpLastBlock 01DC0000 > heap.c:601: Test failed: got wFlags 0x4 > heap.c:602: Test failed: got lpData 01BC0798 > heap.c:604: Test failed: got lpData 01BC0798 > heap.c:606: Test failed: got cbData 0xfffffff8 > heap.c:609: Test failed: got cbOverhead 0x8 > heap.c:621: Test failed: got count 5 > heap.c:630: Test failed: got count 5 > heap.c:663: Test failed: got wFlags 0x2 > heap.c:666: Test failed: got lpData 01BD0000 > heap.c:667: Test failed: got cbData 0x1f0000 > heap.c:670: Test failed: got iRegionIndex 0 > heap.c:681: Test failed: got count 6 > heap.c:690: Test failed: got count 6 > heap.c:726: Test failed: got lpData 01DC0020 > heap.c:744: Test failed: got count 4 > heap.c:757: Test failed: got count 5 > heap.c:774: Test failed: got wFlags 0x4 > heap.c:775: Test failed: got lpData 01BC0820 > heap.c:777: Test failed: got lpData 01BC0820 > heap.c:779: Test failed: got cbData 0xfffffff8 > heap.c:782: Test failed: got cbOverhead 0x8 > heap.c:795: Test failed: got count 6 > heap.c:812: Test failed: got wFlags 0x4 > heap.c:813: Test failed: got lpData 01BC09F0 > heap.c:815: Test failed: got lpData 01BC09F0 > heap.c:817: Test failed: got cbData 0xfffffff8 > heap.c:820: Test failed: got cbOverhead 0x8 > heap.c:948: Test failed: got count 4 > heap.c:956: Test failed: got wFlags 0x4 > heap.c:2147: Tests skipped: skipping block tests > heap.c:2147: Tests skipped: skipping block tests > heap.c:2147: Tests skipped: skipping block tests > heap.c:2147: Tests skipped: skipping block tests > heap.c:2147: Tests skipped: skipping block tests > heap.c:2147: Tests skipped: skipping block tests > heap.c:2147: Tests skipped: skipping block tests > heap.c:2147: Tests skipped: skipping block tests > heap.c:2147: Tests skipped: skipping block tests > heap.c:2147: Tests skipped: skipping block tests > heap.c:2621: Tests skipped: Session Manager flags not set > make: *** [Makefile:61790: dlls/kernel32/tests/heap.ok] Error 32 > ``` Uh sorry, I'll have a look. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/165#note_1477

June 1, 2022

Re: [PATCH 0/6] MR165: ntdll: Improve block size rounding compatibility.

by Alexandre Julliard (＠julliard)

This is breaking tests: ``` tools/runtest -q -P wine -T . -M kernel32.dll -p dlls/kernel32/tests/kernel32_test.exe heap && touch dlls/kernel32/tests/heap.ok heap.c:535: Test failed: got count 4 heap.c:544: Test failed: got count 4 heap.c:592: Test failed: got Region.lpLastBlock 01DC0000 heap.c:601: Test failed: got wFlags 0x4 heap.c:602: Test failed: got lpData 01BC0798 heap.c:604: Test failed: got lpData 01BC0798 heap.c:606: Test failed: got cbData 0xfffffff8 heap.c:609: Test failed: got cbOverhead 0x8 heap.c:621: Test failed: got count 5 heap.c:630: Test failed: got count 5 heap.c:663: Test failed: got wFlags 0x2 heap.c:666: Test failed: got lpData 01BD0000 heap.c:667: Test failed: got cbData 0x1f0000 heap.c:670: Test failed: got iRegionIndex 0 heap.c:681: Test failed: got count 6 heap.c:690: Test failed: got count 6 heap.c:726: Test failed: got lpData 01DC0020 heap.c:744: Test failed: got count 4 heap.c:757: Test failed: got count 5 heap.c:774: Test failed: got wFlags 0x4 heap.c:775: Test failed: got lpData 01BC0820 heap.c:777: Test failed: got lpData 01BC0820 heap.c:779: Test failed: got cbData 0xfffffff8 heap.c:782: Test failed: got cbOverhead 0x8 heap.c:795: Test failed: got count 6 heap.c:812: Test failed: got wFlags 0x4 heap.c:813: Test failed: got lpData 01BC09F0 heap.c:815: Test failed: got lpData 01BC09F0 heap.c:817: Test failed: got cbData 0xfffffff8 heap.c:820: Test failed: got cbOverhead 0x8 heap.c:948: Test failed: got count 4 heap.c:956: Test failed: got wFlags 0x4 heap.c:2147: Tests skipped: skipping block tests heap.c:2147: Tests skipped: skipping block tests heap.c:2147: Tests skipped: skipping block tests heap.c:2147: Tests skipped: skipping block tests heap.c:2147: Tests skipped: skipping block tests heap.c:2147: Tests skipped: skipping block tests heap.c:2147: Tests skipped: skipping block tests heap.c:2147: Tests skipped: skipping block tests heap.c:2147: Tests skipped: skipping block tests heap.c:2147: Tests skipped: skipping block tests heap.c:2621: Tests skipped: Session Manager flags not set make: *** [Makefile:61790: dlls/kernel32/tests/heap.ok] Error 32 ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/165#note_1476

June 1, 2022

Re: [PATCH v2 0/5] MR169: user32/tests: Cleanup some tests.

by Stefan Dösinger

Or maybe rephrase the test failure message emphasising a possible environment problem or adding a comment that this particular check might fail if the window manager is overly aggressive with focus prevention. Anyway, I'll sign out of the discussion now. Since I'm not working on user32 much it is your choice. I just know I have a d3d focus test-that-can't-fail that's failing on AJ's machine that I need to fix :-( ... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/169#note_1475

June 1, 2022

Re: [PATCH v2 2/5] user32/tests: Remove unnecessary test skipping checks.

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=115947 Your paranoid android. === w10pro64_ja (64 bit report) === user32: win.c:4379: Test failed: message 0100 available win.c:4380: Test failed: hwnd 0000000000000000 message 0100 win.c:4409: Test failed: no message available win.c:4410: Test failed: hwnd 0000000000000000 message 0100 win.c:10800: Test failed: pos = 00fa00fa win.c:10804: Test failed: pos = 00fa00fa win.c:10808: Test failed: pos = 00fa00fa === w10pro64_zh_CN (64 bit report) === user32: win.c:4379: Test failed: message 0100 available win.c:4380: Test failed: hwnd 0000000000000000 message 0100 win.c:4409: Test failed: no message available win.c:4410: Test failed: hwnd 0000000000000000 message 0100 win.c:10800: Test failed: pos = 00fa00fa win.c:10804: Test failed: pos = 00fa00fa win.c:10808: Test failed: pos = 00fa00fa

June 1, 2022

Re: [PATCH v2 0/5] MR169: user32/tests: Cleanup some tests.

by Zebediah Figura

On 6/1/22 13:43, Rémi Bernon (@rbernon) wrote: > On Wed Jun 1 18:36:38 2022 +0000, Stefan Dösinger wrote: >>> >>> it should be fixed by fixing the environment, not by skipping tests. >> I'm not sure I agree. The testbot isn't the only environment where >> people possibly run the tests, and someone new to the entire user32 >> thing might find environment-induced test failures a bug and not a feature. >> That said, it would be sensible to apply different rules to d3d and >> user32. In d3d, handling focus loss/gain is only a relatively small >> part, whereas it is pretty central to user32. > I honestly don't think you can expect tests to do anything meaningful if you are doing something else at the same time in the environment they run in. Maybe that can work for a few very well isolated things, but not for `user32`, and definitely not for `user32:win` / `user32:msg`. > > Even if we consider it a feature we can only at best skip tests, and the unaware user would get a seemingly successful test result, and be happy with it when most tests would have been skipped. > Is there a chance we can sidestep the issue by using a separate desktop or window station?

June 1, 2022

Re: [PATCH v2 1/5] user32/tests: Fix indentation to silence a warning.

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=115946 Your paranoid android. === w10pro64_ar (64 bit report) === user32: msg.c:12861: Test failed: message time not advanced: 1561a 1561a msg.c:12862: Test failed: coords not changed: (101 101) (101 101) msg.c:12879: Test failed: message time not advanced: 1561a 1561a msg.c:12880: Test failed: coords not changed: (101 101) (101 101)

June 1, 2022

Re: [PATCH v2 0/5] MR169: user32/tests: Cleanup some tests.

by Rémi Bernon

On Wed Jun 1 18:36:38 2022 +0000, Stefan Dösinger wrote: > > > > it should be fixed by fixing the environment, not by skipping tests. > I'm not sure I agree. The testbot isn't the only environment where > people possibly run the tests, and someone new to the entire user32 > thing might find environment-induced test failures a bug and not a feature. > That said, it would be sensible to apply different rules to d3d and > user32. In d3d, handling focus loss/gain is only a relatively small > part, whereas it is pretty central to user32. I honestly don't think you can expect tests to do anything meaningful if you are doing something else at the same time in the environment they run in. Maybe that can work for a few very well isolated things, but not for `user32`, and definitely not for `user32:win` / `user32:msg`. Even if we consider it a feature we can only at best skip tests, and the unaware user would get a seemingly successful test result, and be happy with it when most tests would have been skipped. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/169#note_1473

June 1, 2022