June 2022 - Wine-Devel - list.winehq.org

[website] German translation for WWN issue 418

by Julian Rüger

Signed-off-by: Julian Rüger <jr98(a)gmx.net>

June 28, 2022

[website] German translation for release 7.8

by Julian Rüger

Signed-off-by: Julian Rüger <jr98(a)gmx.net>

June 28, 2022

[website] German translation for WWN issue 417

by Julian Rüger

Signed-off-by: Julian Rüger <jr98(a)gmx.net>

June 28, 2022

[website] German translation for release 7.7

by Julian Rüger

Signed-off-by: Julian Rüger <jr98(a)gmx.net>

June 28, 2022

[website] German translation for WWN issue 416

by Julian Rüger

Signed-off-by: Julian Rüger <jr98(a)gmx.net>

June 28, 2022

[website] German translation for release 6.0.4

by Julian Rüger

Signed-off-by: Julian Rüger <jr98(a)gmx.net>

June 28, 2022

[PATCH] po: Update German translation.

by Julian Rüger

Signed-off-by: Julian Rüger <jr98(a)gmx.net>

June 28, 2022

[PATCH 1/1] winecfg: Support color profiles larger than MAX_PATH chars.

by Stefan Dösinger

From: Stefan Dösinger <stefan(a)codeweavers.com> Signed-off-by: Stefan Dösinger <stefan(a)codeweavers.com> --- GetPrivateProfileStringW looks rather awkward to me, and we are dealing with external input here, so if there is a better way to handle this please let me know. A theme description I copypasted out of the registry has 384 characters, so a larger array than MAX_PATH is needed to import it correctly. A maliciously crafted ini file could have any size. --- programs/winecfg/theme.c | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/programs/winecfg/theme.c b/programs/winecfg/theme.c index 9c8737caf64..2b3e447bda0 100644 --- a/programs/winecfg/theme.c +++ b/programs/winecfg/theme.c @@ -22,6 +22,7 @@ * */ +#include <assert.h> #include <stdarg.h> #include <stdlib.h> #include <stdio.h> @@ -554,15 +555,24 @@ static void set_color_from_theme(const WCHAR *keyName, COLORREF color) static void do_parse_theme(WCHAR *file) { - WCHAR keyName[MAX_PATH], keyNameValue[MAX_PATH]; + WCHAR *keyName, keyNameValue[MAX_PATH]; + DWORD len, allocLen = 512; WCHAR *keyNamePtr = NULL; int red = 0, green = 0, blue = 0; COLORREF color; - WINE_TRACE("%s\n", wine_dbgstr_w(file)); + keyName = malloc(sizeof(*keyName) * allocLen); + for (;;) + { + assert(keyName); + len = GetPrivateProfileStringW(L"Control Panel\\Colors", NULL, NULL, keyName, + allocLen, file); + if (len < allocLen - 2) + break; - GetPrivateProfileStringW(L"Control Panel\\Colors", NULL, NULL, keyName, - MAX_PATH, file); + allocLen *= 2; + keyName = realloc(keyName, sizeof(*keyName) * allocLen); + } keyNamePtr = keyName; while (*keyNamePtr!=0) { @@ -580,6 +590,7 @@ static void do_parse_theme(WCHAR *file) keyNamePtr+=lstrlenW(keyNamePtr); keyNamePtr++; } + free(keyName); } static void on_theme_install(HWND dialog) -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/331

June 28, 2022

[PATCH 0/1] MR331: winecfg: Support color profiles larger than MAX_PATH chars.

by Stefan Dösinger

Signed-off-by: Stefan Dösinger <stefan(a)codeweavers.com> --- GetPrivateProfileStringW looks rather awkward to me, and we are dealing with external input here, so if there is a better way to handle this please let me know. A theme description I copypasted out of the registry has 384 characters, so a larger array than MAX_PATH is needed to import it correctly. A maliciously crafted ini file could have any size. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/331

June 28, 2022

Re: [PATCH 0/3] MR330: Tests for properties.

by Nikolay Sivov (＠nsivov)

Nikolay Sivov (@nsivov) commented about dlls/d2d1/tests/d2d1.c: > + const WCHAR *name; > + D2D1_PROPERTY_TYPE type; > + UINT32 value_size; > + } > + property_tests[] = > + { > + {D2D1_PROPERTY_CLSID, L"CLSID", D2D1_PROPERTY_TYPE_CLSID, sizeof(CLSID)}, > + {D2D1_PROPERTY_DISPLAYNAME, L"DisplayName", D2D1_PROPERTY_TYPE_STRING, 0}, > + {D2D1_PROPERTY_AUTHOR, L"Author", D2D1_PROPERTY_TYPE_STRING, 0}, > + {D2D1_PROPERTY_CATEGORY, L"Category", D2D1_PROPERTY_TYPE_STRING, 0}, > + {D2D1_PROPERTY_DESCRIPTION, L"Description", D2D1_PROPERTY_TYPE_STRING, 0}, > + {D2D1_PROPERTY_INPUTS, L"Inputs", D2D1_PROPERTY_TYPE_ARRAY, sizeof(UINT32)}, > + {D2D1_PROPERTY_CACHED, L"Cached", D2D1_PROPERTY_TYPE_BOOL, sizeof(UINT32)}, > + {D2D1_PROPERTY_PRECISION, L"Precision", D2D1_PROPERTY_TYPE_ENUM, sizeof(UINT32)}, > + {D2D1_PROPERTY_MIN_INPUTS, L"MinInputs", D2D1_PROPERTY_TYPE_UINT32, sizeof(UINT32)}, > + {D2D1_PROPERTY_MAX_INPUTS, L"MaxInputs", D2D1_PROPERTY_TYPE_UINT32, sizeof(UINT32)}, I believe this is a set of system properties that are always available, even if not specified explicitly. That includes custom effects. Maybe additional helper to test such predefined properties is better, we can use it for custom effect tests and in each builtin effect test function. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/330#note_2849

June 28, 2022