June 2022 - Wine-Devel - list.winehq.org

Re: [PATCH] include: Add dxcore.idl.

by Biswapriyo Nath

> At very least the Microsoft Corp copyright line should be retained in this case. My apology. I have no idea about license in software. Where should I put that copyright line? Should I retain the LGPL license notice under that? Feel free to copy my patch and modify it.

June 25, 2022

Re: [PATCH] include: Add dxcore.idl.

by Stefan Dösinger

> Am 25.06.2022 um 10:41 schrieb Austin English <austinenglish(a)gmail.com>: > > Not trying to 'volunteer' you for this (I think the default person for that is jwhite ;) ) but sounds like a great chance to discuss/clarify/document this. The last time I tried to give advise on this topic beyond "it's complicated" julliard called back my advise 5 seconds later :-)

June 25, 2022

Re: [PATCH] include: Add dxcore.idl.

by Austin English

On Sat, Jun 25, 2022 at 2:15 AM Stefan Dösinger <stefandoesinger(a)gmail.com> wrote: > > > Am 25.06.2022 um 08:47 schrieb Charles Davis <cdavis5x(a)gmail.com>: > > > > On Sat, Jun 25, 2022 at 12:36 AM Biswapriyo Nath <nathbappai(a)gmail.com> > wrote: > >> > >> Thank you for the review. I copied it from dxcore.h[1]. I have > >> attached the updated patch. > >> > >> [1]: > https://github.com/microsoft/DirectX-Headers/blob/main/include/directx/dxco… > > > > Ah, so it is under an open-source license compatible with ours. I was > > concerned you might have copy-pasted out of a header with a more > > restrictive license. (Even if it were Apache, for example, that would > > cause legal problems, because that license infamously *isn't* > > compatible with the GPLv2.) Sorry about that. > > At very least the Microsoft Corp copyright line should be retained in this > case. > > The dos and don'ts of writing headers have always been tricky and > frustrating. > Not trying to 'volunteer' you for this (I think the default person for that is jwhite ;) ) but sounds like a great chance to discuss/clarify/document this. > I think this is the first case where we have the luxury of a > license-compatible header from Microsoft. > FYI, several things have been open sourced with compatible licenses recently. I.e., a search on github shows 1000+ projects with MIT licenses from Microsoft: https://github.com/orgs/microsoft/repositories?q=license%3Amit -- -Austin GPG: 267B CC1F 053F 0749 (expires 2024/02/17)

June 25, 2022

Re: [PATCH] include: Add dxcore.idl.

by Stefan Dösinger

> Am 25.06.2022 um 08:47 schrieb Charles Davis <cdavis5x(a)gmail.com>: > > On Sat, Jun 25, 2022 at 12:36 AM Biswapriyo Nath <nathbappai(a)gmail.com> wrote: >> >> Thank you for the review. I copied it from dxcore.h[1]. I have >> attached the updated patch. >> >> [1]: https://github.com/microsoft/DirectX-Headers/blob/main/include/directx/dxco… > > Ah, so it is under an open-source license compatible with ours. I was > concerned you might have copy-pasted out of a header with a more > restrictive license. (Even if it were Apache, for example, that would > cause legal problems, because that license infamously *isn't* > compatible with the GPLv2.) Sorry about that. At very least the Microsoft Corp copyright line should be retained in this case. The dos and don'ts of writing headers have always been tricky and frustrating. I think this is the first case where we have the luxury of a license-compatible header from Microsoft.

June 25, 2022

Re: [PATCH] include: Add dxcore.idl.

by Charles Davis

On Sat, Jun 25, 2022 at 12:36 AM Biswapriyo Nath <nathbappai(a)gmail.com> wrote: > > Thank you for the review. I copied it from dxcore.h[1]. I have > attached the updated patch. > > [1]: https://github.com/microsoft/DirectX-Headers/blob/main/include/directx/dxco… Ah, so it is under an open-source license compatible with ours. I was concerned you might have copy-pasted out of a header with a more restrictive license. (Even if it were Apache, for example, that would cause legal problems, because that license infamously *isn't* compatible with the GPLv2.) Sorry about that. -- Chip

June 25, 2022

Re: [PATCH] include: Add dxcore.idl.

by Biswapriyo Nath

Thank you for the review. I copied it from dxcore.h[1]. I have attached the updated patch. [1]: https://github.com/microsoft/DirectX-Headers/blob/main/include/directx/dxco…

June 25, 2022

Re: HLSL offsetting

by Francisco Casas

Hello, I attach the third version of the previous patch, applying the suggestions made by Zeb, and some other changes that arose from them. The patch is based on the master branch, but I guess I will have to update it if the recent patches from Giovanni are accepted, before sending it for review. Best regards, Francisco.

June 25, 2022

Re: [PATCH] include: Add dxcore.idl.

by Charles Davis

On Fri, Jun 24, 2022 at 11:00 PM Biswapriyo Nath <nathbappai(a)gmail.com> wrote: > cpp_quote("STDAPI DXCoreCreateAdapterFactory(REFIID riid, void **ppvFactory);") Generally, we prefer writing out the return type and calling convention (i.e. HRESULT WINAPI--though I guess technically it should be HRESULT STDAPICALLTYPE, but the calling convention macros are all just aliases for __stdcall anyway) to using macros like STDAPI. Did you copy this directly out of Microsoft's IDL file? The formatting on the interfaces' attributes (in the square brackets) and methods is also unusual for Wine. -- Chip

June 25, 2022

[PATCH] include: Add dxcore.idl.

by Biswapriyo Nath

June 25, 2022

[PATCH v2 1/1] winex11.drv: Increment configure_serial in X11DRV_WindowPosChanged() even if not syncing window position.

by Paul Gofman

From: Paul Gofman <pgofman(a)codeweavers.com> --- dlls/winex11.drv/window.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/dlls/winex11.drv/window.c b/dlls/winex11.drv/window.c index 3ebbee0856e..f3c11cff008 100644 --- a/dlls/winex11.drv/window.c +++ b/dlls/winex11.drv/window.c @@ -2645,9 +2645,13 @@ void X11DRV_WindowPosChanged( HWND hwnd, HWND insert_after, UINT swp_flags, } /* don't change position if we are about to minimize or maximize a managed window */ - if (!event_type && - !(data->managed && (swp_flags & SWP_STATECHANGED) && (new_style & (WS_MINIMIZE|WS_MAXIMIZE)))) - sync_window_position( data, swp_flags, &old_window_rect, &old_whole_rect, &old_client_rect ); + if (!event_type) + { + if (!(data->managed && (swp_flags & SWP_STATECHANGED) && (new_style & (WS_MINIMIZE|WS_MAXIMIZE)))) + sync_window_position( data, swp_flags, &old_window_rect, &old_whole_rect, &old_client_rect ); + else + data->configure_serial = NextRequest( data->display ); + } if ((new_style & WS_VISIBLE) && ((new_style & WS_MINIMIZE) || is_window_rect_mapped( rectWindow ))) -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/312

June 25, 2022