June 2022 - Wine-Devel - list.winehq.org

[PATCH v2 0/1] MR312: winex11.drv: Increment configure_serial in X11DRV_WindowPosChanged() even if...

by Paul Gofman (＠gofman)

Once we reached that place where sync_window_position() is called (or not called if window is about to be minimized or maximized) the old in-flight X_ConfigureNotify do not make sense anymore. sync_window_position() does that unconditionally but if we don't call it for minimize / maximize we should probably discard them regardless. An example of the failing scenario which this patch is fixing is the following: 1. App calls SetWindowPos() with some size, X_ConfigureNotify is in flight; 2. App calls ShowWindow(SW_MAXIMIZE), old X_ConfigureNotify is still in flight; sync_window_position() is not called and configure_serial is not updated; 3. Now X_ConfigureNotify from p.1 arrives and it gets processed like WM is changing window size back, that confuses the app and since the reaction on the new app's SetWindowPos / maximizing is also delayed and then X events triggered by p. 2. also arribe later. That may cause endless loop with non-functional window. -- v2: winex11.drv: Increment configure_serial in X11DRV_WindowPosChanged() even if not syncing window position. https://gitlab.winehq.org/wine/wine/-/merge_requests/312

June 25, 2022

[PATCH 1/1] winex11.drv: Increment configure_serial in X11DRV_WindowPosChanged() even if not syncing window position.

by Paul Gofman

From: Paul Gofman <pgofman(a)codeweavers.com> --- dlls/winex11.drv/window.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/dlls/winex11.drv/window.c b/dlls/winex11.drv/window.c index 3ebbee0856e..1e9bd64cd0b 100644 --- a/dlls/winex11.drv/window.c +++ b/dlls/winex11.drv/window.c @@ -2645,9 +2645,13 @@ void X11DRV_WindowPosChanged( HWND hwnd, HWND insert_after, UINT swp_flags, } /* don't change position if we are about to minimize or maximize a managed window */ - if (!event_type && - !(data->managed && (swp_flags & SWP_STATECHANGED) && (new_style & (WS_MINIMIZE|WS_MAXIMIZE)))) - sync_window_position( data, swp_flags, &old_window_rect, &old_whole_rect, &old_client_rect ); + if (!event_type || event_type == PropertyNotify) + { + if (!(data->managed && (swp_flags & SWP_STATECHANGED) && (new_style & (WS_MINIMIZE|WS_MAXIMIZE)))) + sync_window_position( data, swp_flags, &old_window_rect, &old_whole_rect, &old_client_rect ); + else + data->configure_serial = NextRequest( data->display ); + } if ((new_style & WS_VISIBLE) && ((new_style & WS_MINIMIZE) || is_window_rect_mapped( rectWindow ))) -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/312

June 25, 2022

[PATCH 0/1] MR312: winex11.drv: Increment configure_serial in X11DRV_WindowPosChanged() even if...

by Paul Gofman (＠gofman)

Once we reached that place where sync_window_position() is called (or not called if window is about to be minimized or maximized) the old in-flight X_ConfigureNotify do not make sense anymore. sync_window_position() does that unconditionally but if we don't call it for minimize / maximize we should probably discard them regardless. An example of the failing scenario which this patch is fixing is the following: 1. App calls SetWindowPos() with some size, X_ConfigureNotify is in flight; 2. App calls ShowWindow(SW_MAXIMIZE), old X_ConfigureNotify is still in flight; sync_window_position() is not called and configure_serial is not updated; 3. Now X_ConfigureNotify from p.1 arrives and it gets processed like WM is changing window size back, that confuses the app and since the reaction on the new app's SetWindowPos / maximizing is also delayed and then X events triggered by p. 2. also arribe later. That may cause endless loop with non-functional window. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/312

June 25, 2022

[PATCH] po: Update Dutch translation.

by Floris Renaud

Signed-off-by: Floris Renaud <jkfloris(a)dds.nl> --- po/nl.po | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/po/nl.po b/po/nl.po index bf4ff469379..8e3074e26e5 100644 --- a/po/nl.po +++ b/po/nl.po @@ -5,7 +5,7 @@ msgstr "" "Project-Id-Version: Wine\n" "Report-Msgid-Bugs-To: https://bugs.winehq.org\n" "POT-Creation-Date: N/A\n" -"PO-Revision-Date: 2022-04-15 18:10+0200\n" +"PO-Revision-Date: 2022-06-25 00:15+0200\n" "Last-Translator: Floris Renaud <jkfloris(a)dds.nl>\n" "Language-Team: Dutch\n" "Language: nl\n" @@ -16455,10 +16455,8 @@ msgstr "&DWORD-waarde" #: programs/regedit/regedit.rc:52 programs/regedit/regedit.rc:105 #: programs/regedit/regedit.rc:128 -#, fuzzy -#| msgid "&DWORD Value" msgid "&QWORD Value" -msgstr "&DWORD-waarde" +msgstr "&QWORD-waarde" #: programs/regedit/regedit.rc:53 programs/regedit/regedit.rc:106 #: programs/regedit/regedit.rc:129 @@ -17017,16 +17015,12 @@ msgid "Collapse" msgstr "Invouwen" #: programs/regedit/regedit.rc:178 -#, fuzzy -#| msgid "Adds a new 32-bit value" msgid "Adds a new 64-bit value" -msgstr "Een nieuwe 32-bit waarde toevoegen" +msgstr "Een nieuwe 64-bit waarde toevoegen" #: programs/regedit/regedit.rc:221 -#, fuzzy -#| msgid "Edit DWORD" msgid "Edit QWORD" -msgstr "DWORD waarde bewerken" +msgstr "QWORD waarde bewerken" #: programs/regsvr32/regsvr32.rc:33 msgid "" -- 2.36.1

June 24, 2022

[PATCH] Suppress below message, with fix mojibake for japanese filename in LANG=ja_JP.SJIS environment. "err:environ:init_unix_codepage unrecognized charset 'SJIS'"

by Yoshiji Emoto

In past I sent patch for "dlls/winex11.drv/window.c" is not needed. Cancel it please. Signed-off-by: Yoshiji Emoto <alumina.from.ceramix(a)gmail.com> --- dlls/ntdll/unix/env.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/ntdll/unix/env.c b/dlls/ntdll/unix/env.c index a71df03966f..90035f683e7 100644 --- a/dlls/ntdll/unix/env.c +++ b/dlls/ntdll/unix/env.c @@ -270,6 +270,7 @@ static const struct { const char *name; UINT cp; } charset_names[] = { "ISO88599", 28599 }, { "KOI8R", 20866 }, { "KOI8U", 21866 }, + { "SJIS", 932 }, { "TIS620", 28601 }, { "UTF8", CP_UTF8 } }; -- 2.35.2

June 24, 2022

[PATCH] po: Update Lithuanian translation.

by Aurimas Fišeras

June 24, 2022

Re: [PATCH 0/2] MR308: Add "wine/str.h", use "wine/heap.h" and it in winemenubuilder

by Davide Beatrici (＠davidebeatrici)

No problem, thanks for your comments! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/308#note_2695

June 24, 2022

Re: [PATCH 0/2] MR308: Add "wine/str.h", use "wine/heap.h" and it in winemenubuilder

by Alexandre Julliard (＠julliard)

> Are you interested in utf16to() and toutf16()? If yes, is there already a header that may be suitable for them? No, I don't think that's useful. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/308#note_2694

June 24, 2022

Re: [PATCH 0/2] MR308: Add "wine/str.h", use "wine/heap.h" and it in winemenubuilder

by Davide Beatrici (＠davidebeatrici)

I agree. Are you interested in `utf16to()` and `toutf16()`? If yes, is there already a header that may be suitable for them? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/308#note_2693

June 24, 2022

Re: [PATCH v4 0/1] MR303: win32u: Don't report cloned monitors in EnumDisplayMonitors(). - approved

by Alexandre Julliard (＠julliard)

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/303

June 24, 2022