June 2022 - Wine-Devel - list.winehq.org

Re: [PATCH 0/2] MR308: Add "wine/str.h", use "wine/heap.h" and it in winemenubuilder - closed

by Alexandre Julliard (＠julliard)

This merge request was closed by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/308

June 24, 2022

Re: [PATCH 0/2] MR308: Add "wine/str.h", use "wine/heap.h" and it in winemenubuilder

by Alexandre Julliard (＠julliard)

This doesn't seem like an improvement. Adding non-standard functions with different conventions is not reducing complexity, just the opposite. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/308#note_2630

June 24, 2022

Re: [PATCH v5 7/7] mfplat/tests: Merge and reorganize image format tests.

by Marvin

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=117555 Your paranoid android. === w7u_el (32 bit report) === mfplat: 085c:mfplat: unhandled exception c0000005 at 71EF7D1C === debian11 (32 bit report) === Report validation errors: mfplat:mfplat prints too much data (41309 bytes) === debian11 (32 bit WoW report) === Report validation errors: mfplat:mfplat prints too much data (38290 bytes)

June 24, 2022

Re: [PATCH v5 5/7] mfplat/tests: Remove duplicated tests.

by Marvin

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=117553 Your paranoid android. === debian11 (32 bit report) === Report validation errors: mfplat:mfplat prints too much data (36968 bytes) === debian11 (32 bit WoW report) === Report validation errors: mfplat:mfplat prints too much data (38253 bytes)

June 24, 2022

Re: [PATCH v2 0/4] MR271: win32u: Move rawinput APIs.

by Francois Gouget (＠fgouget)

On Fri Jun 24 05:38:23 2022 +0000, **** wrote: > Marvin replied on the mailing list: > ``` > Hi, > It looks like your patch introduced the new failures shown below. > Please investigate and fix them before resubmitting your patch. > If they are not new, fixing them anyway would help a lot. Otherwise > please ask for the known failures list to be updated. > The tests also ran into some preexisting test failures. If you know how > to fix them that would be helpful. See the TestBot job for the details: > The full results can be found at: > https://testbot.winehq.org/JobDetails.pl?Key=117542 > Your paranoid android. > === debian11 (32 bit Chinese:China report) === > user32: > msg.c:6881: Test failed: SetFocus(hwnd) on a button: 5: the msg 0x0138 > was expected, but got msg 0x030f instead > ``` This is a false positive. Usually the failure is about another msg but it happened for this one too before. I updated the regexp. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/271#note_2629

June 24, 2022

Re: [PATCH v5 3/7] mfplat/buffer: Fix the image copy function for IMC2/IMC4 buffers with odd height.

by Marvin

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=117551 Your paranoid android. === w7u_el (32 bit report) === mfplat: 0854:mfplat: unhandled exception c0000005 at 71F57D1C === debian11 (32 bit report) === Report validation errors: mfplat:mfplat prints too much data (41289 bytes) === debian11 (32 bit WoW report) === Report validation errors: mfplat:mfplat prints too much data (37001 bytes)

June 24, 2022

Re: [PATCH v5 2/7] mfplat/tests: Use a more unique pattern when testing image formats.

by Marvin

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=117550 Your paranoid android. === w7u_el (32 bit report) === mfplat: 0854:mfplat: unhandled exception c0000005 at 72117D1C === debian11 (32 bit report) === Report validation errors: mfplat:mfplat prints too much data (41870 bytes) === debian11 (32 bit WoW report) === Report validation errors: mfplat:mfplat prints too much data (41878 bytes)

June 24, 2022

Re: [PATCH v5 1/7] mfplat/buffer: Fix size for IMC2/IMC4 buffers with odd height.

by Marvin

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=117549 Your paranoid android. === debian11 (32 bit report) === Report validation errors: mfplat:mfplat prints too much data (41258 bytes) === debian11 (32 bit WoW report) === Report validation errors: mfplat:mfplat prints too much data (38287 bytes)

June 24, 2022

Re: [PATCH v5 6/7] mfplat/buffer: Support YV12, I420 and IYUV image formats.

by Marvin

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=117554 Your paranoid android. === debian11 (32 bit report) === Report validation errors: mfplat:mfplat prints too much data (41329 bytes) === debian11 (32 bit WoW report) === Report validation errors: mfplat:mfplat prints too much data (41317 bytes)

June 24, 2022

Re: [PATCH v5 4/7] mfplat/buffer: Deduplicate common code between Lock2D() and Lock2DSize().

by Marvin

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=117552 Your paranoid android. === debian11 (32 bit report) === Report validation errors: mfplat:mfplat prints too much data (38251 bytes) === debian11 (32 bit WoW report) === Report validation errors: mfplat:mfplat prints too much data (38318 bytes)

June 24, 2022