June 2022 - Wine-Devel - list.winehq.org

Re: [PATCH v2 0/2] MR300: d2d1: Implement IsBufferPrecisionSupported(). - approved

by Alexandre Julliard (＠julliard)

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/300

June 23, 2022

Re: [PATCH v2 0/6] MR299: uxtheme: Support parsing more tab parts. - approved

by Alexandre Julliard (＠julliard)

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/299

June 23, 2022

[PATCH 1/1] mshtml: Enable CSS grid layout.

by Arkadiusz Hiler

From: Arkadiusz Hiler <ahiler(a)codeweavers.com> Final Fantasy XIV launcher uses it to show login form next to the news. Signed-off-by: Arkadiusz Hiler <ahiler(a)codeweavers.com> --- dlls/mshtml/nsembed.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/mshtml/nsembed.c b/dlls/mshtml/nsembed.c index e34861b13fa..8f456b40ef2 100644 --- a/dlls/mshtml/nsembed.c +++ b/dlls/mshtml/nsembed.c @@ -540,6 +540,7 @@ static void set_preferences(void) set_lang(pref); set_bool_pref(pref, "security.warn_entering_secure", FALSE); set_bool_pref(pref, "security.warn_submit_insecure", FALSE); + set_bool_pref(pref, "layout.css.grid.enabled", TRUE); set_int_pref(pref, "layout.spellcheckDefault", 0); nsIPrefBranch_Release(pref); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/304

June 23, 2022

[PATCH 0/1] MR304: mshtml: Enable CSS grid layout.

by Arek Hiler (＠ivyl)

This helps with Final Fantasy XIV launcher not rendering correctly under Wine. The login form should be to the right of the news section but due to grid layout being unsupported it renders below and requires scrolling to be accessed which is non-obvious. The CSS grid is not fully implemented in Gecko version we are using. https://bugzilla.mozilla.org/show_bug.cgi?id=1217086 + bugs it depends on seems to be representative of the state of the implementation in version ~47. Looks like it's mostly some nesting cases that were still being implemented. The only real problem seems to require a very specific setup https://bugzilla.mozilla.org/show_bug.cgi?id=1316649 but we still may want to pick up the fix for it for wine-gecko. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/304

June 23, 2022

Re: [PATCH v3 5/6] winegstreamer: Check H264 ProcessOutput sample against actual image size.

by Marvin

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=117499 Your paranoid android. === w8 (32 bit report) === mf: mf.c:4610: Test failed: Unexpected hr 0x800401f0. === w1064v1507 (64 bit report) === mf: 0d4c:mf: unhandled exception c0000005 at 00007FFFE1D1A901 === debian11 (32 bit report) === Report validation errors: mf:mf prints too much data (39752 bytes) === debian11 (32 bit WoW report) === Report validation errors: mf:mf prints too much data (39710 bytes)

June 23, 2022

Re: [PATCH v3 0/6] MR302: winegstreamer: Some wg_transform H264 fixes for Mortal Kombat 11 and Yakuza 4.

by Rémi Bernon

Sorry, the failures were actually introduced in PATCH 4, I'll move the fixes and update the MR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/302#note_2580

June 23, 2022

Re: [PATCH v3 4/6] winegstreamer: Use H264 input media type frame size when specified.

by Marvin

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=117498 Your paranoid android. === w7u_2qxl (32 bit report) === mf: mf.c:7051: Test failed: out 0: "MF_MT_FRAME_SIZE" mismatch, type 21, value 120:248 mf.c:7051: Test failed: out 0: "MF_MT_SAMPLE_SIZE" mismatch, type 19, value 44640 mf.c:7051: Test failed: out 1: "MF_MT_FRAME_SIZE" mismatch, type 21, value 120:248 mf.c:7051: Test failed: out 1: "MF_MT_SAMPLE_SIZE" mismatch, type 19, value 44640 mf.c:7051: Test failed: out 2: "MF_MT_FRAME_SIZE" mismatch, type 21, value 120:248 mf.c:7051: Test failed: out 2: "MF_MT_SAMPLE_SIZE" mismatch, type 19, value 44640 mf.c:7051: Test failed: out 3: "MF_MT_FRAME_SIZE" mismatch, type 21, value 120:248 mf.c:7051: Test failed: out 3: "MF_MT_SAMPLE_SIZE" mismatch, type 19, value 44640 mf.c:7051: Test failed: out 4: "MF_MT_FRAME_SIZE" mismatch, type 21, value 120:248 mf.c:7051: Test failed: out 4: "MF_MT_SAMPLE_SIZE" mismatch, type 19, value 59520 mf.c:7079: Test failed: SetOutputType returned 0. mf.c:7082: Test failed: SetOutputType returned 0xc00d36b4. mf.c:7100: Test failed: out 0: "MF_MT_FRAME_SIZE" mismatch, type 21, value 120:248 mf.c:7100: Test failed: out 0: "MF_MT_SAMPLE_SIZE" mismatch, type 19, value 44640 mf.c:7100: Test failed: out 1: "MF_MT_FRAME_SIZE" mismatch, type 21, value 120:248 mf.c:7100: Test failed: out 1: "MF_MT_SAMPLE_SIZE" mismatch, type 19, value 44640 mf.c:7100: Test failed: out 2: "MF_MT_FRAME_SIZE" mismatch, type 21, value 120:248 mf.c:7100: Test failed: out 2: "MF_MT_SAMPLE_SIZE" mismatch, type 19, value 44640 mf.c:7100: Test failed: out 3: "MF_MT_FRAME_SIZE" mismatch, type 21, value 120:248 mf.c:7100: Test failed: out 3: "MF_MT_SAMPLE_SIZE" mismatch, type 19, value 44640 mf.c:7100: Test failed: out 4: "MF_MT_FRAME_SIZE" mismatch, type 21, value 120:248 mf.c:7100: Test failed: out 4: "MF_MT_SAMPLE_SIZE" mismatch, type 19, value 59520 mf.c:7226: Test failed: out 0: "MF_MT_FRAME_RATE" mismatch, type 21, value 30000:1001 mf.c:7226: Test failed: out 1: "MF_MT_FRAME_RATE" mismatch, type 21, value 30000:1001 mf.c:7226: Test failed: out 2: "MF_MT_FRAME_RATE" mismatch, type 21, value 30000:1001 mf.c:7226: Test failed: out 3: "MF_MT_FRAME_RATE" mismatch, type 21, value 30000:1001 mf.c:7226: Test failed: out 4: "MF_MT_FRAME_RATE" mismatch, type 21, value 30000:1001 === w7u_adm (32 bit report) === mf: mf.c:7051: Test failed: out 0: "MF_MT_FRAME_SIZE" mismatch, type 21, value 120:248 mf.c:7051: Test failed: out 0: "MF_MT_SAMPLE_SIZE" mismatch, type 19, value 44640 mf.c:7051: Test failed: out 1: "MF_MT_FRAME_SIZE" mismatch, type 21, value 120:248 mf.c:7051: Test failed: out 1: "MF_MT_SAMPLE_SIZE" mismatch, type 19, value 44640 mf.c:7051: Test failed: out 2: "MF_MT_FRAME_SIZE" mismatch, type 21, value 120:248 mf.c:7051: Test failed: out 2: "MF_MT_SAMPLE_SIZE" mismatch, type 19, value 44640 mf.c:7051: Test failed: out 3: "MF_MT_FRAME_SIZE" mismatch, type 21, value 120:248 mf.c:7051: Test failed: out 3: "MF_MT_SAMPLE_SIZE" mismatch, type 19, value 44640 mf.c:7051: Test failed: out 4: "MF_MT_FRAME_SIZE" mismatch, type 21, value 120:248 mf.c:7051: Test failed: out 4: "MF_MT_SAMPLE_SIZE" mismatch, type 19, value 59520 mf.c:7079: Test failed: SetOutputType returned 0. mf.c:7082: Test failed: SetOutputType returned 0xc00d36b4. mf.c:7100: Test failed: out 0: "MF_MT_FRAME_SIZE" mismatch, type 21, value 120:248 mf.c:7100: Test failed: out 0: "MF_MT_SAMPLE_SIZE" mismatch, type 19, value 44640 mf.c:7100: Test failed: out 1: "MF_MT_FRAME_SIZE" mismatch, type 21, value 120:248 mf.c:7100: Test failed: out 1: "MF_MT_SAMPLE_SIZE" mismatch, type 19, value 44640 mf.c:7100: Test failed: out 2: "MF_MT_FRAME_SIZE" mismatch, type 21, value 120:248 mf.c:7100: Test failed: out 2: "MF_MT_SAMPLE_SIZE" mismatch, type 19, value 44640 mf.c:7100: Test failed: out 3: "MF_MT_FRAME_SIZE" mismatch, type 21, value 120:248 mf.c:7100: Test failed: out 3: "MF_MT_SAMPLE_SIZE" mismatch, type 19, value 44640 mf.c:7100: Test failed: out 4: "MF_MT_FRAME_SIZE" mismatch, type 21, value 120:248 mf.c:7100: Test failed: out 4: "MF_MT_SAMPLE_SIZE" mismatch, type 19, value 59520 mf.c:7226: Test failed: out 0: "MF_MT_FRAME_RATE" mismatch, type 21, value 30000:1001 mf.c:7226: Test failed: out 1: "MF_MT_FRAME_RATE" mismatch, type 21, value 30000:1001 mf.c:7226: Test failed: out 2: "MF_MT_FRAME_RATE" mismatch, type 21, value 30000:1001 mf.c:7226: Test failed: out 3: "MF_MT_FRAME_RATE" mismatch, type 21, value 30000:1001 mf.c:7226: Test failed: out 4: "MF_MT_FRAME_RATE" mismatch, type 21, value 30000:1001 === w7u_el (32 bit report) === mf: mf.c:7051: Test failed: out 0: "MF_MT_FRAME_SIZE" mismatch, type 21, value 120:248 mf.c:7051: Test failed: out 0: "MF_MT_SAMPLE_SIZE" mismatch, type 19, value 44640 mf.c:7051: Test failed: out 1: "MF_MT_FRAME_SIZE" mismatch, type 21, value 120:248 mf.c:7051: Test failed: out 1: "MF_MT_SAMPLE_SIZE" mismatch, type 19, value 44640 mf.c:7051: Test failed: out 2: "MF_MT_FRAME_SIZE" mismatch, type 21, value 120:248 mf.c:7051: Test failed: out 2: "MF_MT_SAMPLE_SIZE" mismatch, type 19, value 44640 mf.c:7051: Test failed: out 3: "MF_MT_FRAME_SIZE" mismatch, type 21, value 120:248 mf.c:7051: Test failed: out 3: "MF_MT_SAMPLE_SIZE" mismatch, type 19, value 44640 mf.c:7051: Test failed: out 4: "MF_MT_FRAME_SIZE" mismatch, type 21, value 120:248 mf.c:7051: Test failed: out 4: "MF_MT_SAMPLE_SIZE" mismatch, type 19, value 59520 mf.c:7079: Test failed: SetOutputType returned 0. mf.c:7082: Test failed: SetOutputType returned 0xc00d36b4. mf.c:7100: Test failed: out 0: "MF_MT_FRAME_SIZE" mismatch, type 21, value 120:248 mf.c:7100: Test failed: out 0: "MF_MT_SAMPLE_SIZE" mismatch, type 19, value 44640 mf.c:7100: Test failed: out 1: "MF_MT_FRAME_SIZE" mismatch, type 21, value 120:248 mf.c:7100: Test failed: out 1: "MF_MT_SAMPLE_SIZE" mismatch, type 19, value 44640 mf.c:7100: Test failed: out 2: "MF_MT_FRAME_SIZE" mismatch, type 21, value 120:248 mf.c:7100: Test failed: out 2: "MF_MT_SAMPLE_SIZE" mismatch, type 19, value 44640 mf.c:7100: Test failed: out 3: "MF_MT_FRAME_SIZE" mismatch, type 21, value 120:248 mf.c:7100: Test failed: out 3: "MF_MT_SAMPLE_SIZE" mismatch, type 19, value 44640 mf.c:7100: Test failed: out 4: "MF_MT_FRAME_SIZE" mismatch, type 21, value 120:248 mf.c:7100: Test failed: out 4: "MF_MT_SAMPLE_SIZE" mismatch, type 19, value 59520 mf.c:7226: Test failed: out 0: "MF_MT_FRAME_RATE" mismatch, type 21, value 30000:1001 mf.c:7226: Test failed: out 1: "MF_MT_FRAME_RATE" mismatch, type 21, value 30000:1001 mf.c:7226: Test failed: out 2: "MF_MT_FRAME_RATE" mismatch, type 21, value 30000:1001 mf.c:7226: Test failed: out 3: "MF_MT_FRAME_RATE" mismatch, type 21, value 30000:1001 mf.c:7226: Test failed: out 4: "MF_MT_FRAME_RATE" mismatch, type 21, value 30000:1001 === debian11 (32 bit report) === Report validation errors: mf:mf prints too much data (39732 bytes) === debian11 (32 bit WoW report) === Report validation errors: mf:mf prints too much data (39709 bytes)

June 23, 2022

TestBot News : Failure tracking

by Francois Gouget

The TestBot now has a list of known failures which it can identify and link to the corresponding Wine bug. The main benefit is that the TestBot knows your patches cannot be the cause of known failures, even if they look new [1]. The list of known failures is not yet complete [2] but you can expect that over the next few weeks the cases where the TestBot incorrectly claims your patch introduces new failures should get much rarer. Failure tracking also provides you with other benefits: The task full logs now have an index of the known failures they contain to help you quickly go to the first corresponding failure line. (and a pair of additional entries point you to the first and last failure) Also the failure lines are annotated with the corresponding bug id(s). This id is a link that takes you to a page that: * Shows how the TestBot identified the failure. * Links to the Wine bug discussing the failure. * And show all the tasks and logs where the failure occurred. You can use this to quickly access these logs and look for common patterns. You can also get a list of the known failures by clicking on the Failures entry in the TestBot's sidebar. https://testbot.winehq.org/FailuresList.pl For each failure you will see when it last happened and the status of the corresponding bug (new, closed, etc). This is a good way to identify failures that seem to be fixed. Finally the job report emails also list the known failures that happened while testing your patch. Consider this a reminder that your help in fixing them would be greatly appreciated, particularly as you may already know the area since you patched it. [1] The TestBot normally diffs the test run's failures against the past WineTest reports and considers any line marked as new (literally '+' in unified diff parlance), as a new failure. This means any failure that's rare enough to not be present in any of the past WineTest runs of the same test configuration, will be flagged as new. Failures where the message changes (beyond basic line number changes, addresses in exceptions, etc.) will also look new. This could be because a patch changed the failure message, but more often it is because the message itself contains a pointer, handle, uninitialized data, elapsed time, etc. [2] The goal is not necessarily to track every test failure but to track all those that can cause false positives. So a test that fails systematically may not be tracked (although if it has a Wine bug it probably should be). But tests that tend to be incorrectly tagged as new due to the issues in [1] should all be. The way I plan to get there is to monitor the TestBot's WineTest jobs for a while and add to the known failure list whenever new unknown failures appear there. -- Francois Gouget <fgouget(a)codeweavers.com>

June 23, 2022

Re: [PATCH v3 3/6] winegstreamer: Implement H264 SetOutputType by reconfiguring the pipeline.

by Marvin

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=117497 Your paranoid android. === w864 (32 bit report) === mf: mf.c:4610: Test failed: Unexpected hr 0x800401f0. === debian11 (32 bit report) === Report validation errors: mf:mf prints too much data (39724 bytes) === debian11 (32 bit WoW report) === Report validation errors: mf:mf prints too much data (39738 bytes)

June 23, 2022

Re: [PATCH v3 1/6] mf/tests: Add todo_wine for newer FFmpeg versions.

by Marvin

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=117495 Your paranoid android. === debian11 (32 bit report) === Report validation errors: mf:mf prints too much data (39698 bytes) === debian11 (32 bit WoW report) === Report validation errors: mf:mf prints too much data (39860 bytes)

June 23, 2022