July 2022 - Wine-Devel - list.winehq.org

Re: [PATCH v2 2/2] ddraw/tests: Add some video memory accounting tests.

by Marvin

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119983 Your paranoid android. === w7u_2qxl (32 bit report) === ddraw: ddraw2.c:7210: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. === w7u_adm (32 bit report) === ddraw: ddraw2.c:7210: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. === w7u_el (32 bit report) === ddraw: ddraw2.c:7210: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7263: Test failed: Failed to get available video memory, hr 0x88760233. ddraw2.c:7285: Test failed: Failed to get available video memory, hr 0x88760233. === w7u_2qxl (32 bit report) === ddraw: ddraw4.c:9112: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. === w7u_adm (32 bit report) === ddraw: ddraw4.c:9112: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. === w7u_el (32 bit report) === ddraw: ddraw4.c:9112: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9165: Test failed: Failed to get available video memory, hr 0x88760233. ddraw4.c:9187: Test failed: Failed to get available video memory, hr 0x88760233. === w7u_2qxl (32 bit report) === ddraw: ddraw7.c:8952: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. === w7u_adm (32 bit report) === ddraw: ddraw7.c:8952: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. === w7u_el (32 bit report) === ddraw: ddraw7.c:8952: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9008: Test failed: Failed to get available video memory, hr 0x88760233. ddraw7.c:9030: Test failed: Failed to get available video memory, hr 0x88760233. === w1064 (32 bit report) === ddraw: ddraw7.c:18884: Test failed: Got unexpected color 0x00000040. === w1064_tsign (32 bit report) === ddraw: ddraw7.c:18884: Test failed: Got unexpected color 0x0000ff00. === debian11 (32 bit Chinese:China report) === Report validation errors: ddraw1: Timeout === debian11 (build log) === WineRunWineTest.pl:error: The task timed out

July 28, 2022

Re: [PATCH v3 5/9] mshtml: Implement lastElementChild for Elements.

by Marvin

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119953 Your paranoid android. === w10pro64 (64 bit report) === mshtml: htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS === w10pro64_ar (64 bit report) === mshtml: htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS htmldoc.c:350: Test failed: expected Exec_SETTITLE htmldoc.c:2859: Test failed: unexpected call Exec_SETTITLE

July 28, 2022

Re: [PATCH v3 4/9] mshtml: Implement hasAttributeNS for Elements.

by Marvin

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119952 Your paranoid android. === w10pro64 (32 bit report) === mshtml: htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS === w1064_2qxl (64 bit report) === mshtml: htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS htmldoc.c:350: Test failed: expected Exec_SETTITLE htmldoc.c:2859: Test failed: unexpected call Exec_SETTITLE === w1064_adm (64 bit report) === mshtml: script.c:3119: Test failed: ReportResult failed: 80ef0001

July 28, 2022

Re: [PATCH v3 3/9] mshtml: Implement removeAttributeNS for Elements.

by Marvin

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119951 Your paranoid android. === w10pro64_en_AE_u8 (64 bit report) === mshtml: htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS

July 28, 2022

Re: [PATCH v4 1/1] d3drm/tests: Show Clear sets background color

by Marvin

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120010 Your paranoid android. === debian11 (32 bit report) === d3drm: d3drm.c:7361: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7380: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7390: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7410: Test failed: Got unexpected color 0x007f7f7f. === debian11 (32 bit Arabic:Morocco report) === d3drm: d3drm.c:7361: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7380: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7390: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7410: Test failed: Got unexpected color 0x007f7f7f. === debian11 (32 bit German report) === d3drm: d3drm.c:7361: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7380: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7390: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7410: Test failed: Got unexpected color 0x007f7f7f. === debian11 (32 bit French report) === d3drm: d3drm.c:7361: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7380: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7390: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7410: Test failed: Got unexpected color 0x007f7f7f. === debian11 (32 bit Hebrew:Israel report) === d3drm: d3drm.c:7361: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7380: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7390: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7410: Test failed: Got unexpected color 0x007f7f7f. === debian11 (32 bit Hindi:India report) === d3drm: d3drm.c:7361: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7380: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7390: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7410: Test failed: Got unexpected color 0x007f7f7f. === debian11 (32 bit Japanese:Japan report) === d3drm: d3drm.c:7361: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7380: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7390: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7410: Test failed: Got unexpected color 0x007f7f7f. === debian11 (32 bit Chinese:China report) === d3drm: d3drm.c:7361: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7380: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7390: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7410: Test failed: Got unexpected color 0x007f7f7f. === debian11 (32 bit WoW report) === d3drm: d3drm.c:7361: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7380: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7390: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7410: Test failed: Got unexpected color 0x007f7f7f. === debian11 (64 bit WoW report) === d3drm: d3drm.c:7361: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7380: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7390: Test failed: Got unexpected color 0x007f7f7f. d3drm.c:7410: Test failed: Got unexpected color 0x007f7f7f.

July 28, 2022

Re: [PATCH v3 2/9] mshtml: Implement setAttributeNS for Elements.

by Marvin

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119950 Your paranoid android. === w10pro64 (32 bit report) === mshtml: htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS

July 28, 2022

Re: [PATCH 5/6] comctl32/listview: Don't send LVN_ODSTATECHANGED for empty ranges.

by Marvin

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119995 Your paranoid android. === debian11 (32 bit report) === comctl32: listview.c:3578: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3595: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3578: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3595: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds === debian11 (32 bit Chinese:China report) === comctl32: listview.c:3578: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3595: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3578: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3595: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds === debian11 (32 bit WoW report) === comctl32: listview.c:3578: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3595: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3578: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3595: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds === debian11 (64 bit WoW report) === comctl32: listview.c:3578: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3595: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3578: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3595: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds

July 28, 2022

Re: [PATCH 4/6] comctl32/listview: Send LVN_ODSTATECHANGED notification for LVS_OWNERDATA listview on selection changes.

by Marvin

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119994 Your paranoid android. === debian11 (32 bit report) === comctl32: listview.c:3578: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3595: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3578: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3595: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds === debian11 (32 bit Chinese:China report) === comctl32: listview.c:3578: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3595: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3578: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3595: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds === debian11 (32 bit WoW report) === comctl32: listview.c:3578: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3595: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3578: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3595: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds === debian11 (64 bit WoW report) === comctl32: listview.c:3578: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3595: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3578: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds listview.c:3595: Test succeeded inside todo block: ownerdata select multiple notification: marked "todo_wine" but succeeds

July 28, 2022

Re: [PATCH v4 5/7] comctl32/listview: Send LVN_ODSTATECHANGED notification.

by Angelo Haller

On 17/07/2022 02.29, Zhiyi Zhang wrote: > > On 7/1/22 01:57, Angelo Haller wrote: >> On 30/06/2022 04.41, Zhiyi Zhang wrote: >>> On 6/29/22 05:16, Angelo Haller wrote: >>>> From: Angelo Haller <angelo(a)szanni.org> >>>> >>>> Send LVN_ODSTATECHANGED notification on selection change for >>>> listviews when LVS_OWNERDATA is set. >>>> >>>> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52534 >>>> Signed-off-by: Angelo Haller <angelo(a)szanni.org> >>>> >>>> --- >>>> v3: Merge nFirst & nLast definition into a single line. >>>> Add function call guard due to preceding patch changes. >>>> --- >>>> dlls/comctl32/listview.c | 16 +++++++++++----- >>>> dlls/comctl32/tests/listview.c | 6 +++--- >>>> 2 files changed, 14 insertions(+), 8 deletions(-) >>>> >>>> diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c >>>> index 5ba1924cbd7..0243d9a84ce 100644 >>>> --- a/dlls/comctl32/listview.c >>>> +++ b/dlls/comctl32/listview.c >>>> @@ -3604,6 +3604,7 @@ static BOOL LISTVIEW_AddGroupSelection(LISTVIEW_INFO *infoPtr, INT nItem) >>>> */ >>>> static void LISTVIEW_SetGroupSelection(LISTVIEW_INFO *infoPtr, INT nItem) >>>> { >>>> + INT nFirst = -1, nLast = -1; >>>> RANGES selection; >>>> DWORD old_mask; >>>> LVITEMW item; >>>> @@ -3655,21 +3656,26 @@ static void LISTVIEW_SetGroupSelection(LISTVIEW_INFO *infoPtr, INT nItem) >>>> iterator_destroy(&i); >>>> } >>>> - /* disable per item notifications on LVS_OWNERDATA style >>>> - FIXME: single LVN_ODSTATECHANGED should be used */ >>>> + /* Disable per item notifications on LVS_OWNERDATA style */ >>>> old_mask = infoPtr->notify_mask & NOTIFY_MASK_ITEM_CHANGE; >>>> if (infoPtr->dwStyle & LVS_OWNERDATA) >>>> infoPtr->notify_mask &= ~NOTIFY_MASK_ITEM_CHANGE; >>>> LISTVIEW_DeselectAllSkipItems(infoPtr, selection); >>>> - >>>> iterator_rangesitems(&i, selection); >>>> - while(iterator_next(&i)) >>>> - LISTVIEW_SetItemState(infoPtr, i.nItem, &item); >>>> + while(iterator_next(&i)) { >>>> + if (nFirst == -1) >>>> + nFirst = i.nItem; >>>> + nLast = i.nItem; >>>> + LISTVIEW_SetItemState(infoPtr, i.nItem, &item); >>>> + } >>> Hi Angelo, >>> >>> This looks like a separate change than what you describe in the subject. Please put it in a separate patch. >> Hi Zhiyi, >> >> thanks for the review. >> >> I believe the patch does exactly what is described in the subject. Maybe I could add another line describing in detail what is being done, as it does not seem entirely clear? Maybe something like: >> >> `Compute the range by determining the first and last item of the selection, then send one LVN_ODSTATECHANGED notification.` ? > Hi Angelo, > > Sorry for the late response. I was busy with other things and kind of forgot about this patch set. I would recommend you to use GitLab in the future so that I know > there is a task assigned to me. > > For the code, add a line of 'Find the range for LVN_ODSTATECHANGED' before 'if (nFirst == -1)' and add an empty line before "LISTVIEW_SetItemState(infoPtr, i.nItem, &item); " should be enough. Hi Zhiyi, I migrated the patches to Gitlab and added the requested comment. Hope things look good now. I don't believe I have the required rights to assign you, so here the link to the Gitlab MR: https://gitlab.winehq.org/wine/wine/-/merge_requests/550 Best, Angelo > > >> The above code changes are for determining what the first and last items are. These are needed for making the call to `LISTVIEW_SetOwnerDataState()`, which is done in the code below. No other function calls are introduced in the patch. >> >> Moving the computation of nFirst and nLast to a different patch would trigger a "set but not used" warning by the compiler. >> >>> Other than the above. There are some typos in 1/7 but I took care of it. I made some changes to the patch series overall >>> and attached them in the mail attachments. Mostly some style fix. You can make your changes on top of them. >> Thanks, I guess I must have missed those even with my spell checker on. >>> Then there are still some message sequences in test_ownerdata_multiselect() that don't pass. It looks like one issue for >>> the rest of the todo_wines and they're probably existing failures. But could you fix them as well? >> Yes, these are existing failures. I believe these should be addressed in a different patch series though. >> >> Windows seems to send some very strange message sequences on ownerdata lists. The current behavior in wine is correct for non ownerdata lists. I believe more rigorous testing for non ownerdata listviews would be needed to not introduce regressions. >> >> All the signals are being sent, it is just that the current sequence does not match Windows fully. I am happy to look into that when I have some extra time, but as previously stated, this will most likely be a similarly sized patch series to this one. > Thank you for looking into it. If the whole series is too large, you can send the whole patch set to email first. Then send the first 5~7 patches to GitLab if they look good. > >>> Thanks for your work. It's much better than the last revision. >> Should I resubmit the patches you attached to the mailing list? Leaving your Signed off intact as long as I do not change the patches? > Yes, feel free to use those patches. Sign-offs are not necessary after the transition to Gitlab. > So you can remove my sign offs. And when you send them through Gitlab, I will approve them if the merge request looks good. > > Thanks, > Zhiyi > >> Best, >> Angelo >> >>> Best Regards, >>> Zhiyi >>> >>> >>>> /* this will also destroy the selection */ >>>> iterator_destroy(&i); >>>> + if (infoPtr->dwStyle & LVS_OWNERDATA) >>>> + LISTVIEW_SetOwnerDataState(infoPtr, nFirst, nLast, &item); >>>> + >>>> infoPtr->notify_mask |= old_mask; >>>> LISTVIEW_SetItemFocus(infoPtr, nItem); >>>> } >>>> diff --git a/dlls/comctl32/tests/listview.c b/dlls/comctl32/tests/listview.c >>>> index 7243a1858cd..d8a27ea18f4 100644 >>>> --- a/dlls/comctl32/tests/listview.c >>>> +++ b/dlls/comctl32/tests/listview.c >>>> @@ -3605,7 +3605,7 @@ static void test_ownerdata_multiselect(void) >>>> expect(0, res); >>>> ok_sequence(sequences, PARENT_ODSTATECHANGED_SEQ_INDEX, >>>> ownerdata_multiselect_select_0_to_1_odstatechanged_seq, >>>> - "ownerdata multiselect: select multiple via SHIFT+DOWN", TRUE); >>>> + "ownerdata multiselect: select multiple via SHIFT+DOWN", FALSE); >>>> res = SendMessageA(hwnd, WM_KEYUP, VK_DOWN, 0); >>>> expect(0, res); >>>> res = SendMessageA(hwnd, LVM_GETSELECTEDCOUNT, 0, 0); >>>> @@ -3633,7 +3633,7 @@ static void test_ownerdata_multiselect(void) >>>> expect(0, res); >>>> ok_sequence(sequences, PARENT_ODSTATECHANGED_SEQ_INDEX, >>>> ownerdata_multiselect_select_0_to_1_odstatechanged_seq, >>>> - "ownerdata multiselect: select multiple via SHIFT+CONTROL+DOWN", TRUE); >>>> + "ownerdata multiselect: select multiple via SHIFT+CONTROL+DOWN", FALSE); >>>> res = SendMessageA(hwnd, WM_KEYUP, VK_DOWN, 0); >>>> expect(0, res); >>>> res = SendMessageA(hwnd, LVM_GETSELECTEDCOUNT, 0, 0); >>>> @@ -3676,7 +3676,7 @@ static void test_ownerdata_multiselect(void) >>>> expect(0, res); >>>> ok_sequence(sequences, PARENT_ODSTATECHANGED_SEQ_INDEX, >>>> ownerdata_multiselect_select_0_to_2_odstatechanged_seq, >>>> - "ownerdata multiselect: select multiple after skip via SHIFT+CONTROL+DOWN", TRUE); >>>> + "ownerdata multiselect: select multiple after skip via SHIFT+CONTROL+DOWN", FALSE); >>>> res = SendMessageA(hwnd, WM_KEYUP, VK_DOWN, 0); >>>> expect(0, res); >>>> res = SendMessageA(hwnd, LVM_GETSELECTEDCOUNT, 0, 0); >>

July 28, 2022

Re: [PATCH v2 9/9] mshtml: Implement HTMLTitleElement's text property.

by Marvin

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119867 Your paranoid android. === w10pro64_ar (64 bit report) === mshtml: htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS === w10pro64_ja (64 bit report) === mshtml: htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS

July 28, 2022