April 2023 - Wine-Devel - list.winehq.org

Wine staging 8.7 release

by Alistair Leslie-Hughes

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 8.7 (530 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * none Added: * none Updated: * wined3d-WINED3DFMT_B8G8R8X8_UNORM Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. * Suggest patches to be included in staging. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

April 30, 2023

Re: Some questions about handling filenames in wineserver

by Jin-oh Kang

On Thu, Apr 20, 2023, 2:11 AM Richard W.M. Jones <rjones(a)redhat.com> wrote: > On Thu, Apr 20, 2023 at 12:58:04AM +0900, Jin-oh Kang wrote: > > On Tue, Apr 18, 2023, 4:44 PM Richard W.M. Jones <rjones(a)redhat.com> > wrote: > > Supplemental question: There appears to be duplicate socket handling > > code in wineserver server/sock.c and dlls/ntdll/unix/socket.c. > > > > > > I don't believe this to be the case. > > > > > > In my > > tests only the wineserver code is called, and never the ntdll/unix > > code. Why is that? > > > > > > This would need further elaboration: which part of dlls/ntdll/unix/* did > you > > expect to be called, but wasn't? > > Thanks for the other tips. > > In the case above I was referring to these pieces of code which both > may be doing conversion to and from Unix sockaddr: > > > https://gitlab.winehq.org/wine/wine/-/blob/9e99c6f66d236101a084b6a3a24c98b5… > > > https://gitlab.winehq.org/wine/wine/-/blob/9e99c6f66d236101a084b6a3a24c98b5… > > They appear identical. In my test only the one in server/sock.c was > called (not that I'm saying the other is never called, just that I > didn't see it). > > Are they used in different circumstances? > The former sockadr_from_unix (in ntdll) seems to be for WS2 getpeername() and recvfrom(). In case you haven't tried, running wine tests should give an idea about which function is called in which scenario. > Rich. > > -- > Richard Jones, Virtualization Group, Red Hat > http://people.redhat.com/~rjones > Read my programming and virtualization blog: http://rwmj.wordpress.com > Fedora Windows cross-compiler. Compile Windows programs, test, and > build Windows installers. Over 100 libraries supported. > http://fedoraproject.org/wiki/MinGW > >

April 25, 2023

Re: Some questions about handling filenames in wineserver

by Richard W.M. Jones

On Thu, Apr 20, 2023 at 12:58:04AM +0900, Jin-oh Kang wrote: > On Tue, Apr 18, 2023, 4:44 PM Richard W.M. Jones <rjones(a)redhat.com> wrote: > Supplemental question: There appears to be duplicate socket handling > code in wineserver server/sock.c and dlls/ntdll/unix/socket.c. > > > I don't believe this to be the case. > > > In my > tests only the wineserver code is called, and never the ntdll/unix > code. Why is that? > > > This would need further elaboration: which part of dlls/ntdll/unix/* did you > expect to be called, but wasn't? Thanks for the other tips. In the case above I was referring to these pieces of code which both may be doing conversion to and from Unix sockaddr: https://gitlab.winehq.org/wine/wine/-/blob/9e99c6f66d236101a084b6a3a24c98b5… https://gitlab.winehq.org/wine/wine/-/blob/9e99c6f66d236101a084b6a3a24c98b5… They appear identical. In my test only the one in server/sock.c was called (not that I'm saying the other is never called, just that I didn't see it). Are they used in different circumstances? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW

April 19, 2023

Re: Some questions about handling filenames in wineserver

by Zeb Figura

On 4/19/23 10:58, Jin-oh Kang wrote: > On Tue, Apr 18, 2023, 4:44 PM Richard W.M. Jones <rjones(a)redhat.com> wrote: > >> I'm trying to bring my old AF_UNIX patch up to date: >> >> https://www.winehq.org/pipermail/wine-devel/2021-May/187049.html >> >> It's not going too well as the code has changed quite a lot. >> > > Yes. A quick overview: > > - dlls/ws2_32/socket.c is the Windows Socket 2 implementation. It acts as a > frontend for the underlying socket implementation (AFD.SYS). > > - dlls/ntdll/unix/socket.c emulates the AFD.SYS driver. It acts as the > backend and does the actual socket I/O. > > - server/sock.c manages socket polling, asynchronous I/O, as well as > overall socket state management. I'm going to nitpick, but this is kind of a false dichotomy. ntdll and server both handle different socket ioctls, or different parts of the same ioctls, and hence can both be said to stand in for afd.sys. What goes in ntdll or the server depends on a few different factors. Some things need to be in the server because they're state shared across multiple processes (e.g. SNDBUF, RCVBUF) that can't be stored in the socket itself (SNDBUF exists on native but doesn't behave the same way). Shutdown handling and socket events need to be in the server for much of the same reason, and hence async I/O management and much of the polling logic does too—but the actual send and recv calls need to be in ntdll since they're using the address space of the process in question. Otherwise, we try to keep things out of the server where possible, both to avoid round trips, and simply to avoid adding more complex code to a component which we try to make a point of keeping robust. > > >> One particular problem I'm having is in wineserver. We need to >> convert the Windows socket path encoded as a UTF-8 string >> (eg. Z:\tmp\sock) into a Unix filename. In the old code I used: >> >> + num = MultiByteToWideChar(CP_UTF8, 0, wun->sun_path, -1, NULL, 0); >> + win_path = HeapAlloc(GetProcessHeap(), 0, num * sizeof(WCHAR)); >> + if (win_path == NULL) >> + return 0; >> + MultiByteToWideChar(CP_UTF8, 0, wun->sun_path, -1, win_path, num); >> + unix_path = wine_get_unix_file_name(win_path); >> + heap_free(win_path); >> >> However none of this seems to work inside wineserver (I guess because >> it's not part of the "Windows world"). I cannot work out the >> equivalent of this for wineserver, or if there's something else I >> should be doing, such as converting the path before it is sent to >> wineserver. >> > > You should be converting the path before sending it to wineserver. The > simplest hack would be using wine_get_unix_file_name() from ws2_32. To add some more context: yes, the server cannot convert between NT and Unix paths. This is not so much due to layering reasons—actually, it would be rather nice if the server could do this—but I believe the main problem is that conversion can involve slow lookups, and we don't want that to block the server. I'm not sure that doing the conversion in ws2_32 is a hack, either. The NT interface is not well defined. Without seeing the code, it may be possible to do conversion either in ws2_32 or in ntdll. > > Note that you can't call wine_get_unix_file_name() from ntdll. That would > constitute violation of abstraction boundary between the Win32 subsystem > (which deals with DOS/Win32 paths) and the NT kernel (which deals with NT > paths in Object Manager). True, but note that we also have wine_unix_to_nt_file_name() in ntdll, or on the Unix side (which is more likely), simply nt_to_unix_file_name(). > > >> Supplemental question: There appears to be duplicate socket handling >> code in wineserver server/sock.c and dlls/ntdll/unix/socket.c. > > > I don't believe this to be the case. Well, there is some duplicated code, yes. For example, socket address conversion is done on both sides. That's not particularly avoidable. --Zeb

April 19, 2023

Re: Some questions about handling filenames in wineserver

by Jin-oh Kang

On Tue, Apr 18, 2023, 4:44 PM Richard W.M. Jones <rjones(a)redhat.com> wrote: > I'm trying to bring my old AF_UNIX patch up to date: > > https://www.winehq.org/pipermail/wine-devel/2021-May/187049.html > > It's not going too well as the code has changed quite a lot. > Yes. A quick overview: - dlls/ws2_32/socket.c is the Windows Socket 2 implementation. It acts as a frontend for the underlying socket implementation (AFD.SYS). - dlls/ntdll/unix/socket.c emulates the AFD.SYS driver. It acts as the backend and does the actual socket I/O. - server/sock.c manages socket polling, asynchronous I/O, as well as overall socket state management. > One particular problem I'm having is in wineserver. We need to > convert the Windows socket path encoded as a UTF-8 string > (eg. Z:\tmp\sock) into a Unix filename. In the old code I used: > > + num = MultiByteToWideChar(CP_UTF8, 0, wun->sun_path, -1, NULL, 0); > + win_path = HeapAlloc(GetProcessHeap(), 0, num * sizeof(WCHAR)); > + if (win_path == NULL) > + return 0; > + MultiByteToWideChar(CP_UTF8, 0, wun->sun_path, -1, win_path, num); > + unix_path = wine_get_unix_file_name(win_path); > + heap_free(win_path); > > However none of this seems to work inside wineserver (I guess because > it's not part of the "Windows world"). I cannot work out the > equivalent of this for wineserver, or if there's something else I > should be doing, such as converting the path before it is sent to > wineserver. > You should be converting the path before sending it to wineserver. The simplest hack would be using wine_get_unix_file_name() from ws2_32. Note that you can't call wine_get_unix_file_name() from ntdll. That would constitute violation of abstraction boundary between the Win32 subsystem (which deals with DOS/Win32 paths) and the NT kernel (which deals with NT paths in Object Manager). > Supplemental question: There appears to be duplicate socket handling > code in wineserver server/sock.c and dlls/ntdll/unix/socket.c. I don't believe this to be the case. In my > tests only the wineserver code is called, and never the ntdll/unix > code. Why is that? > This would need further elaboration: which part of dlls/ntdll/unix/* did you expect to be called, but wasn't? > (I'm not very familiar with the architecture of wine, which seems a > bit confusing, so I'm just guessing how it all works.) > > Rich. > > -- > Richard Jones, Virtualization Group, Red Hat > http://people.redhat.com/~rjones > Read my programming and virtualization blog: http://rwmj.wordpress.com > Fedora Windows cross-compiler. Compile Windows programs, test, and > build Windows installers. Over 100 libraries supported. > http://fedoraproject.org/wiki/MinGW > > > >

April 19, 2023

Some questions about handling filenames in wineserver

by Richard W.M. Jones

I'm trying to bring my old AF_UNIX patch up to date: https://www.winehq.org/pipermail/wine-devel/2021-May/187049.html It's not going too well as the code has changed quite a lot. One particular problem I'm having is in wineserver. We need to convert the Windows socket path encoded as a UTF-8 string (eg. Z:\tmp\sock) into a Unix filename. In the old code I used: + num = MultiByteToWideChar(CP_UTF8, 0, wun->sun_path, -1, NULL, 0); + win_path = HeapAlloc(GetProcessHeap(), 0, num * sizeof(WCHAR)); + if (win_path == NULL) + return 0; + MultiByteToWideChar(CP_UTF8, 0, wun->sun_path, -1, win_path, num); + unix_path = wine_get_unix_file_name(win_path); + heap_free(win_path); However none of this seems to work inside wineserver (I guess because it's not part of the "Windows world"). I cannot work out the equivalent of this for wineserver, or if there's something else I should be doing, such as converting the path before it is sent to wineserver. Supplemental question: There appears to be duplicate socket handling code in wineserver server/sock.c and dlls/ntdll/unix/socket.c. In my tests only the wineserver code is called, and never the ntdll/unix code. Why is that? (I'm not very familiar with the architecture of wine, which seems a bit confusing, so I'm just guessing how it all works.) Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW

April 18, 2023

Re: Wine-Staging 8.6 release

by Zebediah Figura

Hi all, The released Wine-Staging build fails to compile if GStreamer libraries are available. I did not notice this because my development machine was missing them. I've pushed a fix and tagged it as version 8.6.1. Sorry for the inconvenience. --Zeb

April 16, 2023

Wine-Staging 8.6 release

by Zebediah Figura

The Wine-Staging development release 8.6 is now available. Summary since last release: * Rebased to upstream Wine 8.6. 532 patches are applied to upstream Wine. Patches removed from Wine-Staging since the last release: * win32u-GPU_properties * winex11-wglShareLists. This fixed Wine bug 25495 [1], which is not currently fixed by any other mechanism. However, the relevant patch is a hack, and hence not suitable for Wine-Staging either. Patches added: * None. Patches otherwise updated: * None. Binary packages for various distributions will be available from: https://www.winehq.org/download As always, if you find a bug, please report it via https://bugs.winehq.org ἔρρωσθε, Zeb Figura [1] https://bugs.winehq.org/show_bug.cgi?id=25495

April 16, 2023

wine-8.0.1-rc1 Available

by Michael Stefaniuc

Hello, I have pushed wine-8.0.1-rc1 (f7512a4e1236c36d926ff753decf412eb82a6a35) to https://gitlab.winehq.org/mstefani/wine/-/tree/stable https://people.redhat.com/mstefani/wine/stable/ And created the draft merge request https://gitlab.winehq.org/wine/wine/-/merge_requests/2585 After the 7.0.x Stable releases didn't go so well I'm trying for 8.0.x a time based approach: - Include stuff from 4 devel releases, about 2 months worth. - Last included devel release should be out for 1-2 other devel (2 - 4 weeks). - Merge request in draft state for 1-2 weeks. What's new in this release: - Fixes for macOS Ventura 13.3 on Apple Silicon - Tamil and Turkish translation updates - Various bug fixes ---------------------------------------------------------------- Bugs fixed in 8.0,1 (total 36): - #49615 Device read errors logged in dmesg when running wine commands with empty CD/DVD drive, since 5.5 - #51345 Regression: Visual Studio 2005 "package load failure" - #52506 Setup of game "What's the Secret?" fails to create icon - #52878 Free PC Audit 5.1.211.96 fails to show info in 'Brief' tab (needs GetBinaryValue method of the StdRegProv class) - #53274 adsldp:ldap - test_ParseDisplayName() sometimes fails to connect to the server - #53926 New typelib marshaller depends on IID_IDispatch support from target interface - #53981 Chromium broken sandbox due to GetSecurityInfo giving access denied - #54030 Snagit needs Win32_Volume class ( 'select deviceid from win32_volume where driveletter =C:') - #54215 ListView doesn't refresh when changing between List and Details styles. - #54234 vbscript fails to compile when colon follows Else in If...Else - #54289 RtlCopyContext buffer overflow - #54318 Rich Edit inserts newly composed text at wrong position when system IME composition ends while a selection is active - #54337 AviUtl shows Japanese text as garbage after conversion in ExEdit edit box - #54353 crypt32:cert - testVerifyRevocation() gets unexpected success in Wine on second run - #54357 Spurious fixme message when calling ScrollWindow() - #54364 RtlGenRandom fails on systems with more than 128 cores - #54371 loader won't launch from PATH unless named "wine" - #54376 ws2_32:sock - test_reuseaddr() overflows a sockaddr variable by reading an AF_INET6 peer name into it - #54379 since wine 8.0 print doesn't work any more - #54432 Missing ntdll.RtlAddressInSectionTable() implementation causes all GraalVM Native Image exes to crash on load - #54449 nethack crashes - #54456 vbscript memory leak in For Each with SafeArray as group - #54457 vbscript memory leaks in interp_redim_preserve - #54458 vbscript memory leaks in Global_Split - #54489 VarAbs() does not handle BSTR arguments correctly - #54490 vbscript fails to compile when statement follows ElseIf - #54493 vbscript fails to compile concat when used without space and expression begins with H - #54495 Motorola Ready For Assistant does not start, needs ext-ms-win-networking-wlanapi-l1-1-0.dll - #54563 The gif is displaying wrongly, with weird backgrounds of various colors - #54564 Rich Edit crashes when Ctrl+Right is pressed at past the final paragraph - #54570 Saints Row: The Third heavy rain causes heavy fps reductions - #54581 SpeedCommander 20 installer crashes on unimplemented function SHELL32.dll.Shell_GetCachedImageIndexW - #54617 KakaoTalk IM text edit window leaves artifacts when the text overflows and scroll bar appears - #54663 ldp.exe crashes on unimplemented function wldap32.dll.ldap_set_dbg_flags - #54690 ldp.exe crashes when attempting to connect to an invalid host - #54707 adsldp:ldap - test_DirectorySearch() fails on Windows and Linux ---------------------------------------------------------------- Changes since 8.0: Akihiro Sagawa (2): user32/tests: Add DBCS WM_CHAR tests for edit control. user32/edit: Fix WM_CHAR handler for double-byte characters. Alex Henrie (5): shell32: Add support for Program Manager icons with arguments. wldap32: Add ldap_set_dbg_flags stub. wldap32: Handle null LDAPMessage in ldap_count_entries. wldap32: Handle null LDAPMessage in ldap_parse_result. server: Fix buffer overrun in map_view handler. Alexandre Julliard (2): gitlab: Add workaround for more strict git ownership check. ntdll: Prefer the ntdll path over argv[0] on platforms without reliable exe information. Alistair Leslie-Hughes (1): mountmgr.sys: Don't attempt to read from invalid media. Brendan Shanks (7): loader: In macOS preloader, move the top-down allocations area down. loader: In macOS preloader, stop using mincore() to test if a region is empty. server: On macOS, fake debug registers when running under Rosetta. ntdll: Add a WARN when setting debug registers fails under Rosetta. loader: In macOS preloader, fix an environment variable sometimes being lost. taskmgr: Use exit code 1 when terminating processes. taskkill: Use exit code 1 when terminating processes. Carlos Rodriguez (1): wined3d: Add GPU information for another Intel UHD 630 GPU. Dmitry Timoshkov (3): win32u: Give full access rights to the process window station. win32u: Give full access rights to the thread desktop. rpcrt4: Mark the buffer as invalid in NdrProxyFreeBuffer(). Eric Pouech (3): ntdll: Implement RtlAddressInSectionTable. conhost: Only update font when running with a window. winedbg: Use debuggee's bitness for 'examine /a' command. Florian Will (2): gdiplus/tests: Test for GdipPrivateAddFontFile() sharing violation. gdiplus: Use FILE_SHARE_READ in GdipPrivateAddFontFile(). Gabriel Ivăncescu (1): jscript: Fix jsstr leak after changing variant type to BSTR. Gijs Vermeulen (1): shell32: Add Shell_GetCachedImageIndexA/W exports. Giovanni Mascellani (1): wbemprox: Do not call Release() inside wbemprox_cf_CreateInstance(). Hans Leidekker (8): wbemprox: Implement GetBinaryValue() method. adsldp/tests: Avoid test failures when the server is down. wbemprox: Implement Win32_Volume. advapi32: Bump random buffer size. msi: Install and patch global assemblies in InstallFinalize. msi: Perform late initialization of the assembly caches. adsldp/tests: Skip all remaining tests when the server is down. adsldp/tests: Fix test failures. Hugh McMaster (2): regedit: Allow export_key() to return TRUE. regedit: Append '.reg' file extension if necessary. Illia Polishchuk (2): d3d9/tests: Add test for non-indexed instancing drawing. d3d9: Always draw only a single instance for non-indexed draws. Jacek Caban (2): win32u: Silence spurious FIXME in NtUserScrollWindowEx. oleaut32: Remove overflow check for VT_R4 and VT_R8 in VarAbs. Jason Millard (7): vbscript: Fix compile when colon follows Else on new line. vbscript: Fix memory leak in owned safearray iterator. vbscript: Fix memory leak in Split(). vbscript: Fix memory leak in Split(). oleaut32: Fix VarAbs function for BSTR with positive values. vbscript: Fix compile when statement after ElseIf or after separator. vbscript: Fix compile issue with non hex after concat without space. Jinoh Kang (7): ws2_32/test: Fix sockaddr buffer overflow in test_reuseaddr. riched20: Obtain the composition start index after deleting selection. riched20/tests: Test for word movement across paragraph boundary. riched20: Don't set para unless committing cursor move in ME_MoveCursorWords. riched20/tests: Test for ITextDocument::Freeze and ITextDocument::Unfreeze. riched20: Don't assume that TxDraw preserves the device context's brush selection. riched20: Implement ITextDocument::Freeze and ITextDocument::Unfreeze. K.B.Dharun Krishna (1): po: Update Tamil translation. Michael Stefaniuc (2): tools: Get the ANNOUNCE bug list from the stable-notes git notes. gitlab: Do not run the build script on each commit. Nikolay Sivov (1): apisetschema: Add ext-ms-win-networking-wlanapi-l1-1-0. Paul Gofman (5): ntdll: Factor out context_copy_ranges() function. ntdll: Do not use extended context in RtlCopyContext() if extended state is not copied. cryptnet: Cache revocation status in verify_cert_revocation(). cryptnet: Use cert data hash as cache id instead of serial number. cryptnet: Also hash issuer cert for cache id. Piotr Caban (7): msvcrt: Don't crash on NULL argument in getenv. msvcrt: Don't crash on NULL argument in _wgetenv. msvcrt: Improve error handling in getenv_s. msvcrt: Improve error handling in _wgetenv_s. winspool: Fix FILE: output handling in StartDocDlgW. localspl: Ignore an empty output string. gdiplus: Use transparency instead of background color if transparent color flag is set in GIF GCE. Rémi Bernon (2): dwrite: Statically init the system_fallback locale list. services: Use a separate allocation for NotifyParamsArray[0].params. Serkan Önder (1): po: Update Turkish translation. Tingzhong Luo (1): evr: Fix crash when clearing input type for the mixer. Zebediah Figura (1): oleaut32: Manually construct a stub buffer for dispinterfaces. Zhiyi Zhang (3): comctl32/tests: Add WM_STYLECHANGED tests for changing listview view styles. comctl32/listview: Repaint when changing view styles. user32/tests: Test winstation and desktop access rights. bye michael

April 5, 2023

Wine CE 8.5 Released, Cross Architecture Windows Emulator, Support Wow64, Base on wine and qemu

by fanwj＠mail.ustc.edu.cn

Wine CE is a compatibility layer capable of running Windows applications on Cross-architecture paltform of Linux, It base on wine and qemu, and support aarch64 and riscv64 Linux. It can emulate x86(32bit) x64, aarch64 windows app. Project Address: https://gitlab.com/wine-ce/wine-ce Binary Downnload: https://gitlab.com/wine-ce/wine-ce/-/releases/v8.5 Demo Video: RISCV 64: https://www.bilibili.com/video/BV1gv4y1578t AARCH 64: https://www.bilibili.com/video/BV1yc41157iS

April 3, 2023