March 2025 - Wine-Devel - list.winehq.org

Wine staging 10.4 release

by Alistair Leslie-Hughes

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 10.4 (341 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * d3dx9: Implement d3dx_effect_SetRawValue. * d3dx9/tests: Implement tests for d3dx_effect_SetRawValue(). * winex11.drv: Don't use MWM_DECOR_RESIZEH, window resizing is controlled by MWM_FUNC_RESIZE. * winex11.drv: Don't add MWM_DECOR_BORDER to windows without a caption. * winex11: Fix alpha blending in X11DRV_UpdateLayeredWindow. Removed (No longer required). * None Added: * msxml3: Correct regression when looping element properties. Updated: * vkd3d-latest * Staging Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. * Suggest patches to be included in staging. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

March 22, 2025

Re: [PATCH 1/4] selftests: ntsync: fix the wrong condition in wake_all

by Elizabeth Figura

On Saturday, 15 March 2025 04:39:46 CDT Dan Carpenter wrote: > On Fri, Mar 14, 2025 at 05:13:50PM -0500, Elizabeth Figura wrote: > > On Friday, 14 March 2025 05:14:30 CDT Su Hui wrote: > > > On 2025/3/14 17:21, Dan Carpenter wrote: > > > > On Fri, Mar 14, 2025 at 03:14:51PM +0800, Su Hui wrote: > > > >> When 'manual=false' and 'signaled=true', then expected value when using > > > >> NTSYNC_IOC_CREATE_EVENT should be greater than zero. Fix this typo error. > > > >> > > > >> Signed-off-by: Su Hui<suhui(a)nfschina.com> > > > >> --- > > > >> tools/testing/selftests/drivers/ntsync/ntsync.c | 2 +- > > > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > >> > > > >> diff --git a/tools/testing/selftests/drivers/ntsync/ntsync.c b/tools/testing/selftests/drivers/ntsync/ntsync.c > > > >> index 3aad311574c4..bfb6fad653d0 100644 > > > >> --- a/tools/testing/selftests/drivers/ntsync/ntsync.c > > > >> +++ b/tools/testing/selftests/drivers/ntsync/ntsync.c > > > >> @@ -968,7 +968,7 @@ TEST(wake_all) > > > >> auto_event_args.manual = false; > > > >> auto_event_args.signaled = true; > > > >> objs[3] = ioctl(fd, NTSYNC_IOC_CREATE_EVENT, &auto_event_args); > > > >> - EXPECT_EQ(0, objs[3]); > > > >> + EXPECT_LE(0, objs[3]); > > > > It's kind of weird how these macros put the constant on the left. > > > > It returns an "fd" on success. So this look reasonable. It probably > > > > won't return the zero fd so we could probably check EXPECT_LT()? > > > Agreed, there are about 29 items that can be changed to EXPECT_LT(). > > > I can send a v2 patchset with this change if there is no more other > > > suggestions. > > > > I personally think it looks wrong to use EXPECT_LT(), but I'll certainly > > defer to a higher maintainer on this point. > > I'm not sure I understand what you are saying. Are you saying that we > should allow zero as an expected file descriptor here? I don't have > strong feelings about that either way. Yes, my apologies for the ambiguous wording. That is, EXPECT_LE looks more correct to me than EXPECT_LT per se. > Putting variables on the right, Yoda speak is. Unnatural is. Yes, I certainly agree with this. I wrote it this way in the first place because I was following some other example, I forget which. > I did a git grep and the KUNIT_EXPECT_LT() just calls the parameters > left and right instead of "expected" and "seen". Expected is wrong > for LT because we expect it to be != to the expected value. It's > the opposite. We're expecting the unexpected! It would be better > to just call them left and right. > > regards, > dan carpenter >

March 15, 2025

Re: [PATCH 1/4] selftests: ntsync: fix the wrong condition in wake_all

by Elizabeth Figura

On Friday, 14 March 2025 05:14:30 CDT Su Hui wrote: > On 2025/3/14 17:21, Dan Carpenter wrote: > > On Fri, Mar 14, 2025 at 03:14:51PM +0800, Su Hui wrote: > >> When 'manual=false' and 'signaled=true', then expected value when using > >> NTSYNC_IOC_CREATE_EVENT should be greater than zero. Fix this typo error. > >> > >> Signed-off-by: Su Hui<suhui(a)nfschina.com> > >> --- > >> tools/testing/selftests/drivers/ntsync/ntsync.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/tools/testing/selftests/drivers/ntsync/ntsync.c b/tools/testing/selftests/drivers/ntsync/ntsync.c > >> index 3aad311574c4..bfb6fad653d0 100644 > >> --- a/tools/testing/selftests/drivers/ntsync/ntsync.c > >> +++ b/tools/testing/selftests/drivers/ntsync/ntsync.c > >> @@ -968,7 +968,7 @@ TEST(wake_all) > >> auto_event_args.manual = false; > >> auto_event_args.signaled = true; > >> objs[3] = ioctl(fd, NTSYNC_IOC_CREATE_EVENT, &auto_event_args); > >> - EXPECT_EQ(0, objs[3]); > >> + EXPECT_LE(0, objs[3]); > > It's kind of weird how these macros put the constant on the left. > > It returns an "fd" on success. So this look reasonable. It probably > > won't return the zero fd so we could probably check EXPECT_LT()? > Agreed, there are about 29 items that can be changed to EXPECT_LT(). > I can send a v2 patchset with this change if there is no more other > suggestions. I personally think it looks wrong to use EXPECT_LT(), but I'll certainly defer to a higher maintainer on this point.

March 14, 2025

Re: [PATCH 4/4] docs: ntsync: update NTSYNC_IOC_*

by Elizabeth Figura

On Friday, 14 March 2025 02:14:54 CDT Su Hui wrote: > Some macros in the document do not match the code and the header files, > correct these macros according to the definitions in the code. > > Signed-off-by: Su Hui <suhui(a)nfschina.com> > --- > Documentation/userspace-api/ntsync.rst | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/Documentation/userspace-api/ntsync.rst b/Documentation/userspace-api/ntsync.rst > index 25e7c4aef968..969774bf4c60 100644 > --- a/Documentation/userspace-api/ntsync.rst > +++ b/Documentation/userspace-api/ntsync.rst > @@ -152,9 +152,9 @@ The ioctls on the device file are as follows: > > The ioctls on the individual objects are as follows: > > -.. c:macro:: NTSYNC_IOC_SEM_POST > +.. c:macro:: NTSYNC_IOC_SEM_RELEASE > > - Post to a semaphore object. Takes a pointer to a 32-bit integer, > + Release a semaphore object. Takes a pointer to a 32-bit integer, > which on input holds the count to be added to the semaphore, and on > output contains its previous count. > > @@ -186,7 +186,7 @@ The ioctls on the individual objects are as follows: > unowned and signaled, and eligible threads waiting on it will be > woken as appropriate. > > -.. c:macro:: NTSYNC_IOC_SET_EVENT > +.. c:macro:: NTSYNC_IOC_EVENT_SET > > Signal an event object. Takes a pointer to a 32-bit integer, which on > output contains the previous state of the event. > @@ -194,12 +194,12 @@ The ioctls on the individual objects are as follows: > Eligible threads will be woken, and auto-reset events will be > designaled appropriately. > > -.. c:macro:: NTSYNC_IOC_RESET_EVENT > +.. c:macro:: NTSYNC_IOC_EVENT_RESET > > Designal an event object. Takes a pointer to a 32-bit integer, which > on output contains the previous state of the event. > > -.. c:macro:: NTSYNC_IOC_PULSE_EVENT > +.. c:macro:: NTSYNC_IOC_EVENT_PULSE > > Wake threads waiting on an event object while leaving it in an > unsignaled state. Takes a pointer to a 32-bit integer, which on > @@ -213,7 +213,7 @@ The ioctls on the individual objects are as follows: > afterwards, and a simultaneous read operation will always report the > event as unsignaled. > > -.. c:macro:: NTSYNC_IOC_READ_SEM > +.. c:macro:: NTSYNC_IOC_SEM_READ > > Read the current state of a semaphore object. Takes a pointer to > struct :c:type:`ntsync_sem_args`, which is used as follows: > @@ -225,7 +225,7 @@ The ioctls on the individual objects are as follows: > * - ``max`` > - On output, contains the maximum count of the semaphore. > > -.. c:macro:: NTSYNC_IOC_READ_MUTEX > +.. c:macro:: NTSYNC_IOC_MUTEX_READ > > Read the current state of a mutex object. Takes a pointer to struct > :c:type:`ntsync_mutex_args`, which is used as follows: > @@ -242,7 +242,7 @@ The ioctls on the individual objects are as follows: > ``EOWNERDEAD``. In this case, ``count`` and ``owner`` are set to > zero. > > -.. c:macro:: NTSYNC_IOC_READ_EVENT > +.. c:macro:: NTSYNC_IOC_EVENT_READ > > Read the current state of an event object. Takes a pointer to struct > :c:type:`ntsync_event_args`, which is used as follows: > @@ -255,7 +255,7 @@ The ioctls on the individual objects are as follows: > - On output, contains 1 if the event is a manual-reset event, > and 0 otherwise. > > -.. c:macro:: NTSYNC_IOC_KILL_OWNER > +.. c:macro:: NTSYNC_IOC_MUTEX_KILL > > Mark a mutex as unowned and abandoned if it is owned by the given > owner. Takes an input-only pointer to a 32-bit integer denoting the > Reviewed-by: Elizabeth Figura <zfigura(a)codeweavers.com>

March 14, 2025

Re: [PATCH 3/4] selftests: ntsync: update config

by Elizabeth Figura

On Friday, 14 March 2025 02:14:53 CDT Su Hui wrote: > ntsync should be tested when CONFIG_NTSYNC is setting rather than > CONFIG_WINESYNC, correct this. > > Signed-off-by: Su Hui <suhui(a)nfschina.com> > --- > tools/testing/selftests/drivers/ntsync/config | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/drivers/ntsync/config b/tools/testing/selftests/drivers/ntsync/config > index 60539c826d06..0aa68de147af 100644 > --- a/tools/testing/selftests/drivers/ntsync/config > +++ b/tools/testing/selftests/drivers/ntsync/config > @@ -1 +1 @@ > -CONFIG_WINESYNC=y > +CONFIG_NTSYNC=y > Reviewed-by: Elizabeth Figura <zfigura(a)codeweavers.com>

March 14, 2025

Re: [PATCH 2/4] selftests: ntsync: avoid possible overflow in 32-bit machine

by Elizabeth Figura

On Friday, 14 March 2025 02:14:52 CDT Su Hui wrote: > When using '-m32' flag to compile this test with gcc, there are some > errors when running test: > > ntsync.c:785:wake_any:Expected ETIMEDOUT (110) == ret (0) > ntsync.c:823:wake_any:Expected (1) (1) == __count (0) > ... > FAILED: 7 / 11 tests passed. > Totals: pass:7 fail:4 xfail:0 xpass:0 skip:0 error:0 > > There is an overflow about 'timeout'. 'timespec->tv_sec' is 4 bytes in > 32-bit machine. And 'timeout.tv_sec * 1000000000' causing the overflow > problem, adding a cast to avoid this problem. > > Signed-off-by: Su Hui <suhui(a)nfschina.com> > --- > tools/testing/selftests/drivers/ntsync/ntsync.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/drivers/ntsync/ntsync.c b/tools/testing/selftests/drivers/ntsync/ntsync.c > index bfb6fad653d0..ded83dc58e6b 100644 > --- a/tools/testing/selftests/drivers/ntsync/ntsync.c > +++ b/tools/testing/selftests/drivers/ntsync/ntsync.c > @@ -103,7 +103,7 @@ static int wait_objs(int fd, unsigned long request, __u32 count, > > clock_gettime(CLOCK_MONOTONIC, &timeout); > > - args.timeout = timeout.tv_sec * 1000000000 + timeout.tv_nsec; > + args.timeout = (__u64)timeout.tv_sec * 1000000000 + timeout.tv_nsec; > args.count = count; > args.objs = (uintptr_t)objs; > args.owner = owner; > @@ -729,7 +729,7 @@ static __u64 get_abs_timeout(unsigned int ms) > { > struct timespec timeout; > clock_gettime(CLOCK_MONOTONIC, &timeout); > - return (timeout.tv_sec * 1000000000) + timeout.tv_nsec + (ms * 1000000); > + return ((__u64)timeout.tv_sec * 1000000000) + timeout.tv_nsec + (ms * 1000000); > } > > static int wait_for_thread(pthread_t thread, unsigned int ms) > Reviewed-by: Elizabeth Figura <zfigura(a)codeweavers.com>

March 14, 2025

Re: [PATCH 1/4] selftests: ntsync: fix the wrong condition in wake_all

by Elizabeth Figura

On Friday, 14 March 2025 02:14:51 CDT Su Hui wrote: > When 'manual=false' and 'signaled=true', then expected value when using > NTSYNC_IOC_CREATE_EVENT should be greater than zero. Fix this typo error. > > Signed-off-by: Su Hui <suhui(a)nfschina.com> > --- > tools/testing/selftests/drivers/ntsync/ntsync.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/drivers/ntsync/ntsync.c b/tools/testing/selftests/drivers/ntsync/ntsync.c > index 3aad311574c4..bfb6fad653d0 100644 > --- a/tools/testing/selftests/drivers/ntsync/ntsync.c > +++ b/tools/testing/selftests/drivers/ntsync/ntsync.c > @@ -968,7 +968,7 @@ TEST(wake_all) > auto_event_args.manual = false; > auto_event_args.signaled = true; > objs[3] = ioctl(fd, NTSYNC_IOC_CREATE_EVENT, &auto_event_args); > - EXPECT_EQ(0, objs[3]); > + EXPECT_LE(0, objs[3]); > > wait_args.timeout = get_abs_timeout(1000); > wait_args.objs = (uintptr_t)objs; > Reviewed-by: Elizabeth Figura <zfigura(a)codeweavers.com>

March 14, 2025

Re: Testbot since the weekend not reachable

by Bernhard Übelacker

Short addition: Temporarily increasing my Firefox settings network.http.connection-timeout and network.http.tls-handshake-timeout makes the overview page load after several minutes. Probably deleting these 5900 "[wine-devel]" queued jobs might get Testbot back to normal operation? Kind regards, Bernhard Am 11.03.25 um 11:20 schrieb Ziqing Hui: > I can't access testbot either. > > On 3/11/25 17:47, Bernhard Übelacker wrote: >> Hello, >> is someone else also experiencing issues when accessing testbot.winehq.org? >> This seems to have caused missing results for the Friday tests run. >> >> Today in my browser still no results get shown. >> >> Querying via wget it shows data gets delivered after 3 minutes. >> The resulting page looks like at Friday got 5900 jobs queued (151728 to 157632). >> These jobs are all prefixed with [wine-devel], like if there >> was a jam in the patch submission? >> >> Kind regards, >> Bernhard >> >> >> $ LANG=C wget -O testbot.html https://testbot.winehq.org/ 2>&1 | ts '%Y-%m-%d %H:%M:%S:' >> 2025-03-11 09:55:15: --2025-03-11 09:55:15-- https://testbot.winehq.org/ >> 2025-03-11 09:55:15: Resolving testbot.winehq.org (testbot.winehq.org) 104.130.219.87, 2001:4801:7828:101:be76:4eff:fe10:1727 >> 2025-03-11 09:56:20: Connecting to testbot.winehq.org (testbot.winehq.org)|104.130.219.87|:443... connected. >> 2025-03-11 09:58:00: HTTP request sent, awaiting response... 200 OK >> 2025-03-11 09:58:00: Length: unspecified [text/html] >> 2025-03-11 09:58:00: Saving to: 'testbot.html' >> 2025-03-11 09:58:00: >> 2025-03-11 09:58:00: 0K .......... .......... .......... .......... .......... 187K >> 2025-03-11 09:58:00: 50K .......... .......... .......... .......... .......... 236K >> ... >> 2025-03-11 09:58:11: 2350K .......... .......... .......... .......... .......... 349K >> 2025-03-11 09:58:13: 2400K .......... .......... 8.99K=13s >> 2025-03-11 09:58:13: >> 2025-03-11 09:58:13: 2025-03-11 09:58:13 (188 KB/s) - 'testbot.html' saved [2478249] >> 2025-03-11 09:58:13: >> >> > >

March 11, 2025

Re: Powrprof patches

by robert lippmann

Some more follow up questions: The registry keys are initially created during Windows installation. So, I would add them to wine.inf.in. When is this run? Every boot where wine.inf changes? Hard to tell from the docs. If so, and I set a default power profile (it’s just a value in the registry key), will it get overwritten? Also, the existing code puts semaphores around registry access for some reason (it is 20 year old code). I assume that is no longer necessary? Thanks, Rob

March 11, 2025

Re: Testbot since the weekend not reachable

by Ziqing Hui

I can't access testbot either. On 3/11/25 17:47, Bernhard Übelacker wrote: > Hello, > is someone else also experiencing issues when accessing testbot.winehq.org? > This seems to have caused missing results for the Friday tests run. > > Today in my browser still no results get shown. > > Querying via wget it shows data gets delivered after 3 minutes. > The resulting page looks like at Friday got 5900 jobs queued (151728 to 157632). > These jobs are all prefixed with [wine-devel], like if there > was a jam in the patch submission? > > Kind regards, > Bernhard > > > $ LANG=C wget -O testbot.html https://testbot.winehq.org/ 2>&1 | ts '%Y-%m-%d %H:%M:%S:' > 2025-03-11 09:55:15: --2025-03-11 09:55:15-- https://testbot.winehq.org/ > 2025-03-11 09:55:15: Resolving testbot.winehq.org (testbot.winehq.org) 104.130.219.87, 2001:4801:7828:101:be76:4eff:fe10:1727 > 2025-03-11 09:56:20: Connecting to testbot.winehq.org (testbot.winehq.org)|104.130.219.87|:443... connected. > 2025-03-11 09:58:00: HTTP request sent, awaiting response... 200 OK > 2025-03-11 09:58:00: Length: unspecified [text/html] > 2025-03-11 09:58:00: Saving to: 'testbot.html' > 2025-03-11 09:58:00: > 2025-03-11 09:58:00: 0K .......... .......... .......... .......... .......... 187K > 2025-03-11 09:58:00: 50K .......... .......... .......... .......... .......... 236K > ... > 2025-03-11 09:58:11: 2350K .......... .......... .......... .......... .......... 349K > 2025-03-11 09:58:13: 2400K .......... .......... 8.99K=13s > 2025-03-11 09:58:13: > 2025-03-11 09:58:13: 2025-03-11 09:58:13 (188 KB/s) - 'testbot.html' saved [2478249] > 2025-03-11 09:58:13: > >

March 11, 2025

Testbot since the weekend not reachable

by Bernhard Übelacker

Hello, is someone else also experiencing issues when accessing testbot.winehq.org? This seems to have caused missing results for the Friday tests run. Today in my browser still no results get shown. Querying via wget it shows data gets delivered after 3 minutes. The resulting page looks like at Friday got 5900 jobs queued (151728 to 157632). These jobs are all prefixed with [wine-devel], like if there was a jam in the patch submission? Kind regards, Bernhard $ LANG=C wget -O testbot.html https://testbot.winehq.org/ 2>&1 | ts '%Y-%m-%d %H:%M:%S:' 2025-03-11 09:55:15: --2025-03-11 09:55:15-- https://testbot.winehq.org/ 2025-03-11 09:55:15: Resolving testbot.winehq.org (testbot.winehq.org) 104.130.219.87, 2001:4801:7828:101:be76:4eff:fe10:1727 2025-03-11 09:56:20: Connecting to testbot.winehq.org (testbot.winehq.org)|104.130.219.87|:443... connected. 2025-03-11 09:58:00: HTTP request sent, awaiting response... 200 OK 2025-03-11 09:58:00: Length: unspecified [text/html] 2025-03-11 09:58:00: Saving to: 'testbot.html' 2025-03-11 09:58:00: 2025-03-11 09:58:00: 0K .......... .......... .......... .......... .......... 187K 2025-03-11 09:58:00: 50K .......... .......... .......... .......... .......... 236K ... 2025-03-11 09:58:11: 2350K .......... .......... .......... .......... .......... 349K 2025-03-11 09:58:13: 2400K .......... .......... 8.99K=13s 2025-03-11 09:58:13: 2025-03-11 09:58:13: 2025-03-11 09:58:13 (188 KB/s) - 'testbot.html' saved [2478249] 2025-03-11 09:58:13:

March 11, 2025

Re: Apple Silicon compilation

by Elizabeth Figura

On Monday, March 10, 2025 9:54:18 PM Central Daylight Time robert lippmann wrote: > > * MacOS won't allow you to map anything below 4 GB, so Wine can't place > > the > > KSHARED_USER_DATA at 0x7ffe0000. > > Actually, Windows doesn’t do that anymore on 64 bit systems: > > https://msrc.microsoft.com/blog/2022/04/randomizing-the-kuser_shared_data-st > ructure-on-windows/ That's not quite what you think. Microsoft can't actually move the KUSD without breaking things in both the user and the kernel; it's de facto API. Rather, what they did is make the *kernel* page read-only (the user page was already read-only), and map a writable copy at a different address (the kernel page needs to be writable so that the kernel can update dynamic fields like time). This doesn't help us because we still need to map the read-only page.

March 11, 2025

Re: Apple Silicon compilation

by Dean Greer

It’s not a great idea to use too many macOS only functions over FOSS Unix libraries when possible. Wine used to use way more macOS backends and those quickly became broken and took a lot of convincing to remove said dead code. On Mon, Mar 10, 2025 at 10:54 PM robert lippmann < robert.lippmann.development(a)gmail.com> wrote: > > * MacOS won't allow you to map anything below 4 GB, so Wine can't place the > > KSHARED_USER_DATA at 0x7ffe0000. > > > Actually, Windows doesn’t do that anymore on 64 bit systems: > > msrc.microsoft.com > <https://msrc.microsoft.com/blog/2022/04/randomizing-the-kuser_shared_data-s…> > > <https://msrc.microsoft.com/blog/2022/04/randomizing-the-kuser_shared_data-s…> > <https://msrc.microsoft.com/blog/2022/04/randomizing-the-kuser_shared_data-s…> > > > * ARM MacOS has 16 kb pages whereas Windows has 4kb ones. > > > Yeah, that seems to be the sticking point. Asahi has that problem too. > > I’ve been thinking about that, and was wondering if it might just be a > better idea to delegate functions to their UIKit/Foundation/whatever > frameworks. > > It would probably need to be a fork, since Wine can’t have objective C > code (and Apple is moving to Swift anyway). > > Or, I saw this for making Cocoa C bindings: > [image: c_ocoa.png] > > FelixK15/c_ocoa <https://github.com/FelixK15/c_ocoa> > github.com <https://github.com/FelixK15/c_ocoa> > <https://github.com/FelixK15/c_ocoa> > > > >

March 11, 2025

Re: Apple Silicon compilation

by robert lippmann

> > * MacOS won't allow you to map anything below 4 GB, so Wine can't place the > KSHARED_USER_DATA at 0x7ffe0000. > Actually, Windows doesn’t do that anymore on 64 bit systems: https://msrc.microsoft.com/blog/2022/04/randomizing-the-kuser_shared_data-s… > * ARM MacOS has 16 kb pages whereas Windows has 4kb ones. > Yeah, that seems to be the sticking point. Asahi has that problem too. I’ve been thinking about that, and was wondering if it might just be a better idea to delegate functions to their UIKit/Foundation/whatever frameworks. It would probably need to be a fork, since Wine can’t have objective C code (and Apple is moving to Swift anyway). Or, I saw this for making Cocoa C bindings: https://github.com/FelixK15/c_ocoa FelixK15/c_ocoa github.com

March 11, 2025

Re: Wine compatibility checking tool

by Elizabeth Figura

On Monday, 10 March 2025 14:55:47 CDT robert lippmann wrote: > > > > > Relatively few bugs are actually because a missing or stub export. Just because the export is there doesn't mean it behaves the way the application expects. > > > > And not everything an application imports is actually called. That's why we have the @stub lines in the first place. It shuts up a lot of spam at program load time and still writes clear information when the function is actually called. FIXME lines/warnings aren't free - they tend to mislead users into thinking the crash is because of the last FIXME they saw. > > > > Library imports also don't find COM interfaces used. > > Ah, that’s what I was wondering. I must have found a rare case of an application that uses a rarely used part of the Win32 SDK which hasn’t been implemented yet. > > I don't know if I'd call it rare necessarily; it happens fairly often (as you can tell by the number of new stubs that show up on the list), but the amount of development time it takes up is certainly proportionally minuscule. I would simply say that the compatibility checking tool you're describing already exists, and is called "Wine". It's overwhelmingly clear when a program fails that way.

March 10, 2025

Re: Wine compatibility checking tool

by robert lippmann

> > Relatively few bugs are actually because a missing or stub export. Just because the export is there doesn't mean it behaves the way the application expects. > > And not everything an application imports is actually called. That's why we have the @stub lines in the first place. It shuts up a lot of spam at program load time and still writes clear information when the function is actually called. FIXME lines/warnings aren't free - they tend to mislead users into thinking the crash is because of the last FIXME they saw. > > Library imports also don't find COM interfaces used. Ah, that’s what I was wondering. I must have found a rare case of an application that uses a rarely used part of the Win32 SDK which hasn’t been implemented yet.

March 10, 2025

Re: Wine compatibility checking tool

by Stefan Dösinger

> Am 10.03.2025 um 21:29 schrieb robert lippmann <robert.lippmann.development(a)gmail.com>: > > I was thinking more to pro-actively determine if a program might crash so that wine developers can (possibly) focus efforts on implementing those stub functions to increase overall app compatibility. Relatively few bugs are actually because a missing or stub export. Just because the export is there doesn't mean it behaves the way the application expects. And not everything an application imports is actually called. That's why we have the @stub lines in the first place. It shuts up a lot of spam at program load time and still writes clear information when the function is actually called. FIXME lines/warnings aren't free - they tend to mislead users into thinking the crash is because of the last FIXME they saw. Library imports also don't find COM interfaces used.

March 10, 2025

Re: Wine compatibility checking tool

by robert lippmann

I was thinking more to pro-actively determine if a program might crash so that wine developers can (possibly) focus efforts on implementing those stub functions to increase overall app compatibility. > On Mar 10, 2025, at 12:05 PM, Esme Povirk <esme(a)codeweavers.com> wrote: > > I don't think it'd be very useful, at least for understanding crashes. If the program actually calls those functions before the crash, there will be a fixme or exception that tells us that (with the possible exception of using GetProcAddress, but we can't detect that from a PE image anyway). > > On 2025-03-09 22:49, robert lippmann wrote: >> Hi all, >> >> I had an idea for something that might be useful and wanted to know everyone’s thoughts. >> >> Basically, create a program that will take a Windows executable/dll, find all the imports and check Wine’s .spec files to see if the imports are stubs or don’t exist. Obviously could also go recursive through imports of other dlls down to the win32 sdk level too. >> >> It might help figure out some “why is this program crashing” issues. >> >> Thoughts? >> Rob >> >

March 10, 2025

Re: Wine compatibility checking tool

by Esme Povirk

I don't think it'd be very useful, at least for understanding crashes. If the program actually calls those functions before the crash, there will be a fixme or exception that tells us that (with the possible exception of using GetProcAddress, but we can't detect that from a PE image anyway). On 2025-03-09 22:49, robert lippmann wrote: > Hi all, > > I had an idea for something that might be useful and wanted to know everyone’s thoughts. > > Basically, create a program that will take a Windows executable/dll, find all the imports and check Wine’s .spec files to see if the imports are stubs or don’t exist. Obviously could also go recursive through imports of other dlls down to the win32 sdk level too. > > It might help figure out some “why is this program crashing” issues. > > Thoughts? > Rob > >

March 10, 2025

Wine compatibility checking tool

by robert lippmann

Hi all, I had an idea for something that might be useful and wanted to know everyone’s thoughts. Basically, create a program that will take a Windows executable/dll, find all the imports and check Wine’s .spec files to see if the imports are stubs or don’t exist. Obviously could also go recursive through imports of other dlls down to the win32 sdk level too. It might help figure out some “why is this program crashing” issues. Thoughts? Rob

March 9, 2025

Wine staging 10.3 release

by Alistair Leslie-Hughes

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 10.3 (347 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * oleaut32/tests: Add some tests for loading and saving EMF using IPicture interface. * oleaut32: Add support for loading and saving EMF to IPicture interface. * oleaut32: Implement a better stub for IPicture::SaveAsFile. * oleaut32: Implement SaveAsFile for PICTYPE_ENHMETAFILE. * d3dx9_36: Filter out D3DCompile warning messages that are not present with D3DCompileShader. * setupapi: Rewrite DiskSpaceList logic using lists. * setupapi: Implement SetupAddToDiskSpaceList. * setupapi: Implement SetupQueryDrivesInDiskSpaceList. * setupapi: Ignore deletion of added files in SetupAddToDiskSpaceList. * setupapi: ImplementSetupAddSectionToDiskSpaceList. * setupapi: Implement SetupAddInstallSectionToDiskSpaceList. Removed (No longer required). * server-Realtime_Priority Added: * [21940] msxml: Improve support for the whitespace value. Updated: * vkd3d-latest * d3dx9_36-DDS Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. * Suggest patches to be included in staging. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

March 8, 2025

wine-9.0.1-rc1 Available

by Michael Stefaniuc

Hello, I have pushed wine-9.0.1-rc1 (0186f5408a91049ca9fe564bac36aa7eee718cc3) with tag to https://gitlab.winehq.org/mstefani/wine/-/tree/oldstable https://people.redhat.com/mstefani/wine/stable/ And created the merge request https://gitlab.winehq.org/wine/wine/-/merge_requests/7462 But more importantly I have created the MR to remove myself as maintainer of Stable: https://gitlab.winehq.org/wine/wine/-/merge_requests/7463 In the the last two years I didn't have the time for Wine. So it is better to make space for somebody else. What's new in this release: - Various bug fixes. ---------------------------------------------------------------- ### Bugs fixed in 9.0.1 (total 74): - #25207 SHFileOperation does not create new directory on FO_MOVE - #33050 FDM (Free Download Manager) crashes with page fault when any remote FTP directory opened - #44863 Performance regression in Prince of Persia 3D - #46070 Basemark Web 3.0 Desktop Launcher crashes - #46074 Visio 2013 crashes with unimplemented function msvcr100.dll.??0_ReaderWriterLock(a)details@Concurrency@@QAE(a)XZ - #48110 Multiple .NET 4.x applications need TaskService::ConnectedUser property (Toad for MySQL Freeware 7.x, Microsoft Toolkit from MS Office 2013) - #49089 nProtect Anti-Virus/Spyware 4.0 'tkpl2k64.sys' crashes on unimplemented function 'fltmgr.sys.FltBuildDefaultSecurityDescriptor' - #49703 Ghost Recon fails to start - #49877 Minecraft Education Edition shows error during install: Fails to create scheduled task - #51285 The bmpcoreimage test in user32:cursoricon fails on most Windows versions - #51599 cmd.exe incorrectly parses an all-whitespace line followed by a closing parenthesis - #51813 python fatal error redirecting stdout to file - #51957 Program started via HKLM\Software\Microsoft\Windows\CurrentVersion\App Paths should also be started if extension ".exe" is missing - #52399 SIMATIC WinCC V15.1 Runtime installer: SeCon tool fails with error 5 while trying to create 'C:\\windows\Security\\SecurityController' (needs '%windir%\\security') - #52622 windows-rs 'lib' test crashes on unimplemented function d3dcompiler_47.dll.D3DCreateLinker - #52879 ESET SysInspector 1.4.2.0 crashes on unimplemented function wevtapi.dll.EvtCreateRenderContext - #53934 __unDName fails to demangle a name - #54759 Notepad++: slider of vertical scrollbar is too small for long files - #55000 wineserver crashes below save_all_subkeys after RegUnLoadKey - #55268 user32:cursoricon - LoadImageA() fails in test_monochrome_icon() on Windows 8+ - #55282 Flutter SDK can't find "aapt" program (where.exe is a stub) - #55421 Fallout Tactics launcher has graphics glitches - #55619 VOCALOID AI Shared Editor v.6.1.0 crashes with System.Management.ManagementObject object construction - #55724 mfmediaengine:mfmediaengine sometimes gets a threadpool assertion in Wine - #55765 The 32-bit d2d1:d2d1 frequently crashes on the GitLab CI - #55810 Finding Nemo (Steam): window borders gone missing (virtual desktop) - #55876 Acrom Controller Updater broken due to oleaut32 install - #55883 SpeedWave can't draw Window, needs oleaut32.OleLoadPictureFile(). - #55897 cpython 3.12.0 crashes due to unimplemented CopyFile2 - #55945 KakaoTalk crashes when opening certain profiles after calling GdipDrawImageFX stub - #55997 Dolphin Emulator crashes from 5.0-17264 - #56054 Microsoft Safety Scanner crashes on exit on unimplemented function tbs.dll.GetDeviceIDString - #56062 unimplemented function mgmtapi.dll.SnmpMgrOpen - #56078 LibreOffice 7.6.4 crashes on unimplemented function msvcp140_2.dll.__std_smf_hypot3 - #56093 msys/pacman: fails with "fixup_mmaps_after_fork: VirtualQueryEx failed" - #56122 LANCommander won't start, prints "error code 0x8007046C" (ERROR_MAPPED_ALIGNMENT) - #56133 explorer.exe: Font leak when painting - #56135 Dictionnaire Hachette Multimédia Encyclopédique 98 crashes on start - #56139 scrrun: Dictionary does not allow storing at key Undefined - #56168 dbghelp hits assertion in stabs_pts_read_type_def - #56174 Forza Horizon 4 crashes with concrt140.dll.?_Confirm_cancel(a)_Cancellation_beacon@details(a)Concurrency@@QEAA_NXZ - #56195 Device name inconsistent casing between GetRawInputDeviceInfo and PnP - #56223 winedbg: crashes after loading gecko debug information - #56235 Windows Sysinternals Process Explorer 17.05 crashes showing Threads property page. - #56243 ShowSystray registry key was removed without alternative - #56244 SplashTop RMM client for Atera crashes on unimplemented function shcore.dll.RegisterScaleChangeNotifications - #56256 Windows Sysinternals Process Explorer 17.05 shows incomplete user interface (32-bit). - #56265 Epic Games Launcher 15.21.0 calls unimplemented function cfgmgr32.dll.CM_Get_Device_Interface_PropertyW - #56271 Free Download Manager no longer works after it updated (stuck at 100% CPU, no visible window) - #56309 Across Lite doesn't show the letters properly when typing - #56334 Page fault when querying dinput8_a_EnumDevices - #56357 Zero sized writes using WriteProcessMemory succeed on Windows, but fail on Wine. - #56361 Geovision Parashara's Light (PL9.exe) still crashes in wine - #56367 Tomb Raider 3 GOG crashes at start - #56369 Advanced IP Scanner crashes on unimplemented function netapi32.dll.NetRemoteTOD - #56372 musl based exp2() gives very inaccurate results on i686 - #56400 SSPI authentication does not work when connecting to sql server - #56434 WScript.Network does not implement UserName, ComputerName, and UserDomain properties - #56493 PresentationFontCache.exe crashes during .Net 3.51 SP1 installation - #56498 Incorrect substring expansion for magic variables - #56503 CryptStringToBinary doesn't adds CR before pad bytes in some cases - #56554 ON1 photo raw installs but wont run the application - #56579 Setupapi fails to read correct class GUID and name from INF file containing %strkey% tokens - #56582 vb3 combobox regression: single click scrolls twice - #56598 Calling [vararg] method via ITypeLib without arguments via IDispatch fails - #56599 HWMonitor 1.53 needs unimplemented function pdh.dll.PdhConnectMachineA - #56609 vcrun2008 fails to install - #56653 GetLogicalProcessorInformation can be missing Cache information - #56666 BExAnalyzer from SAP 7.30 does not work correctly - #56730 Access violation in riched20.dll when running EditPad - #56755 White textures in EverQuest (Unsupported Conversion in windowscodec/convert.c) - #56763 Firefox 126.0.1 crashes on startup - #56781 srcrrun: Dictionary setting item to object fails - #56871 The 32-bit wpcap program is working abnormally ### Changes since 9.0: Alex Henrie (10): tbs: Add GetDeviceIDString stub. include: Add mgmtapi.h and LPSNMP_MGR_SESSION. mgmtapi: AddSnmpMgrOpen stub. msvcp140_2: Implement __std_smf_hypot3. where: Implement search with default options. explorer: Fix font handle leaks in virtual desktop. pdh: Add PdhConnectMachineA stub. ntdll/tests: Delete the WineTest registry key when the tests finish. ntdll/tests: Rewrite the RtlQueryRegistryValues tests and add more of them. ntdll: Succeed in RtlQueryRegistryValues on direct query of nonexistent value. Alexandre Julliard (15): winsta: Start time is an input parameter in WinStationGetProcessSid. oleaut32: Fix IDispatch::Invoke for vararg functions with empty varargs. ntdll: Add default values for cache parameters. secur32/tests: Update count for new winehq.org certificate. gitlab: Add 'build' tag on Linux build jobs. gitlab: Remove make -j options. dnsapi/tests: Update tests for winehq.org DNS changes. urlmon/tests: Fix a test that fails after WineHQ updates. wininet/tests: Update issuer check for winehq.org certificate. urlmon/tests: Skip test if ftp connection fails. user32/tests: Fix some sysparams results on recent Windows. dnsapi/tests: Update DNS names for the new test.winehq.org server. wininet/tests: Update certificate for the new test.winehq.org server. secur32/tests: Update expected results for the new test.winehq.org server. winhttp/tests: Allow some more notifications for the new test.winehq.org server. Alistair Leslie-Hughes (3): fltmgr.sys: Implement FltBuildDefaultSecurityDescriptor. fltmgr.sys: Create import library. ntoskrnl/tests: Add FltBuildDefaultSecurityDescriptor test. Andrew Nguyen (2): oleaut32: Bump version resource to Windows 10. ddraw: Reserve extra space in the reference device description buffer. Bartosz Kosiorek (2): gdiplus/tests: Add GdipDrawImageFX tests except effects or attributes. gdiplus: Partially implement GdipDrawImageFX. Benjamin Mayes (1): windowscodecs: Add conversions from PixelFormat32bppBGRA->PixelFormat16bppBGRA5551. Bernhard Übelacker (10): server: Avoid unloading of HKU .Default registry branch. server: Allow VirtualQueryEx on "limited" handle. wing32: Add tests. wing32: Avoid crash in WinGGetDIBPointer when called with NULL bitmap info. dbghelp: Return early if HeapAlloc failed. ntdll: Fix structure layout in RtlQueryProcessDebugInformation for 64-bit. wininet: Add missing assignment of return value. wininet: Avoid crash in InternetCreateUrl with scheme unknown. cmd: Handle lines with just spaces in bracket blocks. cmd: Avoid execution if block misses closing brackets. Dmitry Timoshkov (4): oleaut32: Do not reimplement OleLoadPicture in OleLoadPicturePath. oleaut32: Factor out stream creation from OleLoadPicturePath. oleaut32: Implement OleLoadPictureFile. kerberos: Allocate memory for the output token if requested. Eric Pouech (4): dbghelp: Support redefinition of a range statement. server: Allow 0-write length in WriteProcessMemory(). cmd: Add test for substring handling in 'magic' variable expansion. cmd: Fix substring expansion for 'magic' variables. Esme Povirk (1): gdiplus: Prefer Tahoma for generic sans serif font. Fabian Maurer (11): win32u: Factor out scroll timer handling. win32u: Only set scroll timer if it's not running. oleaut32: Add test for invoking a dispatch get-only property with DISPATCH_PROPERTYPUT. oleaut32: Handle cases where invoking a get-only property with INVOKE_PROPERTYPUT returns DISP_E_BADPARAMCOUNT. riched20: In para_set_fmt protect against out of bound cTabStop values. mmdevapi/tests: Add tests for IAudioSessionControl2 GetDisplayName / SetDisplayName. mmdevapi/tests: Add tests for IAudioSessionControl2 GetIconPath / SetIconPath. mmdevapi/tests: Add tests for IAudioSessionControl2 GetGroupingParam / SetGroupingParam. mmdevapi: Implement IAudioSessionControl2 GetDisplayName / SetDisplayName. mmdevapi: Implement IAudioSessionControl2 GetIconPath / SetIconPath. mmdevapi: Implement IAudioSessionControl2 GetGroupingParam SetGroupingParam. Felix Münchhalfen (2): ntdll: Use pagesize alignment if MEM_REPLACE_PLACEHOLDER is set in flags of NtMapViewOfSection(Ex). kernelbase/tests: Add a test for MapViewOfFile3 with MEM_REPLACE_PLACEHOLDER. Hans Leidekker (12): wbemprox: Protect tables with a critical section. wbemprox: Handle implicit property in object path. netprofm: Support NLM_ENUM_NETWORK flags. netprofm: Set return pointer to NULL in networks_enum_Next(). msi: Install global assemblies before running deferred custom actions. msi: Install global assemblies after install custom actions and before commit custom actions. wpcap: Handle different layout of the native packet header structure on 32-bit. winhttp/tests: Fix test failures introduced by the server upgrade. secur32: Handle GNUTLS_MAC_AEAD. secur32/tests: Switch to TLS 1.2 for connections to test.winehq.org. secur32/tests: Mark some test results as broken on old Windows versions. crypt32/tests: Fix a test failure. Helix Graziani (1): cfgmgr32: Add CM_Get_Device_Interface_PropertyW stub. Jinoh Kang (4): include: Add definition for FILE_STAT_INFORMATION. ntdll/tests: Add tests for NtQueryInformationFile FileStatInformation. ntdll: Implement NtQueryInformationFile FileStatInformation. kernelbase: Replace FileAllInformation with FileStatInformation in GetFileInformationByHandle(). Kartavya Vashishtha (1): kernelbase: Implement CopyFile2(). Louis Lenders (3): shcore: Add stub for RegisterScaleChangeNotifications. shell32: Try appending .exe when looking up an App Paths key. wmic: Support interactive mode and piped commands. Martin Storsjö (1): musl: Fix limiting the float precision in intermediates. Michael Stefaniuc (2): gitlab: Do not run the build script on each commit. tools: Get the ANNOUNCE bug list from the stable-notes git notes. Nicholas Tay (1): win32u: Preserve rawinput device instance ID case in add_device(). Nikolay Sivov (10): scrrun/dictionary: Add support for hashing VT_EMPTY keys. scrrun/dictionary: Add support for hashing VT_NULL keys. scrrun/dictionary: Handle VT_EMPTY/VT_NULL keys. wshom/network: Use TRACE() for implemented method. wshom/network: Implement GetTypeInfo(). wshom/network: Implement ComputerName() property. wshom/network: Check pointer argument in get_UserName(). wshom/network: Implement UserDomain property. d2d1: Fix a double free on error path (Valgrind). scrrun/dictionary: Implement putref_Item() method. Paul Gofman (4): explorer: Don't pop start menu on "minimize all windows" systray command. explorer: Don't pop start menu on "undo minimize all windows" systray command. winhttp: Always return result at once if available in WinHttpQueryDataAvailable(). winhttp: Always return result at once if available in WinHttpReadData(). Peter Johnson (1): wined3d: Added missing GTX 3080 & 1070M. Piotr Caban (5): msvcp140_2: Fix i386 export names. msvcp140_2: Implement __std_smf_hypot3f. msvcp140_t/tests: Add __std_smf_hypot3 tests. concrt140: Add _Cancellation_beacon::_Confirm_cancel() implementation. msvcrt: Store _unDName function parameter backreferences in parsed_symbol structure. Roland Häder (1): wined3d: Added missing GTX 1650. Rémi Bernon (9): dinput/tests: Add some IRawGameController2 interface tests. windows.gaming.input: Stub IRawGameController2 interface. explorer: Restore a per-desktop ShowSystray registry setting. secur32/tests: Update the tests to expect HTTP/2 headers. imm32/tests: Add todo_himc to some ImmTranslateMessage expected calls. urlmon/tests: Expect "Upgrade, Keep-Alive" connection string. user32/tests: Add flaky_wine to some SetActiveWindow tests. wininet: Parse multi-token Connection strings for Keep-Alive. user32/tests: Fix cursoricon tests on recent Windows versions. Sam Joan Roque-Worcel (1): win32u: Make SCROLL_MIN_THUMB larger. Santino Mazza (1): crypt32: Fix CryptBinaryToString not adding a separator. Tim Clem (1): gitlab: Update configuration for the new Mac runner. Tuomas Räsänen (2): setupapi/tests: Add tests for reading INF class with %strkey% tokens. setupapi: Use INF parser to read class GUID and class name. Vijay Kiran Kamuju (10): msvcr100: Add _ReaderWriterLock constructor implementation. wine.inf: Create security directory. concrt140: Add stub for _Cancellation_beacon::_Confirm_cancel(). taskschd: Implement ITaskService_get_ConnectedUser. taskschd: Return success from Principal_put_RunLevel. taskschd: Implement TaskService_get_ConnectedDomain. d3dcompiler: Add D3DCreateLinker stub. netapi32: Add NetRemoteTOD stub. mscms: Add stub for WcsGetDefaultColorProfile. wevtapi: Add stub EvtCreateRenderContext(). Zebediah Figura (4): shell32/tests: Remove obsolete workarounds from test_move(). ddraw: Use system memory for version 4 vertex buffers. ddraw: Upload only the used range of indices in d3d_device7_DrawIndexedPrimitive(). ddraw/tests: Test GetVertexBufferDesc(). Zhenbo Li (1): shell32: Create nonexistent destination directories in FO_MOVE. Zhiyi Zhang (6): include: Rename DF_WINE_CREATE_DESKTOP to DF_WINE_VIRTUAL_DESKTOP. server: Inherit internal desktop flags when creating desktops. rtworkq: Avoid closing a thread pool object while its callbacks are running. rtworkq: Avoid possible scenarios that an async callback could be called twice. user32/tests: Add some ReleaseCapture() tests. win32u: Only send mouse input in ReleaseCapture() when a window is captured. bye michael

March 2, 2025