Wine-Devel

By thread

wine-devel@list.winehq.org

May 2026

18 participants
41 messages

Re: Explanation of CTL_CODES

by Eric Pouech

Le 23/05/2026 à 13:04, Barath Rk via Wine-Devel a écrit : > I am trying to implement the ReadConsoleInputEx(A|W) functions in > kernelbase(It is needed for Microsoft's edit.exe. See bug #58252). I > figured I could do that by defining a new CTL_CODE in > include/wine/condrv.h. > > However, after a long time spent in exploring the source code, I don't > get where the handler for the codes, such IOCTL_CONDRV_READ_INPUT are > defined. > > Would appreciate some direction on this. Thanks in advance. Console ioctl are received by server/console.c and either handled directly inside Wine server, or forwarded to attached conhost (if any) (programs/conhost/conhost.c) Given the nature of ReadConsoleInputEx (being either blocking and non blocking) depending on the passed flags, I strongly suggest staring by writing some tests (dlls/kernel32/tests/console.c) to cover the various aspects of the API HTH -Eric

May 23, 2026

Explanation of CTL_CODES

by Barath Rk

I am trying to implement the ReadConsoleInputEx(A|W) functions in kernelbase(It is needed for Microsoft's edit.exe. See bug #58252). I figured I could do that by defining a new CTL_CODE in include/wine/condrv.h. However, after a long time spent in exploring the source code, I don't get where the handler for the codes, such IOCTL_CONDRV_READ_INPUT are defined. Would appreciate some direction on this. Thanks in advance.

May 23, 2026

Re: Feedback needed for a theme PR

by fatihbakal7＠protonmail.com

Typo. I meant to say "Considering there's still white ui's in windows 11 even when dark theme is enabled (e.g. the properties menu lf a file)

May 19, 2026

Re: Feedback needed for a theme PR

by fatihbakal7＠protonmail.com

Considering there's still white ui's in windows 11 and last wine theming related work seems to be ages ago according to what you said i really think there's no point in waiting anymore. That being said I still need a greenlight/approval on the implementation from somebody from upstream (e.g. Alexandre) If an application breaks with a theme the user can open winecfg and make that prefix not use the optional global theme located at $HOME/.config so not that big of a deal. Something like dll overrides where u can override the theme via the .exe name could be done but seems overkill to me (if there's demand for it i'll do it tho)

May 19, 2026

Re: Feedback needed for a theme PR

by Stefan Dösinger

Am Sonntag, 17. Mai 2026, 15:56:11 Ostafrikanische Zeit schrieb Fatih Bakal via Wine-Devel: > Space isn't my issue at all but would be cool if they all used the same file > anyways. My actual issue is that having to do it manually to each prefix. I > have around 60 prefixes on just 1 computer (I play a lot of games). And > it's really annoying My concern with anything theme related in Wine is that Wine's theming still needs a lot of love/work. Thanks to the hard work Zhiyi we no longer look like Windows 95, but once you go beyond the default theme things still break a lot. Adding an extra configuration option feels like it makes things even more difficult to maintain. Changing the theme is difficult (try to introduce a different highlight color and you'll see), Applications can break (although some break on Windows too). I don't know how well third party Windows themes work - I haven't tried in ages. Having a Wine prefix wide dark mode would be really nice to have, but is mission impossible at the moment (In part because Microsoft decided to make it difficult for Win32 Common Control based things and de facto requires new WinUI for it) I think third party wine managers are less of an issue for themes than for the merge request to change the default Wine prefix location. Two unrelated things got conflated there.

May 19, 2026

Re: Feedback needed for a theme PR

by fatihbakal7＠protonmail.com

Space isn't my issue at all but would be cool if they all used the same file anyways. My actual issue is that having to do it manually to each prefix. I have around 60 prefixes on just 1 computer (I play a lot of games). And it's really annoying

May 17, 2026

Re: Feedback needed for a theme PR

by Gabriel Ivăncescu

If space and duplicated themes is your issue (which is understandable), why not just create a symlink to the theme (directory) yourself in each prefix?

May 17, 2026

Re: Feedback needed for a theme PR

by fatihbakal7＠protonmail.com

As mentioned in the linked issue, making something default (other than the dark theme setting thats just a boolean) won't probably happen because there is a chance actual theming would cause a bit of breakage across uis of different applications thus should be optional. Also that being said the boolean option alone doesn't make wine built in stuff (explorer control taskmgr..) not go dark theme

May 16, 2026

Re: Feedback needed for a theme PR

by Ty

I know some people get crazy when this topic comes up and start going into feature creep, wanting support for different window decorations and having adwaita or other, but just basic dark/light mode automation on the big DE's would go a long way. On Fri, May 15, 2026 at 11:05 PM Fatih Bakal via Wine-Devel < wine-devel(a)list.winehq.org> wrote: > What I have in mind is for it to behave exactly as is. But if user has put > a theme file to $HOME/.config/ it would use that thus making it optional > and not breaking anything. >

May 16, 2026

Re: Feedback needed for a theme PR

by fatihbakal7＠protonmail.com

What I have in mind is for it to behave exactly as is. But if user has put a theme file to $HOME/.config/ it would use that thus making it optional and not breaking anything.

May 16, 2026