July 2026 - Wine-Devel - list.winehq.org

Re: On implementing the 'beep' escape code in conhost

by Barath Rk

> then the latter shouldn't call MessageBeep(). yeah, Beep doesn't call MessageBeep. the beep I am attempting to implement will be done by a change in conhost where if '\a'(int 7) is encountered we call MessageBeep(MB_OK), that's about it On Thu, Jul 23, 2026 at 10:29 PM Elizabeth Figura <zfigura(a)codeweavers.com> wrote: > > On Thursday, 23 July 2026 11:56:38 CDT Barath Rk wrote: > > > Higher than Beep() > > From what I have seen, MessageBeep and Beep appear to be pretty > > different the way they have been implemented right now. MessageBeep > > calls the respective Beep method defined for the particular display > > server protocol being used. Currently only X11/XWayland is > > supported(look at pBeep in x11drv_funcs present in > > dlls/winex11.drv/init.c which is basically just a call to XBell). A > > Beep method for Wayland needs to be implemented. > > > > > MessageBeep() was supposed to call Beep() in fact. > > MSDN claims that Beep is the fallback: > > https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-mess… > > But as it stands MessageBeep doesn't fallback to Beep and in any case > > lBeep isn't even properly implemented. No tone generation seems to be > > in place; it just forwards the request to conhost with the > > IOCTL_CONDRV_BEEP code, which essentially calls the terminal's > > configured beep(only if it is a unix terminal or else it does nothing > > lol). So I suppose Beep should also be properly implemented at some > > point, if desired. > > Well if MessageBeep() might fall back to Beep(), and Beep() calls IOCTL_CONDRV_BEEP, then the latter shouldn't call MessageBeep(). > > > > > On Thu, Jul 23, 2026 at 10:09 PM Elizabeth Figura > > <zfigura(a)codeweavers.com> wrote: > > > > > > On Thursday, 23 July 2026 10:34:37 CDT Eric Pouech via Wine-Devel wrote: > > > > Le 23/07/2026 à 17:06, Elizabeth Figura via Wine-Devel a écrit : > > > > > On Wednesday, 22 July 2026 03:15:12 CDT Eric Pouech via Wine-Devel wrote: > > > > >> Le 22/07/2026 à 03:31, Barath Rk via Wine-Devel a écrit : > > > > >>> Hmm alright. Thanks for the detailed response > > > > >>> > > > > >> MessageBeep shall be used > > > > >> > > > > > Isn't MessageBeep a higher level API? > > > > > > > > > > > > > > > > > > > higher than what? > > > > > > > > (it's supposed to be called from conhost.exe, so I don't see too much > > > > trouble here) > > > > > > Higher than Beep(). I thought that MessageBeep() was supposed to call Beep() in fact. > > > > > > I guess with conhost maybe it is the other way around. > > > > > > > and I tried to avoid calling kernel32.Beep from conhost (it would > > > > require calling some MM apis from kernel32, which doesn't seem great either) > > > > > > > > -Eric > > > > > > > > > > > > > > > > > > > > > >

July 23, 2026

Re: On implementing the 'beep' escape code in conhost

by Elizabeth Figura

On Thursday, 23 July 2026 11:56:38 CDT Barath Rk wrote: > > Higher than Beep() > From what I have seen, MessageBeep and Beep appear to be pretty > different the way they have been implemented right now. MessageBeep > calls the respective Beep method defined for the particular display > server protocol being used. Currently only X11/XWayland is > supported(look at pBeep in x11drv_funcs present in > dlls/winex11.drv/init.c which is basically just a call to XBell). A > Beep method for Wayland needs to be implemented. > > > MessageBeep() was supposed to call Beep() in fact. > MSDN claims that Beep is the fallback: > https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-mess… > But as it stands MessageBeep doesn't fallback to Beep and in any case > lBeep isn't even properly implemented. No tone generation seems to be > in place; it just forwards the request to conhost with the > IOCTL_CONDRV_BEEP code, which essentially calls the terminal's > configured beep(only if it is a unix terminal or else it does nothing > lol). So I suppose Beep should also be properly implemented at some > point, if desired. Well if MessageBeep() might fall back to Beep(), and Beep() calls IOCTL_CONDRV_BEEP, then the latter shouldn't call MessageBeep(). > > On Thu, Jul 23, 2026 at 10:09 PM Elizabeth Figura > <zfigura(a)codeweavers.com> wrote: > > > > On Thursday, 23 July 2026 10:34:37 CDT Eric Pouech via Wine-Devel wrote: > > > Le 23/07/2026 à 17:06, Elizabeth Figura via Wine-Devel a écrit : > > > > On Wednesday, 22 July 2026 03:15:12 CDT Eric Pouech via Wine-Devel wrote: > > > >> Le 22/07/2026 à 03:31, Barath Rk via Wine-Devel a écrit : > > > >>> Hmm alright. Thanks for the detailed response > > > >>> > > > >> MessageBeep shall be used > > > >> > > > > Isn't MessageBeep a higher level API? > > > > > > > > > > > > > > > higher than what? > > > > > > (it's supposed to be called from conhost.exe, so I don't see too much > > > trouble here) > > > > Higher than Beep(). I thought that MessageBeep() was supposed to call Beep() in fact. > > > > I guess with conhost maybe it is the other way around. > > > > > and I tried to avoid calling kernel32.Beep from conhost (it would > > > require calling some MM apis from kernel32, which doesn't seem great either) > > > > > > -Eric > > > > > > > > > > > >

July 23, 2026

Re: On implementing the 'beep' escape code in conhost

by Barath Rk

> Higher than Beep() From what I have seen, MessageBeep and Beep appear to be pretty different the way they have been implemented right now. MessageBeep calls the respective Beep method defined for the particular display server protocol being used. Currently only X11/XWayland is supported(look at pBeep in x11drv_funcs present in dlls/winex11.drv/init.c which is basically just a call to XBell). A Beep method for Wayland needs to be implemented. > MessageBeep() was supposed to call Beep() in fact. MSDN claims that Beep is the fallback: https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-mess… But as it stands MessageBeep doesn't fallback to Beep and in any case lBeep isn't even properly implemented. No tone generation seems to be in place; it just forwards the request to conhost with the IOCTL_CONDRV_BEEP code, which essentially calls the terminal's configured beep(only if it is a unix terminal or else it does nothing lol). So I suppose Beep should also be properly implemented at some point, if desired. On Thu, Jul 23, 2026 at 10:09 PM Elizabeth Figura <zfigura(a)codeweavers.com> wrote: > > On Thursday, 23 July 2026 10:34:37 CDT Eric Pouech via Wine-Devel wrote: > > Le 23/07/2026 à 17:06, Elizabeth Figura via Wine-Devel a écrit : > > > On Wednesday, 22 July 2026 03:15:12 CDT Eric Pouech via Wine-Devel wrote: > > >> Le 22/07/2026 à 03:31, Barath Rk via Wine-Devel a écrit : > > >>> Hmm alright. Thanks for the detailed response > > >>> > > >> MessageBeep shall be used > > >> > > > Isn't MessageBeep a higher level API? > > > > > > > > > > > higher than what? > > > > (it's supposed to be called from conhost.exe, so I don't see too much > > trouble here) > > Higher than Beep(). I thought that MessageBeep() was supposed to call Beep() in fact. > > I guess with conhost maybe it is the other way around. > > > and I tried to avoid calling kernel32.Beep from conhost (it would > > require calling some MM apis from kernel32, which doesn't seem great either) > > > > -Eric > > > > > >

July 23, 2026

Re: On implementing the 'beep' escape code in conhost

by Elizabeth Figura

On Thursday, 23 July 2026 10:34:37 CDT Eric Pouech via Wine-Devel wrote: > Le 23/07/2026 à 17:06, Elizabeth Figura via Wine-Devel a écrit : > > On Wednesday, 22 July 2026 03:15:12 CDT Eric Pouech via Wine-Devel wrote: > >> Le 22/07/2026 à 03:31, Barath Rk via Wine-Devel a écrit : > >>> Hmm alright. Thanks for the detailed response > >>> > >> MessageBeep shall be used > >> > > Isn't MessageBeep a higher level API? > > > > > > > higher than what? > > (it's supposed to be called from conhost.exe, so I don't see too much > trouble here) Higher than Beep(). I thought that MessageBeep() was supposed to call Beep() in fact. I guess with conhost maybe it is the other way around. > and I tried to avoid calling kernel32.Beep from conhost (it would > require calling some MM apis from kernel32, which doesn't seem great either) > > -Eric >

July 23, 2026

Re: On implementing the 'beep' escape code in conhost

by Stian Low

You may unsubscribe yourself from wine-devel via: https://gitlab.winehq.org/wine/wine/-/wikis/Forums#developer-mailing-lists On Thu, Jul 23, 2026 at 4:00 PM Senthil Lewituz via Wine-Devel < wine-devel(a)list.winehq.org> wrote: > Please unsubscribe > > Get Outlook for iOS <https://aka.ms/o0ukef> > ------------------------------ > *From:* Eric Pouech via Wine-Devel <wine-devel(a)list.winehq.org> > *Sent:* Thursday, 23 July 2026 19:34:37 > *To:* wine-devel(a)list.winehq.org <wine-devel(a)list.winehq.org> > *Cc:* Barath Rk <barathrk11(a)gmail.com>; Elizabeth Figura < > zfigura(a)codeweavers.com>; Eric Pouech <eric.pouech(a)orange.fr> > *Subject:* Re: On implementing the 'beep' escape code in conhost > > Le 23/07/2026 à 17:06, Elizabeth Figura via Wine-Devel a écrit : > > On Wednesday, 22 July 2026 03:15:12 CDT Eric Pouech via Wine-Devel wrote: > > Le 22/07/2026 à 03:31, Barath Rk via Wine-Devel a écrit : > > Hmm alright. Thanks for the detailed response > > > MessageBeep shall be used > > > Isn't MessageBeep a higher level API? > > > > > higher than what? > > (it's supposed to be called from conhost.exe, so I don't see too much > trouble here) > > and I tried to avoid calling kernel32.Beep from conhost (it would require > calling some MM apis from kernel32, which doesn't seem great either) > > -Eric >

July 23, 2026

Re: On implementing the 'beep' escape code in conhost

by Senthil Lewituz

Please unsubscribe Get Outlook for iOS<https://aka.ms/o0ukef> ________________________________ From: Eric Pouech via Wine-Devel <wine-devel(a)list.winehq.org> Sent: Thursday, 23 July 2026 19:34:37 To: wine-devel(a)list.winehq.org <wine-devel(a)list.winehq.org> Cc: Barath Rk <barathrk11(a)gmail.com>; Elizabeth Figura <zfigura(a)codeweavers.com>; Eric Pouech <eric.pouech(a)orange.fr> Subject: Re: On implementing the 'beep' escape code in conhost Le 23/07/2026 à 17:06, Elizabeth Figura via Wine-Devel a écrit : On Wednesday, 22 July 2026 03:15:12 CDT Eric Pouech via Wine-Devel wrote: Le 22/07/2026 à 03:31, Barath Rk via Wine-Devel a écrit : Hmm alright. Thanks for the detailed response MessageBeep shall be used Isn't MessageBeep a higher level API? higher than what? (it's supposed to be called from conhost.exe, so I don't see too much trouble here) and I tried to avoid calling kernel32.Beep from conhost (it would require calling some MM apis from kernel32, which doesn't seem great either) -Eric

July 23, 2026

Re: On implementing the 'beep' escape code in conhost

by Eric Pouech

Le 23/07/2026 à 17:06, Elizabeth Figura via Wine-Devel a écrit : > On Wednesday, 22 July 2026 03:15:12 CDT Eric Pouech via Wine-Devel wrote: >> Le 22/07/2026 à 03:31, Barath Rk via Wine-Devel a écrit : >>> Hmm alright. Thanks for the detailed response >>> >> MessageBeep shall be used >> > Isn't MessageBeep a higher level API? > > > higher than what? (it's supposed to be called from conhost.exe, so I don't see too much trouble here) and I tried to avoid calling kernel32.Beep from conhost (it would require calling some MM apis from kernel32, which doesn't seem great either) -Eric

July 23, 2026

Re: On implementing the 'beep' escape code in conhost

by Elizabeth Figura

On Wednesday, 22 July 2026 03:15:12 CDT Eric Pouech via Wine-Devel wrote: > Le 22/07/2026 à 03:31, Barath Rk via Wine-Devel a écrit : > > Hmm alright. Thanks for the detailed response > > > MessageBeep shall be used > Isn't MessageBeep a higher level API?

July 23, 2026

Re: On implementing the 'beep' escape code in conhost

by Barath Rk

Fair enough lol. Thanks On Thu, 23 Jul, 2026, 4:15 pm Stian Low via Wine-Devel, < wine-devel(a)list.winehq.org> wrote: > Probably simpler for you to get started at this point and ask forgiveness > for minor mistakes rather than permission. > > Git history/logs for files touched is often reliable for determining > maintainers if not updated elsewhere yet. > > > On Thu, Jul 23, 2026 at 9:59 AM Barath Rk via Wine-Devel < > wine-devel(a)list.winehq.org> wrote: > >> > If your MRs have distinct maintainers, and you get their approval, >> then you should be fine >> >> Should I have to ping the maintainer beforehand to get their opinion >> on opening an MR? >> >> If so, any idea who I am supposed to ping for the Wayland MR? I know >> Eric deals with console related stuff but I don't see any entry in the >> MAINTAINERS file for the wayland driver maintainer. >> >> On Thu, Jul 23, 2026 at 2:45 PM Jinoh Kang <jinoh.kang.kr(a)gmail.com> >> wrote: >> > >> > On Thu, Jul 23, 2026, 17:19 Barath Rk via Wine-Devel < >> wine-devel(a)list.winehq.org> wrote: >> >> >> >> Then would it be fine to create 2 MRs at the same time? I was a little >> biased towards 1 MR 2 Commits because of the wiki stating that multiple >> outstanding MRs from an individual are discouraged. >> >> >> > >> > The same principle applies to one MR encompassing multiple >> functionalities. >> > >> > The rule isn't clear cut, and is intended to discourage overflowing >> reviewer resources by e.g., making the same mistake across multuple MRs. If >> your MRs have distinct maintainers, and you get their approval, then you >> should be fine. >> > >> > >> > -- >> > Jinoh >> >

July 23, 2026

Re: On implementing the 'beep' escape code in conhost

by Stian Low

Probably simpler for you to get started at this point and ask forgiveness for minor mistakes rather than permission. Git history/logs for files touched is often reliable for determining maintainers if not updated elsewhere yet. On Thu, Jul 23, 2026 at 9:59 AM Barath Rk via Wine-Devel < wine-devel(a)list.winehq.org> wrote: > > If your MRs have distinct maintainers, and you get their approval, then > you should be fine > > Should I have to ping the maintainer beforehand to get their opinion > on opening an MR? > > If so, any idea who I am supposed to ping for the Wayland MR? I know > Eric deals with console related stuff but I don't see any entry in the > MAINTAINERS file for the wayland driver maintainer. > > On Thu, Jul 23, 2026 at 2:45 PM Jinoh Kang <jinoh.kang.kr(a)gmail.com> > wrote: > > > > On Thu, Jul 23, 2026, 17:19 Barath Rk via Wine-Devel < > wine-devel(a)list.winehq.org> wrote: > >> > >> Then would it be fine to create 2 MRs at the same time? I was a little > biased towards 1 MR 2 Commits because of the wiki stating that multiple > outstanding MRs from an individual are discouraged. > >> > > > > The same principle applies to one MR encompassing multiple > functionalities. > > > > The rule isn't clear cut, and is intended to discourage overflowing > reviewer resources by e.g., making the same mistake across multuple MRs. If > your MRs have distinct maintainers, and you get their approval, then you > should be fine. > > > > > > -- > > Jinoh >

July 23, 2026