July 2026 - Wine-Devel - list.winehq.org

Re: On implementing the 'beep' escape code in conhost

by Barath Rk

> If your MRs have distinct maintainers, and you get their approval, then you should be fine Should I have to ping the maintainer beforehand to get their opinion on opening an MR? If so, any idea who I am supposed to ping for the Wayland MR? I know Eric deals with console related stuff but I don't see any entry in the MAINTAINERS file for the wayland driver maintainer. On Thu, Jul 23, 2026 at 2:45 PM Jinoh Kang <jinoh.kang.kr(a)gmail.com> wrote: > > On Thu, Jul 23, 2026, 17:19 Barath Rk via Wine-Devel <wine-devel(a)list.winehq.org> wrote: >> >> Then would it be fine to create 2 MRs at the same time? I was a little biased towards 1 MR 2 Commits because of the wiki stating that multiple outstanding MRs from an individual are discouraged. >> > > The same principle applies to one MR encompassing multiple functionalities. > > The rule isn't clear cut, and is intended to discourage overflowing reviewer resources by e.g., making the same mistake across multuple MRs. If your MRs have distinct maintainers, and you get their approval, then you should be fine. > > > -- > Jinoh

July 23, 2026

Re: On implementing the 'beep' escape code in conhost

by Jinoh Kang

On Thu, Jul 23, 2026, 17:19 Barath Rk via Wine-Devel < wine-devel(a)list.winehq.org> wrote: > Then would it be fine to create 2 MRs at the same time? I was a little > biased towards 1 MR 2 Commits because of the wiki stating that multiple > outstanding MRs from an individual are discouraged. > > The same principle applies to one MR encompassing multiple functionalities. The rule isn't clear cut, and is intended to discourage overflowing reviewer resources by e.g., making the same mistake across multuple MRs. If your MRs have distinct maintainers, and you get their approval, then you should be fine. > -- Jinoh

July 23, 2026

Re: On implementing the 'beep' escape code in conhost

by Barath Rk

Then would it be fine to create 2 MRs at the same time? I was a little biased towards 1 MR 2 Commits because of the wiki stating that multiple outstanding MRs from an individual are discouraged. On Thu, 23 Jul, 2026, 1:16 pm Eric Pouech, <eric.pouech(a)orange.fr> wrote: > Le 23/07/2026 à 08:15, Barath Rk via Wine-Devel a écrit : > > Using MessageBeep for the implementation works on XWayland, but using > > Wayland I don't get the Beep as it is not implemented in the > > winewayland driver. How would the workflow look for implementing this? > > Would I have to open a separate MR or can I just add the Wayland Beep > > implementation as another commit in the same MR as the console Beep > > implementation? > > both approaches are valid > > using 1MR+2commits make clean why you're adding code to wayland driver > > but has the drawback of involving several maintainers > >

July 23, 2026

Re: On implementing the 'beep' escape code in conhost

by Eric Pouech

Le 23/07/2026 à 08:15, Barath Rk via Wine-Devel a écrit : > Using MessageBeep for the implementation works on XWayland, but using > Wayland I don't get the Beep as it is not implemented in the > winewayland driver. How would the workflow look for implementing this? > Would I have to open a separate MR or can I just add the Wayland Beep > implementation as another commit in the same MR as the console Beep > implementation? both approaches are valid using 1MR+2commits make clean why you're adding code to wayland driver but has the drawback of involving several maintainers

July 23, 2026

Re: On implementing the 'beep' escape code in conhost

by Barath Rk

Using MessageBeep for the implementation works on XWayland, but using Wayland I don't get the Beep as it is not implemented in the winewayland driver. How would the workflow look for implementing this? Would I have to open a separate MR or can I just add the Wayland Beep implementation as another commit in the same MR as the console Beep implementation? Regards Barath Kannan On Wed, Jul 22, 2026 at 1:45 PM Eric Pouech <eric.pouech(a)orange.fr> wrote: > > Le 22/07/2026 à 03:31, Barath Rk via Wine-Devel a écrit : > > Hmm alright. Thanks for the detailed response > > > MessageBeep shall be used

July 23, 2026

Re: On implementing the 'beep' escape code in conhost

by Eric Pouech

Le 22/07/2026 à 03:31, Barath Rk via Wine-Devel a écrit : > Hmm alright. Thanks for the detailed response > MessageBeep shall be used

July 22, 2026

Re: On implementing the 'beep' escape code in conhost

by Barath Rk

Hmm alright. Thanks for the detailed response Regards Barath Kannan On Wed, 22 Jul, 2026, 12:19 am Stian Low via Wine-Devel, < wine-devel(a)list.winehq.org> wrote: > Beeps are very simple and should probably just be recreated similarly via > one of wine's multimedia libs. > > Windows sounds are probably not redistributable which are regardless also > not included with wine for legal purposes hence winetricks. > > Search repo for WAV files for tests/examples: > > ./dlls/dmime/tests/resource.rc:21:/* ffmpeg -f lavfi -i > "sine=frequency=600" -t 0.1 -ar 44100 -f wav -acodec pcm_u8 test.wav */ > > Code generated sounds are probably better for simplicity vs using more > elaborate sound tools such as LMMS. > > Suggested impl seems reasonable otherwise. > > > On Tue, Jul 21, 2026 at 5:02 PM Barath Rk via Wine-Devel < > wine-devel(a)list.winehq.org> wrote: > >> This is in reference to https://bugs.winehq.org/show_bug.cgi?id=50109 >> >> Looking at Windows 10, the console 'beep' sound is represented in the >> registry under the respective key as a path i.e. >> C:\Windows\media\sound.wav. So the implementation should be as simple >> as getting the value from this key and calling PlaySound on the >> retrieved path. >> >> Is this the expected way to implement the beep? >> >> Also, would it be alright to simply get the .wav files from a Windows >> 10 install and store them in a windows\media folder when the wine >> prefix is created or will there be (legal)issues lifting the .wav >> files from Win10? >> >> Regards >> Barath Kannan >> >

July 22, 2026

Re: On implementing the 'beep' escape code in conhost

by Stian Low

Beeps are very simple and should probably just be recreated similarly via one of wine's multimedia libs. Windows sounds are probably not redistributable which are regardless also not included with wine for legal purposes hence winetricks. Search repo for WAV files for tests/examples: ./dlls/dmime/tests/resource.rc:21:/* ffmpeg -f lavfi -i "sine=frequency=600" -t 0.1 -ar 44100 -f wav -acodec pcm_u8 test.wav */ Code generated sounds are probably better for simplicity vs using more elaborate sound tools such as LMMS. Suggested impl seems reasonable otherwise. On Tue, Jul 21, 2026 at 5:02 PM Barath Rk via Wine-Devel < wine-devel(a)list.winehq.org> wrote: > This is in reference to https://bugs.winehq.org/show_bug.cgi?id=50109 > > Looking at Windows 10, the console 'beep' sound is represented in the > registry under the respective key as a path i.e. > C:\Windows\media\sound.wav. So the implementation should be as simple > as getting the value from this key and calling PlaySound on the > retrieved path. > > Is this the expected way to implement the beep? > > Also, would it be alright to simply get the .wav files from a Windows > 10 install and store them in a windows\media folder when the wine > prefix is created or will there be (legal)issues lifting the .wav > files from Win10? > > Regards > Barath Kannan >

July 21, 2026

On implementing the 'beep' escape code in conhost

by Barath Rk

This is in reference to https://bugs.winehq.org/show_bug.cgi?id=50109 Looking at Windows 10, the console 'beep' sound is represented in the registry under the respective key as a path i.e. C:\Windows\media\sound.wav. So the implementation should be as simple as getting the value from this key and calling PlaySound on the retrieved path. Is this the expected way to implement the beep? Also, would it be alright to simply get the .wav files from a Windows 10 install and store them in a windows\media folder when the wine prefix is created or will there be (legal)issues lifting the .wav files from Win10? Regards Barath Kannan

July 21, 2026

Re: Please unsubscribe me

by Stian Low

You may unsubscribe yourself from wine-devel via: https://gitlab.winehq.org/wine/wine/-/wikis/Forums#developer-mailing-lists On Tue, Jul 21, 2026 at 11:00 AM Yusuf via Wine-Devel < wine-devel(a)list.winehq.org> wrote: > I dont know how I am subscribed. Please remove me promptly, I don't > support the project. > >

July 21, 2026